Fixed inverted LED logic in the OLIMEX162 board LED driver.
authorDean Camera <dean@fourwalledcubicle.com>
Tue, 20 Mar 2012 06:18:41 +0000 (06:18 +0000)
committerDean Camera <dean@fourwalledcubicle.com>
Tue, 20 Mar 2012 06:18:41 +0000 (06:18 +0000)
LUFA/DoxygenPages/ChangeLog.txt
LUFA/Drivers/Board/AVR8/OLIMEX162/LEDs.h

index 7d0b63e..ba9c805 100644 (file)
@@ -28,6 +28,7 @@
   *   - Fixed incorrect call to the user callback CALLBACK_Audio_Device_GetSetInterfaceProperty() in the Audio Class device driver (thanks to Tiit Ratsep)
   *   - Fixed compile error for the UC3 architecture when INTERRUPT_CONTROL_ENDPOINT is specified (thanks to Andrus Aaslaid)
   *   - Fixed compile error if LEDs_Disable() is called and BOARD=NONE is set (thanks to Sam Lin)
+  *   - Fixed inverted LED logic in the OLIMEX162 board LED driver
   *  - Library Applications:
   *   - Fixed error in the AVRISP-MKII programmer when ISP mode is used at 64KHz (thanks to Ben R. Porter)
   *
index 2e18e10..c9bd3f1 100644 (file)
@@ -76,8 +76,8 @@
                #if !defined(__DOXYGEN__)
                        static inline void LEDs_Init(void)
                        {
-                               DDRD  |= LEDS_ALL_LEDS;
-                               PORTD |= LEDS_ALL_LEDS;
+                               DDRD  |=  LEDS_ALL_LEDS;
+                               PORTD &= ~LEDS_ALL_LEDS;
                        }
 
                        static inline void LEDs_Disable(void)
 
                        static inline void LEDs_TurnOnLEDs(const uint8_t LEDMask)
                        {
-                               PORTD &= ~LEDMask;
+                               PORTD |= LEDMask;
                        }
 
                        static inline void LEDs_TurnOffLEDs(const uint8_t LEDMask)
                        {
-                               PORTD |= LEDMask;
+                               PORTD &= ~LEDMask;
                        }
 
                        static inline void LEDs_SetAllLEDs(const uint8_t LEDMask)
                        {
-                               PORTD = ((PORTD | LEDS_ALL_LEDS) & ~LEDMask);
+                               PORTD = ((PORTD & ~LEDS_ALL_LEDS) | LEDMask);
                        }
 
                        static inline void LEDs_ChangeLEDs(const uint8_t LEDMask,
                                                           const uint8_t ActiveMask)
                        {
-                               PORTD = ((PORTD | LEDMask) & ~ActiveMask);
+                               PORTD = ((PORTD & ~LEDMask) | ActiveMask);
                        }
 
                        static inline void LEDs_ToggleLEDs(const uint8_t LEDMask)
                        static inline uint8_t LEDs_GetLEDs(void) ATTR_WARN_UNUSED_RESULT;
                        static inline uint8_t LEDs_GetLEDs(void)
                        {
-                               return (~PORTD & LEDS_ALL_LEDS);
+                               return (PORTD & LEDS_ALL_LEDS);
                        }
                #endif