Fixed Device mode HID Class driver not explicitly initializing the ReportSize paramet...

diff --git a/LUFA/Drivers/USB/Class/Device/HID.c b/LUFA/Drivers/USB/Class/Device/HID.c
index b44d4db..a99c264 100644 (file)
--- a/LUFA/Drivers/USB/Class/Device/HID.c
+++ b/LUFA/Drivers/USB/Class/Device/HID.c
@@ -48,8 +48,8 @@ void HID_Device_ProcessControlRequest(USB_ClassInfo_HID_Device_t* const HIDInter
                        {\r
                                Endpoint_ClearSETUP();  \r
 \r
                        {\r
                                Endpoint_ClearSETUP();  \r
 \r

-                               uint16_t ReportINSize;\r
-                               uint8_t  ReportID = (USB_ControlRequest.wValue & 0xFF);\r
+                               uint16_t ReportINSize = 0;\r
+                               uint8_t  ReportID     = (USB_ControlRequest.wValue & 0xFF);\r

 \r
                                memset(HIDInterfaceInfo->Config.PrevReportINBuffer, 0, HIDInterfaceInfo->Config.PrevReportINBufferSize);\r
                                \r
 \r
                                memset(HIDInterfaceInfo->Config.PrevReportINBuffer, 0, HIDInterfaceInfo->Config.PrevReportINBufferSize);\r
                                \r


@@ -151,8 +151,8 @@ void HID_Device_USBTask(USB_ClassInfo_HID_Device_t* const HIDInterfaceInfo)
        if (Endpoint_IsReadWriteAllowed())\r
        {\r
                uint8_t  ReportINData[HIDInterfaceInfo->Config.PrevReportINBufferSize];\r
        if (Endpoint_IsReadWriteAllowed())\r
        {\r
                uint8_t  ReportINData[HIDInterfaceInfo->Config.PrevReportINBufferSize];\r

-               uint8_t  ReportID = 0;\r
-               uint16_t ReportINSize;\r
+               uint8_t  ReportID     = 0;\r
+               uint16_t ReportINSize = 0;\r

 \r
                memset(ReportINData, 0, sizeof(ReportINData));\r
 \r
 \r
                memset(ReportINData, 0, sizeof(ReportINData));\r
 \r

diff --git a/LUFA/ManPages/ChangeLog.txt b/LUFA/ManPages/ChangeLog.txt
index 13cf672..b5f1590 100644 (file)
--- a/LUFA/ManPages/ChangeLog.txt
+++ b/LUFA/ManPages/ChangeLog.txt
@@ -43,6 +43,8 @@
   *  - Added hardware USART receive interrupt and software buffering to the Benito project to ensure received data is not\r
   *    missed or corrupted\r
   *  - Fixed Device mode HID Class driver always sending IN packets, even when nothing to report\r
   *  - Added hardware USART receive interrupt and software buffering to the Benito project to ensure received data is not\r
   *    missed or corrupted\r
   *  - Fixed Device mode HID Class driver always sending IN packets, even when nothing to report\r

+  *  - Fixed Device mode HID Class driver not explicitly initializing the ReportSize parameter to zero before calling callback\r
+  *    routine, so that ignored callbacks don't cause incorrect data to be sent\r

   *\r
   *\r
   *  \section Sec_ChangeLog090810 Version 090810\r
   *\r
   *\r
   *  \section Sec_ChangeLog090810 Version 090810\r

diff --git a/LUFA/ManPages/FutureChanges.txt b/LUFA/ManPages/FutureChanges.txt
index ae592fd..639e4ee 100644 (file)
--- a/LUFA/ManPages/FutureChanges.txt
+++ b/LUFA/ManPages/FutureChanges.txt
@@ -12,7 +12,6 @@
   *  or post your suggestion as an enhancement request to the project bug tracker.\r
   *\r
   *  <b>Targeted for This Release:</b>\r
   *  or post your suggestion as an enhancement request to the project bug tracker.\r
   *\r
   *  <b>Targeted for This Release:</b>\r

-  *  - Simplify Mass Storage Host LowLevel SCSI demo\r

   *  - Finish Host Mode Class Drivers\r
   *      ( ) Audio\r
   *      (C) CDC\r
   *  - Finish Host Mode Class Drivers\r
   *      ( ) Audio\r
   *      (C) CDC\r