Remove dual ISR for software PDI mode, use a single ISR instead to reduce code comple...

diff --git a/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.c b/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.c
index 7bef25e..85a7504 100644 (file)
--- a/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.c
+++ b/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.c
@@ -49,59 +49,53 @@ volatile uint16_t           SoftUSART_Data;
 #define SoftUSART_BitCount  GPIOR2\r
 \r
 \r
-/** ISR to manage the rising edge of the PDI/TPI software USART when bit-banged USART mode is selected. */\r
+/** ISR to manage the PDI software USART when bit-banged PDI USART mode is selected. */\r
 ISR(TIMER1_COMPA_vect, ISR_BLOCK)\r
 {\r
        /* Toggle CLOCK pin in a single cycle (see AVR datasheet) */\r
        BITBANG_PDICLOCK_PIN |= BITBANG_PDICLOCK_MASK;\r
-       TIFR1 |= (1 << OCF1B);\r
-       TIMSK1 = (1 << OCIE1B);\r
 \r
        /* If not sending or receiving, just exit */\r
        if (!(SoftUSART_BitCount))\r
          return;\r
 \r
-       /* If at rising clock edge and we are in send mode, abort */\r
-       if (IsSending)\r
-         return;\r
-         \r
-       /* Wait for the start bit when receiving */\r
-       if ((SoftUSART_BitCount == BITS_IN_USART_FRAME) && (BITBANG_PDIDATA_PIN & BITBANG_PDIDATA_MASK))\r
-         return;\r
-\r
-       /* Shift in the bit one less than the frame size in position, so that the start bit will eventually\r
-        * be discarded leaving the data to be byte-aligned for quick access (subtract 9 as we are ORing to the MSB) */\r
-       if (BITBANG_PDIDATA_PIN & BITBANG_PDIDATA_MASK)\r
-         ((uint8_t*)&SoftUSART_Data)[1] |= (1 << (BITS_IN_USART_FRAME - 9));\r
-\r
-       SoftUSART_Data >>= 1;\r
-       SoftUSART_BitCount--;\r
-}\r
+       if (BITBANG_PDICLOCK_PORT & BITBANG_PDICLOCK_MASK)\r
+       {\r
+               /* If at rising clock edge and we are in send mode, abort */\r
+               if (IsSending)\r
+                 return;\r
+                 \r
+               /* Wait for the start bit when receiving */\r
+               if ((SoftUSART_BitCount == BITS_IN_USART_FRAME) && (BITBANG_PDIDATA_PIN & BITBANG_PDIDATA_MASK))\r
+                 return;\r
 \r
-/** ISR to manage the falling edge of the PDI/TPI software USART when bit-banged USART mode is selected. */\r
-ISR(TIMER1_COMPB_vect, ISR_BLOCK)\r
-{\r
-       /* Toggle CLOCK pin in a single cycle (see AVR datasheet) */\r
-       BITBANG_PDICLOCK_PIN |= BITBANG_PDICLOCK_MASK;\r
-       TIFR1 |= (1 << OCF1A);\r
-       TIMSK1 = (1 << OCIE1A);\r
+               /* Shift in the bit one less than the frame size in position, so that the start bit will eventually\r
+                * be discarded leaving the data to be byte-aligned for quick access (subtract 9 as we are ORing to the MSB) */\r
+               if (BITBANG_PDIDATA_PIN & BITBANG_PDIDATA_MASK)\r
+                 ((uint8_t*)&SoftUSART_Data)[1] |= (1 << (BITS_IN_USART_FRAME - 9));\r
 \r
-       /* If not sending or receiving, just exit */\r
-       if (!(SoftUSART_BitCount))\r
-         return;\r
+               SoftUSART_Data >>= 1;\r
+               SoftUSART_BitCount--;\r
+       }\r
+       else\r
+       {\r
+               /* If not sending or receiving, just exit */\r
+               if (!(SoftUSART_BitCount))\r
+                 return;\r
 \r
-       /* If at falling clock edge and we are in receive mode, abort */\r
-       if (!IsSending)\r
-         return;\r
+               /* If at falling clock edge and we are in receive mode, abort */\r
+               if (!IsSending)\r
+                 return;\r
 \r
-       /* Set the data line to the next bit value */\r
-       if (((uint8_t*)&SoftUSART_Data)[0] & 0x01)\r
-         BITBANG_PDIDATA_PORT |=  BITBANG_PDIDATA_MASK;\r
-       else\r
-         BITBANG_PDIDATA_PORT &= ~BITBANG_PDIDATA_MASK;                  \r
+               /* Set the data line to the next bit value */\r
+               if (((uint8_t*)&SoftUSART_Data)[0] & 0x01)\r
+                 BITBANG_PDIDATA_PORT |=  BITBANG_PDIDATA_MASK;\r
+               else\r
+                 BITBANG_PDIDATA_PORT &= ~BITBANG_PDIDATA_MASK;                  \r
 \r
-       SoftUSART_Data >>= 1;\r
-       SoftUSART_BitCount--;\r
+               SoftUSART_Data >>= 1;\r
+               SoftUSART_BitCount--;   \r
+       }\r
 }\r
 \r
 /** ISR to manage the TPI software USART when bit-banged TPI USART mode is selected. */\r
@@ -183,7 +177,6 @@ void XPROGTarget_EnableTargetPDI(void)
        OCR1A   = BITS_BETWEEN_USART_CLOCKS;\r
        OCR1B   = BITS_BETWEEN_USART_CLOCKS;\r
        TCCR1B  = (1 << WGM12) | (1 << CS10);\r
-       TCCR1C  = (1 << FOC1B);\r
        TIMSK1  = (1 << OCIE1A);\r
 #endif\r
 \r
@@ -253,7 +246,6 @@ void XPROGTarget_DisableTargetPDI(void)
 #else\r
        /* Turn off software USART management timer */\r
        TCCR1B = 0;\r
-       TCCR1C = 0;\r
 \r
        /* Set /RESET high for a one millisecond to ensure target device is restarted */\r
        BITBANG_PDICLOCK_PORT |= BITBANG_PDICLOCK_MASK;\r

diff --git a/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.h b/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.h
index 0c54ad4..7ebed12 100644 (file)
--- a/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.h
+++ b/Projects/AVRISP-MKII/Lib/XPROG/XPROGTarget.h
@@ -57,7 +57,27 @@
 \r
        /* Defines: */\r
                #if ((BOARD == BOARD_XPLAIN) || (BOARD == BOARD_XPLAIN_REV1))\r
-                       #define XPROG_VIA_HARDWARE_USART\r
+//                     #define XPROG_VIA_HARDWARE_USART\r
+\r
+                       #define BITBANG_PDIDATA_PORT     PORTD\r
+                       #define BITBANG_PDIDATA_DDR      DDRD\r
+                       #define BITBANG_PDIDATA_PIN      PIND\r
+                       #define BITBANG_PDIDATA_MASK     (1 << 3)\r
+                       \r
+                       #define BITBANG_PDICLOCK_PORT    PORTD\r
+                       #define BITBANG_PDICLOCK_DDR     DDRD\r
+                       #define BITBANG_PDICLOCK_PIN     PIND\r
+                       #define BITBANG_PDICLOCK_MASK    (1 << 5)\r
+\r
+                       #define BITBANG_TPIDATA_PORT     PORTB\r
+                       #define BITBANG_TPIDATA_DDR      DDRB\r
+                       #define BITBANG_TPIDATA_PIN      PINB\r
+                       #define BITBANG_TPIDATA_MASK     (1 << 3)\r
+                               \r
+                       #define BITBANG_TPICLOCK_PORT    PORTB\r
+                       #define BITBANG_TPICLOCK_DDR     DDRB\r
+                       #define BITBANG_TPICLOCK_PIN     PINB\r
+                       #define BITBANG_TPICLOCK_MASK    (1 << 1)\r
                #else\r
                        #define BITBANG_PDIDATA_PORT     PORTB\r
                        #define BITBANG_PDIDATA_DDR      DDRB\r

diff --git a/Projects/AVRISP-MKII/makefile b/Projects/AVRISP-MKII/makefile
index b0b26c2..b2c139c 100644 (file)
--- a/Projects/AVRISP-MKII/makefile
+++ b/Projects/AVRISP-MKII/makefile
@@ -66,7 +66,7 @@ MCU = at90usb1287
 # Target board (see library "Board Types" documentation, NONE for projects not requiring\r
 # LUFA board drivers). If USER is selected, put custom board drivers in a directory called \r
 # "Board" inside the application directory.\r
-BOARD = USBKEY\r
+BOARD = XPLAIN\r
 \r
 \r
 # Processor frequency.\r