Minor updates to the Benito programmer - remove redundant PORT register manipulations.

diff --git a/Projects/Benito/Benito.c b/Projects/Benito/Benito.c
index 712016b..720a224 100644 (file)
--- a/Projects/Benito/Benito.c
+++ b/Projects/Benito/Benito.c
@@ -105,10 +105,7 @@ int main(void)
                {\r
                        /* Check if the reset pulse period has elapsed, if so tristate the target reset line */\r
                        if (ResetPulseMSRemaining && !(--ResetPulseMSRemaining))\r
                {\r
                        /* Check if the reset pulse period has elapsed, if so tristate the target reset line */\r
                        if (ResetPulseMSRemaining && !(--ResetPulseMSRemaining))\r

-                       {\r
-                               AVR_RESET_LINE_PORT &= ~AVR_RESET_LINE_MASK;\r
-                               AVR_RESET_LINE_DDR  &= ~AVR_RESET_LINE_MASK;\r
-                       }\r
+                         AVR_RESET_LINE_DDR &= ~AVR_RESET_LINE_MASK;\r

 \r
                        /* Turn off TX LED(s) once the TX pulse period has elapsed */\r
                        if (TxPulseMSRemaining && !(--TxPulseMSRemaining))\r
 \r
                        /* Turn off TX LED(s) once the TX pulse period has elapsed */\r
                        if (TxPulseMSRemaining && !(--TxPulseMSRemaining))\r


@@ -212,7 +209,7 @@ void EVENT_CDC_Device_LineEncodingChanged(USB_ClassInfo_CDC_Device_t* const CDCI
                        break;\r
        }\r
        \r
                        break;\r
        }\r
        \r

-       UCSR1A = (1 << U2X1);   \r
+       UCSR1A = (1 << U2X1);\r

        UCSR1B = ((1 << TXEN1) | (1 << RXEN1));\r
        UCSR1C = ConfigMask;    \r
        UBRR1  = SERIAL_2X_UBBRVAL((uint16_t)CDCInterfaceInfo->State.LineEncoding.BaudRateBPS);\r
        UCSR1B = ((1 << TXEN1) | (1 << RXEN1));\r
        UCSR1C = ConfigMask;    \r
        UBRR1  = SERIAL_2X_UBBRVAL((uint16_t)CDCInterfaceInfo->State.LineEncoding.BaudRateBPS);\r


@@ -227,9 +224,7 @@ void EVENT_CDC_Device_ControLineStateChanged(USB_ClassInfo_CDC_Device_t* const C
        /* Check if the DTR line has been asserted - if so, start the target AVR's reset pulse */\r
        if (CDCInterfaceInfo->State.ControlLineStates.HostToDevice & CDC_CONTROL_LINE_OUT_DTR)\r
        {\r
        /* Check if the DTR line has been asserted - if so, start the target AVR's reset pulse */\r
        if (CDCInterfaceInfo->State.ControlLineStates.HostToDevice & CDC_CONTROL_LINE_OUT_DTR)\r
        {\r

-               AVR_RESET_LINE_DDR  |= AVR_RESET_LINE_MASK;\r
-               AVR_RESET_LINE_PORT &= ~AVR_RESET_LINE_MASK;\r
-\r
+               AVR_RESET_LINE_DDR |= AVR_RESET_LINE_MASK;\r

                ResetPulseMSRemaining = AVR_RESET_PULSE_MS;\r
        }\r
 }\r
                ResetPulseMSRemaining = AVR_RESET_PULSE_MS;\r
        }\r
 }\r

diff --git a/Projects/Benito/Benito.h b/Projects/Benito/Benito.h
index 2651c2d..5eefd7a 100644 (file)
--- a/Projects/Benito/Benito.h
+++ b/Projects/Benito/Benito.h
@@ -60,9 +60,13 @@
                /** LED mask for the library LED driver, to indicate that the USB interface is ready. */\r
                #define LEDMASK_USB_READY        LEDS_NO_LEDS\r
 \r
                /** LED mask for the library LED driver, to indicate that the USB interface is ready. */\r
                #define LEDMASK_USB_READY        LEDS_NO_LEDS\r
 \r

+               /** LED mask for the library LED driver, to indicate that an error has occurred in the USB interface. */\r

                #define LEDMASK_USB_ERROR        (LEDS_LED1 | LEDS_LED2)\r
                \r
                #define LEDMASK_USB_ERROR        (LEDS_LED1 | LEDS_LED2)\r
                \r

+               /** LED mask for the library LED driver, to indicate TX activity. */\r

                #define LEDMASK_TX               LEDS_LED1\r
                #define LEDMASK_TX               LEDS_LED1\r

+\r
+               /** LED mask for the library LED driver, to indicate RX activity. */\r

                #define LEDMASK_RX               LEDS_LED2\r
                \r
        /* Function Prototypes: */\r
                #define LEDMASK_RX               LEDS_LED2\r
                \r
        /* Function Prototypes: */\r