Merge branch 'saml_based_federated_single_sign_on' into saml_based_federated_single_s...
authormasensio <masensio@solidgear.es>
Tue, 27 Aug 2013 09:39:26 +0000 (11:39 +0200)
committermasensio <masensio@solidgear.es>
Tue, 27 Aug 2013 09:39:26 +0000 (11:39 +0200)
1  2 
src/com/owncloud/android/authentication/AuthenticatorActivity.java

@@@ -18,6 -18,8 +18,6 @@@
  \r
  package com.owncloud.android.authentication;\r
  \r
 -import java.net.URLDecoder;\r
 -\r
  import android.accounts.Account;\r
  import android.accounts.AccountManager;\r
  import android.app.AlertDialog;\r
@@@ -49,6 -51,7 +49,6 @@@ import android.widget.CheckBox
  import android.widget.EditText;\r
  import android.widget.TextView;\r
  import android.widget.TextView.OnEditorActionListener;\r
 -import android.widget.Toast;\r
  \r
  import com.actionbarsherlock.app.SherlockDialogFragment;\r
  import com.owncloud.android.Log_OC;\r
@@@ -86,8 -89,6 +86,8 @@@ implements  OnRemoteOperationListener, 
      public static final String EXTRA_ACTION = "ACTION";\r
      public static final String EXTRA_ENFORCED_UPDATE = "ENFORCE_UPDATE";\r
  \r
 +    private static final String KEY_AUTH_MESSAGE_VISIBILITY = "AUTH_MESSAGE_VISIBILITY";\r
 +    private static final String KEY_AUTH_MESSAGE_TEXT = "AUTH_MESSAGE_TEXT";\r
      private static final String KEY_HOST_URL_TEXT = "HOST_URL_TEXT";\r
      private static final String KEY_OC_VERSION = "OC_VERSION";\r
      private static final String KEY_ACCOUNT = "ACCOUNT";\r
      private String mHostBaseUrl;\r
      private OwnCloudVersion mDiscoveredVersion;\r
  \r
 -    private int mServerStatusText, mServerStatusIcon;\r
 +    private String mAuthMessageText;\r
 +    private int mAuthMessageVisibility, mServerStatusText, mServerStatusIcon;\r
      private boolean mServerIsChecked, mServerIsValid, mIsSslConn;\r
      private int mAuthStatusText, mAuthStatusIcon;    \r
      private TextView mAuthStatusLayout;\r
      private byte mAction;\r
      private Account mAccount;\r
  \r
 +    private TextView mAuthMessage;\r
 +    \r
      private EditText mHostUrlInput;\r
      private boolean mHostUrlInputEnabled;\r
      private View mRefreshButton;\r
  \r
          /// set view and get references to view elements\r
          setContentView(R.layout.account_setup);\r
 +        mAuthMessage = (TextView) findViewById(R.id.auth_message);\r
          mHostUrlInput = (EditText) findViewById(R.id.hostUrlInput);\r
          mHostUrlInput.setText(getString(R.string.server_url));  // valid although R.string.server_url is an empty string\r
          mUsernameInput = (EditText) findViewById(R.id.account_username);\r
  \r
          if (savedInstanceState == null) {\r
              /// connection state and info\r
 +            mAuthMessageVisibility = View.GONE;\r
              mServerStatusText = mServerStatusIcon = 0;\r
              mServerIsValid = false;\r
              mServerIsChecked = false;\r
                  }\r
                  mHostBaseUrl = normalizeUrl(mAccountMgr.getUserData(mAccount, AccountAuthenticator.KEY_OC_BASE_URL));\r
                  mHostUrlInput.setText(mHostBaseUrl);\r
 +                String userName = mAccount.name.substring(0, mAccount.name.lastIndexOf('@'));\r
 +                mUsernameInput.setText(userName);\r
              }\r
              initAuthorizationMethod();  // checks intent and setup.xml to determine mCurrentAuthorizationMethod\r
              mJustCreated = true;\r
              \r
          } else {\r
              /// connection state and info\r
 +            mAuthMessageVisibility = savedInstanceState.getInt(KEY_AUTH_MESSAGE_VISIBILITY);\r
 +            mAuthMessageText = savedInstanceState.getString(KEY_AUTH_MESSAGE_TEXT);\r
              mServerIsValid = savedInstanceState.getBoolean(KEY_SERVER_VALID);\r
              mServerIsChecked = savedInstanceState.getBoolean(KEY_SERVER_CHECKED);\r
              mServerStatusText = savedInstanceState.getInt(KEY_SERVER_STATUS_TEXT);\r
  \r
          }\r
  \r
 +        if (mAuthMessageVisibility== View.VISIBLE) {\r
 +            showAuthMessage(mAuthMessageText);\r
 +        }\r
 +        else {\r
 +            hideAuthMessage();\r
 +        }\r
          adaptViewAccordingToAuthenticationMethod();\r
          showServerStatus();\r
          showAuthStatus();\r
              public void beforeTextChanged(CharSequence s, int start, int count, int after) {}\r
  \r
              @Override\r
-             public void onTextChanged(CharSequence s, int start, int before, int count) {}\r
+             public void onTextChanged(CharSequence s, int start, int before, int count) {\r
+                     mAuthStatusIcon = 0;\r
+                     mAuthStatusText = 0;\r
+                     showAuthStatus();\r
+             }\r
  \r
          });\r
          mPasswordInput.setOnFocusChangeListener(this);\r
          super.onSaveInstanceState(outState);\r
  \r
          /// connection state and info\r
 +        outState.putInt(KEY_AUTH_MESSAGE_VISIBILITY, mAuthMessage.getVisibility());\r
 +        outState.putString(KEY_AUTH_MESSAGE_TEXT, mAuthMessage.getText().toString());\r
          outState.putInt(KEY_SERVER_STATUS_TEXT, mServerStatusText);\r
          outState.putInt(KEY_SERVER_STATUS_ICON, mServerStatusIcon);\r
          outState.putBoolean(KEY_SERVER_VALID, mServerIsValid);\r
      protected void onResume() {\r
          super.onResume();\r
          if (mAction == ACTION_UPDATE_TOKEN && mJustCreated && getIntent().getBooleanExtra(EXTRA_ENFORCED_UPDATE, false)) {\r
 -            if (mOAuth2Check.isChecked())\r
 -                Toast.makeText(this, R.string.auth_expired_oauth_token_toast, Toast.LENGTH_LONG).show();\r
 -            else\r
 -                Toast.makeText(this, R.string.auth_expired_basic_auth_toast, Toast.LENGTH_LONG).show();\r
 +            if (AccountAuthenticator.AUTH_TOKEN_TYPE_ACCESS_TOKEN.equals(mAuthTokenType)) {\r
 +                //Toast.makeText(this, R.string.auth_expired_oauth_token_toast, Toast.LENGTH_LONG).show();\r
 +                showAuthMessage(getString(R.string.auth_expired_oauth_token_toast));\r
 +            } else if (AccountAuthenticator.AUTH_TOKEN_TYPE_SAML_WEB_SSO_SESSION_COOKIE.equals(mAuthTokenType)) {\r
 +                //Toast.makeText(this, R.string.auth_expired_saml_sso_token_toast, Toast.LENGTH_LONG).show();\r
 +                showAuthMessage(getString(R.string.auth_expired_saml_sso_token_toast));\r
 +            } else {\r
 +                //Toast.makeText(this, R.string.auth_expired_basic_auth_toast, Toast.LENGTH_LONG).show();\r
 +                showAuthMessage(getString(R.string.auth_expired_basic_auth_toast));\r
 +            }\r
          }\r
  \r
          if (mNewCapturedUriFromOAuth2Redirection != null) {\r
              // NOTHING TO DO ; can't find out what situation that leads to the exception in this code, but user logs signal that it happens\r
          }\r
          \r
 -        if (result.isTemporalRedirection() || result.isIdPRedirection()) {\r
 +        if (result.isTemporalRedirection() && result.isIdPRedirection()) {\r
              String url = result.getRedirectedLocation();\r
              String targetUrl = mHostBaseUrl + AccountUtils.getWebdavPath(mDiscoveredVersion, mAuthTokenType);\r
              \r
          case ACCOUNT_NOT_NEW:\r
              mAuthStatusText = R.string.auth_account_not_new;\r
              break;\r
 +        case ACCOUNT_NOT_THE_SAME:\r
 +            mAuthStatusText = R.string.auth_account_not_the_same;\r
 +            break;\r
          case UNHANDLED_HTTP_CODE:\r
          case UNKNOWN_ERROR:\r
              mAuthStatusText = R.string.auth_unknown_error_title;\r
          if (result.isSuccess()) {\r
              Log_OC.d(TAG, "Successful access - time to save the account");\r
  \r
 -            boolean success = true;\r
 +            boolean success = false;\r
              if (mAction == ACTION_CREATE) {\r
                  success = createAccount();\r
  \r
              } else {\r
 -                updateToken();\r
 +                success = updateToken();\r
              }\r
  \r
              if (success) {\r
       * Sets the proper response to get that the Account Authenticator that started this activity saves \r
       * a new authorization token for mAccount.\r
       */\r
 -    private void updateToken() {\r
 +    private boolean updateToken() {\r
          Bundle response = new Bundle();\r
          response.putString(AccountManager.KEY_ACCOUNT_NAME, mAccount.name);\r
          response.putString(AccountManager.KEY_ACCOUNT_TYPE, mAccount.type);\r
              mAccountMgr.setAuthToken(mAccount, mAuthTokenType, mAuthToken);\r
              \r
          } else if (AccountAuthenticator.AUTH_TOKEN_TYPE_SAML_WEB_SSO_SESSION_COOKIE.equals(mAuthTokenType)) {\r
 +            String username = getUserNameForSamlSso();\r
 +            if (!mUsernameInput.getText().toString().equals(username)) {\r
 +                // fail - not a new account, but an existing one; disallow\r
 +                RemoteOperationResult result = new RemoteOperationResult(ResultCode.ACCOUNT_NOT_THE_SAME); \r
 +                updateAuthStatusIconAndText(result);\r
 +                showAuthStatus();\r
 +                Log_OC.d(TAG, result.getLogMessage());\r
 +                \r
 +                return false;\r
 +            }\r
 +            \r
              response.putString(AccountManager.KEY_AUTHTOKEN, mAuthToken);\r
              // the next line is necessary; by now, notifications are calling directly to the AuthenticatorActivity to update, without AccountManager intervention\r
              mAccountMgr.setAuthToken(mAccount, mAuthTokenType, mAuthToken);\r
              mAccountMgr.setPassword(mAccount, mPasswordInput.getText().toString());\r
          }\r
          setAccountAuthenticatorResult(response);\r
 +        \r
 +        return true;\r
      }\r
  \r
  \r
              Log_OC.d(TAG, result.getLogMessage());\r
              return false;\r
              \r
 -            \r
          } else {\r
          \r
              if (isOAuth || isSaml) {\r
              Bundle bundle = new Bundle();\r
              bundle.putBoolean(ContentResolver.SYNC_EXTRAS_MANUAL, true);\r
              ContentResolver.requestSync(mAccount, AccountAuthenticator.AUTHORITY, bundle);\r
 +            syncAccount();\r
 +//          Bundle bundle = new Bundle();\r
 +//          bundle.putBoolean(ContentResolver.SYNC_EXTRAS_MANUAL, true);\r
 +//          ContentResolver.requestSync(mAccount, AccountAuthenticator.AUTHORITY, bundle);\r
              return true;\r
          }\r
      }\r
          \r
          if (sessionCookie != null && sessionCookie.length() > 0) {\r
              mAuthToken = sessionCookie;\r
 -            boolean success = true;\r
 +            boolean success = false;\r
              if (mAction == ACTION_CREATE) {\r
                  success = createAccount();\r
          \r
              } else {\r
 -                updateToken();\r
 +                success = updateToken();\r
              }\r
              if (success) {\r
                  finish();\r
      \r
      }\r
      \r
 +    /** Show auth_message \r
 +     * \r
 +     * @param message\r
 +     */\r
 +    private void showAuthMessage(String message) {\r
 +       mAuthMessage.setVisibility(View.VISIBLE);\r
 +       mAuthMessage.setText(message);\r
 +    }\r
 +    \r
 +    private void hideAuthMessage() {\r
 +        mAuthMessage.setVisibility(View.GONE);\r
 +    }\r
  \r
      private void syncAccount(){\r
          /// immediately request for the synchronization of the new account\r