Much faster attribute range lookup - look through short list of attributes and compar...
[pub/lufa.git] / Demos / Host / Incomplete / BluetoothHost / Lib / ServiceDiscoveryProtocol.c
index cb858d6..3731e1f 100644 (file)
 #define  INCLUDE_FROM_SERVICEDISCOVERYPROTOCOL_C
 #include "ServiceDiscoveryProtocol.h"
 
-/** Service Discovery Protocol attribute, indicationg the service's name. */
-const struct
-{
-       uint8_t Header;
-       uint8_t Length;
-       uint8_t Data[];
-} PROGMEM SDP_Attribute_Name = {(SDP_DATATYPE_String | SDP_DATASIZE_Variable8Bit), sizeof("SDP"), "SDP"};
-
-/** Service Discovery Protocol attribute, indicationg the service's description. */
-const struct
-{
-       uint8_t Header;
-       uint8_t Length;
-       uint8_t Data[];
-} PROGMEM SDP_Attribute_Description = {(SDP_DATATYPE_String | SDP_DATASIZE_Variable8Bit), sizeof("BT Service Discovery"), "BT Service Discovery"};
-
-/** Service Discovery Protocol attribute, indicationg the service's availability. */
-const struct
-{
-       uint8_t Header;
-       uint8_t Data;
-} PROGMEM SDP_Attribute_Availability = {(SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_8Bit), 0xFF};
-
-const struct
-{
-       uint8_t  Header;
-       uint16_t Data;
-} PROGMEM SDP_Attribute_LanguageOffset = {(SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_16Bit), SDP_ATTRIBUTE_LANGOFFSET};
-
-const struct
-{
-       uint8_t  Header;
-       uint32_t Data;
-} PROGMEM SDP_Attribute_ServiceHandle = {(SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_32Bit), 0x00000001};
-
-const struct
-{
-       uint8_t   Header;
-       uint8_t   Size;
-       Version_t VersionList[];
-} PROGMEM SDP_Attribute_Version =
-       {
-               .Header = (SDP_DATATYPE_Sequence | SDP_DATASIZE_Variable8Bit),
-               .Size   = (sizeof(Version_t) * 1),
-               .VersionList =
-                       {
-                               {.Header = (SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_16Bit), .Version = 0x0100}
-                       }
-       };
-
-const struct
-{
-       uint8_t     Header;
-       uint16_t    Size;
-       ClassUUID_t UUIDList[];
-} PROGMEM SDP_Attribute_ServiceClassIDs =
-       {
-               .Header = (SDP_DATATYPE_Sequence | SDP_DATASIZE_Variable16Bit),
-               .Size   = (sizeof(ClassUUID_t) * 1),
-               .UUIDList =
-                       {
-                               {.Header = (SDP_DATATYPE_UUID | SDP_DATASIZE_128Bit), .UUID = {BASE_96BIT_UUID, 0x01, 0x00, 0x00, 0x00}}
-                       }
-       };
-
-/** Service Discovery Protocol attribute table, listing all supported attributes of the service. */
-const ServiceAttributeTable_t SDP_Attribute_Table[] PROGMEM =
-       {
-               {.AttributeID = SDP_ATTRIBUTE_ID_SERVICERECORDHANDLE, .Data = &SDP_Attribute_ServiceHandle    },
-               {.AttributeID = SDP_ATTRIBUTE_ID_SERVICECLASSIDS,     .Data = &SDP_Attribute_ServiceClassIDs  },
-               {.AttributeID = SDP_ATTRIBUTE_ID_VERSION,             .Data = &SDP_Attribute_Version          },
-               {.AttributeID = SDP_ATTRIBUTE_ID_LANGIDOFFSET,        .Data = &SDP_Attribute_LanguageOffset   },
-               {.AttributeID = SDP_ATTRIBUTE_ID_NAME,                .Data = &SDP_Attribute_Name             },
-               {.AttributeID = SDP_ATTRIBUTE_ID_DESCRIPTION,         .Data = &SDP_Attribute_Description      },
-
-               SERVICE_ATTRIBUTE_TABLE_TERMINATOR
-       };
+/** Base UUID value common to all standardized Bluetooth services */
+const UUID_t BaseUUID PROGMEM = {SWAPENDIAN_32(0xFB349B5F), SWAPENDIAN_16(0x8000), SWAPENDIAN_16(0x0080), SWAPENDIAN_16(0x0010)};
 
 /** Master service table, listing all supported services (and their attribute tables) of the device, including
  *  each service's UUID.
@@ -115,20 +40,15 @@ const ServiceAttributeTable_t SDP_Attribute_Table[] PROGMEM =
 const ServiceTable_t SDP_Services_Table[] PROGMEM =
        {
                {   // 128-bit UUID for the SDP service
-                       .UUID  = {BASE_96BIT_UUID, 0x00, 0x00, 0x00, 0x01},
+                       .UUID  = {BASE_80BIT_UUID, {0x00, 0x00, 0x00, 0x00, 0x00, 0x01}},
                        .AttributeTable = SDP_Attribute_Table,
                },
-#if 0
                {   // 128-bit UUID for the RFCOMM service
-                       .UUID  = {BASE_96BIT_UUID, 0x03, 0x00, 0x00, 0x00},
+                       .UUID  = {BASE_80BIT_UUID, {0x00, 0x00, 0x00, 0x00, 0x00, 0x03}},
                        .AttributeTable = RFCOMM_Attribute_Table,
                },
-#endif
        };
 
-/** Base UUID value common to all standardized Bluetooth services */
-const uint8_t BaseUUID[] PROGMEM = {BASE_96BIT_UUID, 0x00, 0x00, 0x00, 0x00};
-
 
 /** Main Service Discovery Protocol packet processing routine. This function processes incomming SDP packets from
  *  a connected Bluetooth device, and sends back appropriate responses to allow other devices to determine the
@@ -167,7 +87,79 @@ void SDP_ProcessPacket(void* Data, Bluetooth_Channel_t* Channel)
  */
 static void SDP_ProcessServiceSearch(const SDP_PDUHeader_t* const SDPHeader, Bluetooth_Channel_t* const Channel)
 {
+       const void* CurrentParameter = ((void*)SDPHeader + sizeof(SDP_PDUHeader_t));
+
        BT_SDP_DEBUG(1, "<< Service Search");
+
+       /* Retrieve the list of search UUIDs from the request */
+       uint8_t UUIDList[12][UUID_SIZE_BYTES];
+       uint8_t TotalUUIDs = SDP_GetUUIDList(UUIDList, &CurrentParameter);
+       BT_SDP_DEBUG(2, "-- Total UUIDs: %d", TotalUUIDs);
+       
+       /* Retrieve the maximum service record reponse count from the request */
+       uint16_t MaxServiceRecordCount = SDP_ReadData16(&CurrentParameter);
+       BT_SDP_DEBUG(2, "-- Max Return Service Count: 0x%04X", MaxServiceRecordCount);
+       
+       struct
+       {
+               SDP_PDUHeader_t SDPHeader;
+               uint16_t        TotalServiceRecordCount;
+               uint16_t        CurrentServiceRecordCount;
+               uint8_t         ResponseData[100];
+       } ResponsePacket;
+
+       /* Create a pointer to the buffer to indicate the current location for response data to be added */
+       void* CurrResponsePos = ResponsePacket.ResponseData;
+       
+       uint8_t AddedServiceHandles = 0;
+
+       /* Search through the list of UUIDs one at a time looking for matching search Attributes */
+       for (uint8_t CurrUUIDItem = 0; CurrUUIDItem < TotalUUIDs; CurrUUIDItem++)
+       {
+               ServiceAttributeTable_t* AttributeTable;
+
+               /* Retrieve the attribute table of the current search UUID from the global UUID table if it exists */
+               if ((AttributeTable = SDP_GetAttributeTable(UUIDList[CurrUUIDItem])) == NULL)
+                 continue;
+                 
+               BT_SDP_DEBUG(2, " -- Found UUID %d in table", CurrUUIDItem);
+
+               /* Retrieve a PROGMEM pointer to the value of the service's record handle */
+               const void* AttributeValue = SDP_GetAttributeValue(AttributeTable, SDP_ATTRIBUTE_ID_SERVICERECORDHANDLE);
+
+               /* Copy over the service record handle to the response list */
+               uint8_t AttrHeaderSize;
+               SDP_GetLocalAttributeContainerSize(AttributeValue, &AttrHeaderSize);
+               memcpy_P(CurrResponsePos, AttributeValue + AttrHeaderSize, sizeof(uint32_t));
+               CurrResponsePos += AttrHeaderSize + sizeof(uint32_t);
+               
+               /* Increment the total number of service records added to the list */
+               AddedServiceHandles++;
+       }
+
+       /* Continuation state - always zero */
+       SDP_WriteData8(&CurrResponsePos, 0);
+
+       /* Fill out the service record count values in the returned packet */
+       ResponsePacket.TotalServiceRecordCount   = SwapEndian_16(AddedServiceHandles);
+       ResponsePacket.CurrentServiceRecordCount = ResponsePacket.TotalServiceRecordCount;
+
+       /* Calculate the total parameter length that is to be sent, including the fixed return parameters, the created service
+          handle list and the SDP continuation state */
+       uint16_t ParamLength = (ResponsePacket.CurrentServiceRecordCount << 2) +
+                               sizeof(ResponsePacket.CurrentServiceRecordCount) +
+                               sizeof(ResponsePacket.TotalServiceRecordCount) +
+                               sizeof(uint8_t);
+
+       /* Fill in the response packet's header */
+       ResponsePacket.SDPHeader.PDU             = SDP_PDU_SERVICESEARCHRESPONSE;
+       ResponsePacket.SDPHeader.TransactionID   = SDPHeader->TransactionID;
+       ResponsePacket.SDPHeader.ParameterLength = SwapEndian_16(ParamLength);
+
+       BT_SDP_DEBUG(1, ">> Service Search Response");
+
+       /* Send the completed response packet to the sender */
+       Bluetooth_SendPacket(&ResponsePacket, (sizeof(ResponsePacket.SDPHeader) + ParamLength), Channel);
 }
 
 /** Internal processing routine for SDP Service Attribute Requests.
@@ -177,7 +169,92 @@ static void SDP_ProcessServiceSearch(const SDP_PDUHeader_t* const SDPHeader, Blu
  */
 static void SDP_ProcessServiceAttribute(const SDP_PDUHeader_t* const SDPHeader, Bluetooth_Channel_t* const Channel)
 {
+       const void* CurrentParameter = ((void*)SDPHeader + sizeof(SDP_PDUHeader_t));
+
        BT_SDP_DEBUG(1, "<< Service Attribute");
+
+       /* Retrieve the service handle whose attributes are to be examined */
+       uint32_t ServiceHandle = SDP_ReadData32(&CurrentParameter);
+       BT_SDP_DEBUG(2, "-- Service Handle: 0x%08lX", ServiceHandle);
+       
+       /* Retrieve the maximum Attribute reponse size from the request */
+       uint16_t MaxAttributeSize = SDP_ReadData16(&CurrentParameter);
+       BT_SDP_DEBUG(2, "-- Max Return Attribute Bytes: 0x%04X", MaxAttributeSize);
+       
+       /* Retrieve the list of Attributes from the request */
+       uint16_t AttributeList[15][2];
+       uint8_t  TotalAttributes = SDP_GetAttributeList(AttributeList, &CurrentParameter);
+       BT_SDP_DEBUG(2, "-- Total Attributes: %d", TotalAttributes);
+
+       struct
+       {
+               SDP_PDUHeader_t SDPHeader;
+               uint16_t        AttributeListByteCount;
+               uint8_t         ResponseData[100];
+       } ResponsePacket;
+
+       /* Create a pointer to the buffer to indicate the current location for response data to be added */
+       void* CurrResponsePos = ResponsePacket.ResponseData;
+
+       /* Clamp the maximum attribute size to the size of the allocated buffer */
+       if (MaxAttributeSize > sizeof(ResponsePacket.ResponseData))
+         MaxAttributeSize = sizeof(ResponsePacket.ResponseData);
+
+       /* Add the outer Data Element Sequence header for all of the retrieved Attributes */
+       uint16_t* TotalResponseSize = SDP_AddDataElementHeader16(&CurrResponsePos, SDP_DATATYPE_Sequence);
+
+       /* Search through the global UUID list an item at a time */
+       for (uint8_t CurrTableItem = 0; CurrTableItem < (sizeof(SDP_Services_Table) / sizeof(ServiceTable_t)); CurrTableItem++)
+       {
+               /* Read in a pointer to the current UUID table entry's Attribute table */
+               ServiceAttributeTable_t* CurrAttributeTable = (ServiceAttributeTable_t*)pgm_read_word(&SDP_Services_Table[CurrTableItem].AttributeTable);
+               
+               /* Retrieve a PROGMEM pointer to the value of the Service Record Handle */
+               const void* ServiceRecord = SDP_GetAttributeValue(CurrAttributeTable, SDP_ATTRIBUTE_ID_SERVICERECORDHANDLE);
+               
+               /* Get the size of the header for the Service Record Handle */
+               uint8_t AttrHeaderSize;
+               SDP_GetLocalAttributeContainerSize(ServiceRecord, &AttrHeaderSize);
+               
+               /* Retrieve the endian-swapped service handle of the current service being examined */
+               uint32_t CurrServiceHandle = SwapEndian_32(pgm_read_dword(ServiceRecord + AttrHeaderSize));
+               
+               /* Check if the current service in the service table has the requested service handle */
+               if (ServiceHandle == CurrServiceHandle)
+               {
+                       *TotalResponseSize += SDP_AddListedAttributesToResponse(CurrAttributeTable, AttributeList, TotalAttributes,
+                                                                           &CurrResponsePos);
+                       
+                       /* Requested service found, abort the search through the service table */
+                       break;
+               }
+       }
+
+       /* Continuation state - always zero */
+       SDP_WriteData8(&CurrResponsePos, 0);
+
+       /* Set the total response list size to the size of the outer container plus its header size and continuation state */
+       ResponsePacket.AttributeListByteCount    = SwapEndian_16(3 + *TotalResponseSize);
+
+       /* Calculate the total parameter length that is to be sent, including the fixed return parameters, the created attribute
+          value list and the SDP continuation state */
+       uint16_t ParamLength = (sizeof(ResponsePacket.AttributeListByteCount) + 
+                               (3 + *TotalResponseSize) +
+                               sizeof(uint8_t));
+
+       /* Fill in the response packet's header */
+       ResponsePacket.SDPHeader.PDU             = SDP_PDU_SERVICEATTRIBUTERESPONSE;
+       ResponsePacket.SDPHeader.TransactionID   = SDPHeader->TransactionID;
+       ResponsePacket.SDPHeader.ParameterLength = SwapEndian_16(ParamLength);
+
+       /* Flip the endianness of the container's size */
+       *TotalResponseSize = SwapEndian_16(*TotalResponseSize);
+
+       BT_SDP_DEBUG(1, ">> Service Attribute Response");
+       BT_SDP_DEBUG(2, "-- Param Len 0x%04X", ParamLength);
+
+       /* Send the completed response packet to the sender */
+       Bluetooth_SendPacket(&ResponsePacket, (sizeof(ResponsePacket.SDPHeader) + ParamLength), Channel);
 }
 
 /** Internal processing routine for SDP Service Search Attribute Requests.
@@ -197,8 +274,7 @@ static void SDP_ProcessServiceSearchAttribute(const SDP_PDUHeader_t* const SDPHe
        BT_SDP_DEBUG(2, "-- Total UUIDs: %d", TotalUUIDs);
        
        /* Retrieve the maximum Attribute reponse size from the request */
-       uint16_t MaxAttributeSize = *((uint16_t*)CurrentParameter);
-       CurrentParameter += sizeof(uint16_t);
+       uint16_t MaxAttributeSize = SDP_ReadData16(&CurrentParameter);
        BT_SDP_DEBUG(2, "-- Max Return Attribute Bytes: 0x%04X", MaxAttributeSize);
        
        /* Retrieve the list of Attributes from the request */
@@ -220,64 +296,101 @@ static void SDP_ProcessServiceSearchAttribute(const SDP_PDUHeader_t* const SDPHe
        if (MaxAttributeSize > sizeof(ResponsePacket.ResponseData))
          MaxAttributeSize = sizeof(ResponsePacket.ResponseData);
 
-       /* Add the outer Data Element Sequence header for the retrieved Attributes */
+       /* Add the outer Data Element Sequence header for all of the retrieved Attributes */
        uint16_t* TotalResponseSize = SDP_AddDataElementHeader16(&CurrResponsePos, SDP_DATATYPE_Sequence);
        
        /* Search through the list of UUIDs one at a time looking for matching search Attributes */
        for (uint8_t CurrUUIDItem = 0; CurrUUIDItem < TotalUUIDs; CurrUUIDItem++)
        {
+               ServiceAttributeTable_t* AttributeTable;
+
                /* Retrieve the attribute table of the current search UUID from the global UUID table if it exists */
-               ServiceAttributeTable_t* AttributeTable = SDP_GetAttributeTable(UUIDList[CurrUUIDItem]);
-               
-               /* If the UUID does not exist in the global UUID table, continue on to the next search UUID */
-               if (AttributeTable == NULL)
+               if ((AttributeTable = SDP_GetAttributeTable(UUIDList[CurrUUIDItem])) == NULL)
                  continue;
                  
                BT_SDP_DEBUG(2, " -- Found UUID %d in table", CurrUUIDItem);
 
-               /* Add an inner Data Element Sequence header for the current UUID's found Attributes */
-               uint16_t* CurrentUUIDResponseSize = SDP_AddDataElementHeader16(&CurrResponsePos, SDP_DATATYPE_Sequence);
+               /* Add the listed attributes for the found UUID to the response */
+               *TotalResponseSize += SDP_AddListedAttributesToResponse(AttributeTable, AttributeList, TotalAttributes,
+                                                                       &CurrResponsePos);
+       }
+       
+       /* Continuation state - always zero */
+       SDP_WriteData8(&CurrResponsePos, 0);
+
+       /* Set the total response list size to the size of the outer container plus its header size and continuation state */
+       ResponsePacket.AttributeListByteCount    = SwapEndian_16(3 + *TotalResponseSize);
+
+       /* Calculate the total parameter length that is to be sent, including the fixed return parameters, the created attribute
+          value list and the SDP continuation state */
+       uint16_t ParamLength = (sizeof(ResponsePacket.AttributeListByteCount) + 
+                               (3 + *TotalResponseSize) +
+                               sizeof(uint8_t));
+
+       /* Fill in the response packet's header */
+       ResponsePacket.SDPHeader.PDU             = SDP_PDU_SERVICESEARCHATTRIBUTERESPONSE;
+       ResponsePacket.SDPHeader.TransactionID   = SDPHeader->TransactionID;
+       ResponsePacket.SDPHeader.ParameterLength = SwapEndian_16(ParamLength);
+
+       /* Flip the endianness of the container's size */
+       *TotalResponseSize = SwapEndian_16(*TotalResponseSize);
+
+       BT_SDP_DEBUG(1, ">> Service Search Attribute Response");
+       BT_SDP_DEBUG(2, "-- Param Len 0x%04X", ParamLength);
+
+       /* Send the completed response packet to the sender */
+       Bluetooth_SendPacket(&ResponsePacket, (sizeof(ResponsePacket.SDPHeader) + ParamLength), Channel);
+}
+
+/** Adds all the Attributes in the given service table to the response that appear in the Attribute table.
+ *
+ *  \param[in]  AttributeTable   Pointer to an Attribute table for the service to examine
+ *  \param[in]  AttributeList    Pointer to a list of Attribute ranges
+ *  \param[in]  TotalAttributes  Number of Attributes stored in the Attribute list
+ *  \param[out] BufferPos       Pointer to the output buffer position where the retrieved attributes are to be stored
+ *
+ *  \return Number of bytes added to the output buffer
+ */
+static uint16_t SDP_AddListedAttributesToResponse(const ServiceAttributeTable_t* AttributeTable,
+                                                  uint16_t AttributeList[][2], uint8_t TotalAttributes, void** BufferPos)
+{
+       uint16_t TotalResponseSize = 0;
+
+       /* Add an inner Data Element Sequence header for the current services's found Attributes */
+       uint16_t* AttributeListSize = SDP_AddDataElementHeader16(BufferPos, SDP_DATATYPE_Sequence);
+
+       /* Search through the list of Attributes one at a time looking for values in the current UUID's Attribute table */
+       for (uint8_t CurrAttribute = 0; CurrAttribute < TotalAttributes; CurrAttribute++)
+       {
+               uint16_t* AttributeIDRange = AttributeList[CurrAttribute];
+               void*     AttributeValue;
                
-               /* Search through the list of Attributes one at a time looking for values in the current UUID's Attribute table */
-               for (uint8_t CurrAttribute = 0; CurrAttribute < TotalAttributes; CurrAttribute++)
+               /* Look through the current service's attribute list, examining all the attributes */
+               while ((AttributeValue = (void*)pgm_read_word(&AttributeTable->Data)) != NULL)
                {
-                       uint16_t* AttributeIDRange = AttributeList[CurrAttribute];
-               
-                       /* Look in the current Attribute Range for a matching Attribute ID in the UUID's Attribute table */
-                       for (uint32_t CurrAttributeID = AttributeIDRange[0]; CurrAttributeID <= AttributeIDRange[1]; CurrAttributeID++)
+                       /* Get the current Attribute's ID from the current attribute table entry */
+                       uint16_t CurrAttributeID = pgm_read_word(&AttributeTable->AttributeID);
+
+                       /* Check if the current Attribute's ID is within the current Attribute range */
+                       if ((CurrAttributeID >= AttributeIDRange[0]) && (CurrAttributeID <= AttributeIDRange[1]))
                        {
-                               /* Retrieve a PROGMEM pointer to the value of the current Attribute ID, if it exists in the UUID's Attribute table */
-                               const void* AttributeValue = SDP_GetAttributeValue(AttributeTable, CurrAttributeID);
-                               
-                               /* If the Attribute does not exist in the current UUID's Attribute table, continue to the next Attribute ID */
-                               if (AttributeValue == NULL)
-                                 continue;
-                               
                                BT_SDP_DEBUG(2, " -- Add Attribute 0x%04X", CurrAttributeID);
 
                                /* Increment the current UUID's returned Attribute container size by the number of added bytes */
-                               *CurrentUUIDResponseSize += SDP_AddAttributeToResponse(CurrAttributeID, AttributeValue, &CurrResponsePos);
+                               *AttributeListSize += SDP_AddAttributeToResponse(CurrAttributeID, AttributeValue, BufferPos);                   
                        }
-
-                       /* Increment the outer container size by the number of added bytes */
-                       *TotalResponseSize += 3 + *CurrentUUIDResponseSize;
+                       
+                       AttributeTable++;
                }
-       }
 
-       /* Set the total response list size to the size of the outer container plus its header size */
-       ResponsePacket.AttributeListByteCount    = 3 + *TotalResponseSize;
-
-       /* Fill in the response packet's header */
-       ResponsePacket.SDPHeader.PDU             = SDP_PDU_SERVICESEARCHATTRIBUTERESPONSE;
-       ResponsePacket.SDPHeader.TransactionID   = SDPHeader->TransactionID;
-       ResponsePacket.SDPHeader.ParameterLength = (ResponsePacket.AttributeListByteCount + sizeof(ResponsePacket.AttributeListByteCount));
+               /* Increment the outer container size by the number of added bytes */
+               TotalResponseSize += 3 + *AttributeListSize;
+       }
 
-       BT_SDP_DEBUG(1, ">> Service Search Attribute Response");
-       BT_SDP_DEBUG(2, "-- Total Parameter Length: 0x%04X", ResponsePacket.SDPHeader.ParameterLength);
+       /* Fix endianness of the added attribute data element sequence */
+       *AttributeListSize = SwapEndian_16(*AttributeListSize);
 
-       /* Send the completed response packet to the sender */
-       Bluetooth_SendPacket(&ResponsePacket, (sizeof(ResponsePacket.SDPHeader) + ResponsePacket.SDPHeader.ParameterLength),
-                            Channel);
+       return TotalResponseSize;
 }
 
 /** Adds the given attribute ID and value to the reponse buffer, and advances the response buffer pointer past the added data.
@@ -293,14 +406,12 @@ static uint16_t SDP_AddAttributeToResponse(const uint16_t AttributeID, const voi
        /* Retrieve the size of the attribute value from its container header */
        uint8_t  AttributeHeaderLength;
        uint32_t AttributeValueLength = SDP_GetLocalAttributeContainerSize(AttributeValue, &AttributeHeaderLength);
-
+       
        /* Add a Data Element header to the response for the Attribute ID */
-       *((uint8_t*)*ResponseBuffer) = (SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_16Bit);
-       *ResponseBuffer += sizeof(uint8_t);
+       SDP_WriteData8(ResponseBuffer, (SDP_DATATYPE_UnsignedInt | SDP_DATASIZE_16Bit));
        
        /* Add the Attribute ID to the created Data Element */
-       *((uint16_t*)*ResponseBuffer) = AttributeID;
-       *ResponseBuffer += sizeof(uint16_t);
+       SDP_WriteData16(ResponseBuffer, AttributeID);
        
        /* Copy over the Attribute value Data Element container to the response */
        memcpy_P(*ResponseBuffer, AttributeValue, AttributeHeaderLength + AttributeValueLength);
@@ -348,7 +459,7 @@ static ServiceAttributeTable_t* SDP_GetAttributeTable(const uint8_t* const UUID)
                ServiceAttributeTable_t* CurrAttributeTable = (ServiceAttributeTable_t*)pgm_read_word(&SDP_Services_Table[CurrTableItem].AttributeTable);
        
                /* If the current table item's UUID matches the search UUID, return a pointer the table item's Attribute table */
-               if (!(memcmp_P(UUID, SDP_Services_Table[CurrTableItem].UUID, UUID_SIZE_BYTES)))
+               if (!(memcmp_P(UUID, &SDP_Services_Table[CurrTableItem].UUID, UUID_SIZE_BYTES)))
                  return CurrAttributeTable;
                
                /* Retrieve the list of the service's Class UUIDs from its Attribute table */
@@ -367,11 +478,11 @@ static ServiceAttributeTable_t* SDP_GetAttributeTable(const uint8_t* const UUID)
                while (ClassUUIDListSize)
                {
                        /* Current Service UUID's Class UUID list has a matching entry, return the Attribute table */
-                       if (!(memcmp_P(UUID, (ClassUUIDs + 1), UUID_SIZE_BYTES)))
+                       if (!(memcmp_P(UUID, &((ItemUUID_t*)ClassUUIDs)->UUID, UUID_SIZE_BYTES)))
                          return CurrAttributeTable;
                
-                       ClassUUIDs        += sizeof(uint8_t) + UUID_SIZE_BYTES;
-                       ClassUUIDListSize -= sizeof(uint8_t) + UUID_SIZE_BYTES;
+                       ClassUUIDListSize -= sizeof(ItemUUID_t);
+                       ClassUUIDs        += sizeof(ItemUUID_t);
                }       
        }
        
@@ -405,7 +516,11 @@ static uint8_t SDP_GetAttributeList(uint16_t AttributeList[][2], const void** co
                
                /* If the element is not an Attribute Range, copy over the starting ID to the ending ID to make a range of 1 */
                if (AttributeLength == 2)
-                 memcpy(&CurrentAttributeRange[1], *CurrentParameter, 2);
+                 CurrentAttributeRange[1] = CurrentAttributeRange[0];
+
+               /* Swap the endianness of the attribute range values */
+               CurrentAttributeRange[0] = SwapEndian_16(CurrentAttributeRange[0]);
+               CurrentAttributeRange[1] = SwapEndian_16(CurrentAttributeRange[1]);
 
                BT_SDP_DEBUG(2, "-- Attribute: 0x%04X-0x%04X", CurrentAttributeRange[0], CurrentAttributeRange[1]);
                
@@ -439,18 +554,18 @@ static uint8_t SDP_GetUUIDList(uint8_t UUIDList[][UUID_SIZE_BYTES], const void**
                uint8_t  UUIDLength  = SDP_GetDataElementSize(CurrentParameter, &ElementHeaderSize);
                
                /* Copy over the base UUID value to the free UUID slot in the list */
-               memcpy_P(CurrentUUID, BaseUUID, sizeof(BaseUUID));
+               memcpy_P(CurrentUUID, &BaseUUID, sizeof(BaseUUID));
 
-               /* Copy over UUID from the container to the free slot - if a short UUID (<= 4 bytes) it replaces the lower
-                  4 bytes of the base UUID, otherwise it replaces the UUID completely */
-               memcpy(&CurrentUUID[(UUIDLength <= 4) ? (UUID_SIZE_BYTES - 4) : 0], *CurrentParameter, UUIDLength);
+               /* Copy over UUID from the container to the free slot */
+               memcpy(&CurrentUUID[UUID_SIZE_BYTES - UUIDLength], *CurrentParameter, UUIDLength);
                
-               BT_SDP_DEBUG(2, "-- UUID (%d): 0x%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X",
+               BT_SDP_DEBUG(2, "-- UUID (%d): %02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X",
                                UUIDLength,
-                               CurrentUUID[15], CurrentUUID[14], CurrentUUID[13], CurrentUUID[12],
-                               CurrentUUID[11], CurrentUUID[10], CurrentUUID[9],  CurrentUUID[8],
-                               CurrentUUID[7],  CurrentUUID[6],  CurrentUUID[5],  CurrentUUID[4],
-                               CurrentUUID[3],  CurrentUUID[2],  CurrentUUID[1],  CurrentUUID[0]);
+                               CurrentUUID[0], CurrentUUID[1], CurrentUUID[2], CurrentUUID[3],
+                               CurrentUUID[4], CurrentUUID[5],
+                                               CurrentUUID[6],  CurrentUUID[7],
+                               CurrentUUID[8],  CurrentUUID[9],
+                                               CurrentUUID[10],  CurrentUUID[11], CurrentUUID[12],  CurrentUUID[13],  CurrentUUID[14],  CurrentUUID[15]);
 
                ServicePatternLength -= (UUIDLength + ElementHeaderSize);
                *CurrentParameter    += UUIDLength;
@@ -470,24 +585,30 @@ static uint32_t SDP_GetLocalAttributeContainerSize(const void* const AttributeDa
        /* Fetch the size of the Data Element structure from the header */
        uint8_t SizeIndex = (pgm_read_byte(AttributeData) & 0x07);
        
+       uint32_t ElementValueSize;
+
        /* Convert the Data Element size index into a size in bytes */
        switch (SizeIndex)
        {
                case SDP_DATASIZE_Variable8Bit:
                        *HeaderSize = (1 + sizeof(uint8_t));
-                       return pgm_read_byte(AttributeData + 1);
+                       ElementValueSize = pgm_read_byte(AttributeData + 1);
+                       break;
                case SDP_DATASIZE_Variable16Bit:
                        *HeaderSize = (1 + sizeof(uint16_t));
-                       return pgm_read_word(AttributeData + 1);
+                       ElementValueSize = SwapEndian_16(pgm_read_word(AttributeData + 1));
+                       break;
                case SDP_DATASIZE_Variable32Bit:
                        *HeaderSize = (1 + sizeof(uint32_t));
-                       return pgm_read_dword(AttributeData + 1);
+                       ElementValueSize = SwapEndian_32(pgm_read_dword(AttributeData + 1));
+                       break;
                default:
                        *HeaderSize = 1;
-                       return (1 << SizeIndex);
+                       ElementValueSize = (1 << SizeIndex);
+                       break;
        }
 
-       return 0;
+       return ElementValueSize;
 }
 
 /** Retrieves the size of a Data Element container from the current input buffer, and advances the input buffer
@@ -501,34 +622,30 @@ static uint32_t SDP_GetLocalAttributeContainerSize(const void* const AttributeDa
 static uint32_t SDP_GetDataElementSize(const void** const DataElementHeader, uint8_t* const ElementHeaderSize)
 {
        /* Fetch the size of the Data Element structure from the header, increment the current buffer pos */
-       uint8_t SizeIndex = (*((uint8_t*)*DataElementHeader) & 0x07);
-       *DataElementHeader += sizeof(uint8_t);
-       
-       uint32_t ElementValue;
+       uint8_t  SizeIndex = (SDP_ReadData8(DataElementHeader) & 0x07); 
+
+       uint32_t ElementValueSize;
 
        /* Convert the Data Element size index into a size in bytes */
        switch (SizeIndex)
        {
                case SDP_DATASIZE_Variable8Bit:
-                       ElementValue = *((uint8_t*)*DataElementHeader);
-                       *DataElementHeader += sizeof(uint8_t);
+                       ElementValueSize    = SDP_ReadData8(DataElementHeader);
                        *ElementHeaderSize  = (1 + sizeof(uint8_t));
                        break;
                case SDP_DATASIZE_Variable16Bit:
-                       ElementValue = *((uint16_t*)*DataElementHeader);
-                       *DataElementHeader += sizeof(uint16_t);
+                       ElementValueSize    = SDP_ReadData16(DataElementHeader);
                        *ElementHeaderSize  = (1 + sizeof(uint16_t));
                        break;
                case SDP_DATASIZE_Variable32Bit:
-                       ElementValue = *((uint32_t*)*DataElementHeader);
-                       *DataElementHeader += sizeof(uint32_t);
+                       ElementValueSize    = SDP_ReadData32(DataElementHeader);
                        *ElementHeaderSize  = (1 + sizeof(uint32_t));
                        break;
                default:
-                       ElementValue = (1 << SizeIndex);
-                       *ElementHeaderSize = 1;
+                       ElementValueSize    = (1 << SizeIndex);
+                       *ElementHeaderSize  = 1;
                        break;
        }
        
-       return ElementValue;
+       return ElementValueSize;
 }