projects
/
pub
/
lufa.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Ensure the library builds cleanly in device mode for architectures lacking multiple...
[pub/lufa.git]
/
Demos
/
Device
/
LowLevel
/
MassStorage
/
Lib
/
SCSI.c
diff --git
a/Demos/Device/LowLevel/MassStorage/Lib/SCSI.c
b/Demos/Device/LowLevel/MassStorage/Lib/SCSI.c
index
9073aa3
..
56790dd
100644
(file)
--- a/
Demos/Device/LowLevel/MassStorage/Lib/SCSI.c
+++ b/
Demos/Device/LowLevel/MassStorage/Lib/SCSI.c
@@
-41,7
+41,7
@@
/** Structure to hold the SCSI response data to a SCSI INQUIRY command. This gives information about the device's
* features and capabilities.
*/
/** Structure to hold the SCSI response data to a SCSI INQUIRY command. This gives information about the device's
* features and capabilities.
*/
-SCSI_Inquiry_Response_t InquiryData =
+
static const
SCSI_Inquiry_Response_t InquiryData =
{
.DeviceType = DEVICE_TYPE_BLOCK,
.PeripheralQualifier = 0,
{
.DeviceType = DEVICE_TYPE_BLOCK,
.PeripheralQualifier = 0,
@@
-73,7
+73,7
@@
SCSI_Inquiry_Response_t InquiryData =
/** Structure to hold the sense data for the last issued SCSI command, which is returned to the host after a SCSI REQUEST SENSE
* command is issued. This gives information on exactly why the last command failed to complete.
*/
/** Structure to hold the sense data for the last issued SCSI command, which is returned to the host after a SCSI REQUEST SENSE
* command is issued. This gives information on exactly why the last command failed to complete.
*/
-SCSI_Request_Sense_Response_t SenseData =
+
static
SCSI_Request_Sense_Response_t SenseData =
{
.ResponseCode = 0x70,
.AdditionalLength = 0x0A,
{
.ResponseCode = 0x70,
.AdditionalLength = 0x0A,
@@
-150,8
+150,7
@@
bool SCSI_DecodeSCSICommand(void)
static bool SCSI_Command_Inquiry(void)
{
uint16_t AllocationLength = SwapEndian_16(*(uint16_t*)&CommandBlock.SCSICommandData[3]);
static bool SCSI_Command_Inquiry(void)
{
uint16_t AllocationLength = SwapEndian_16(*(uint16_t*)&CommandBlock.SCSICommandData[3]);
- uint16_t BytesTransferred = (AllocationLength < sizeof(InquiryData))? AllocationLength :
- sizeof(InquiryData);
+ uint16_t BytesTransferred = MIN(AllocationLength, sizeof(InquiryData));
/* Only the standard INQUIRY data is supported, check if any optional INQUIRY bits set */
if ((CommandBlock.SCSICommandData[1] & ((1 << 0) | (1 << 1))) ||
/* Only the standard INQUIRY data is supported, check if any optional INQUIRY bits set */
if ((CommandBlock.SCSICommandData[1] & ((1 << 0) | (1 << 1))) ||
@@
-166,12
+165,10
@@
static bool SCSI_Command_Inquiry(void)
}
/* Write the INQUIRY data to the endpoint */
}
/* Write the INQUIRY data to the endpoint */
- Endpoint_Write_Stream_LE(&InquiryData, BytesTransferred, StreamCallback_AbortOnMassStoreReset);
-
- uint8_t PadBytes[AllocationLength - BytesTransferred];
+ Endpoint_Write_Stream_LE(&InquiryData, BytesTransferred, NULL);
/* Pad out remaining bytes with 0x00 */
/* Pad out remaining bytes with 0x00 */
- Endpoint_
Write_Stream_LE(&PadBytes, sizeof(PadBytes), StreamCallback_AbortOnMassStoreReset
);
+ Endpoint_
Null_Stream((AllocationLength - BytesTransferred), NULL
);
/* Finalize the stream transfer to send the last packet */
Endpoint_ClearIN();
/* Finalize the stream transfer to send the last packet */
Endpoint_ClearIN();
@@
-190,15
+187,13
@@
static bool SCSI_Command_Inquiry(void)
static bool SCSI_Command_Request_Sense(void)
{
uint8_t AllocationLength = CommandBlock.SCSICommandData[4];
static bool SCSI_Command_Request_Sense(void)
{
uint8_t AllocationLength = CommandBlock.SCSICommandData[4];
- uint8_t BytesTransferred =
(AllocationLength < sizeof(SenseData))? AllocationLength : sizeof(SenseData
);
+ uint8_t BytesTransferred =
MIN(AllocationLength, sizeof(SenseData)
);
/* Send the SENSE data - this indicates to the host the status of the last command */
/* Send the SENSE data - this indicates to the host the status of the last command */
- Endpoint_Write_Stream_LE(&SenseData, BytesTransferred, StreamCallback_AbortOnMassStoreReset);
-
- uint8_t PadBytes[AllocationLength - BytesTransferred];
+ Endpoint_Write_Stream_LE(&SenseData, BytesTransferred, NULL);
/* Pad out remaining bytes with 0x00 */
/* Pad out remaining bytes with 0x00 */
- Endpoint_
Write_Stream_LE(&PadBytes, sizeof(PadBytes), StreamCallback_AbortOnMassStoreReset
);
+ Endpoint_
Null_Stream((AllocationLength - BytesTransferred), NULL
);
/* Finalize the stream transfer to send the last packet */
Endpoint_ClearIN();
/* Finalize the stream transfer to send the last packet */
Endpoint_ClearIN();