X-Git-Url: http://git.linex4red.de/pub/USBasp.git/blobdiff_plain/79efd8c79e723adb3392367ae62356c5c3a835d0..24f730fce3f2022762011d795c3feada5ef874b3:/Projects/AVRISP/Lib/NVMTarget.c?ds=inline diff --git a/Projects/AVRISP/Lib/NVMTarget.c b/Projects/AVRISP/Lib/NVMTarget.c index b6922d5e5..adf213bb4 100644 --- a/Projects/AVRISP/Lib/NVMTarget.c +++ b/Projects/AVRISP/Lib/NVMTarget.c @@ -42,23 +42,20 @@ * * \param[in] Register NVM register whose absolute address is to be sent */ -void NVMTarget_SendNVMRegAddress(uint8_t Register) +void NVMTarget_SendNVMRegAddress(const uint8_t Register) { /* Determine the absolute register address from the NVM base memory address and the NVM register address */ uint32_t Address = XPROG_Param_NVMBase | Register; /* Send the calculated 32-bit address to the target, LSB first */ - PDITarget_SendByte(Address & 0xFF); - PDITarget_SendByte(Address >> 8); - PDITarget_SendByte(Address >> 16); - PDITarget_SendByte(Address >> 24); + NVMTarget_SendAddress(Address); } /** Sends the given 32-bit absolute address to the target. * * \param[in] AbsoluteAddress Absolute address to send to the target */ -void NVMTarget_SendAddress(uint32_t AbsoluteAddress) +void NVMTarget_SendAddress(const uint32_t AbsoluteAddress) { /* Send the given 32-bit address to the target, LSB first */ PDITarget_SendByte(AbsoluteAddress & 0xFF); @@ -75,9 +72,12 @@ void NVMTarget_SendAddress(uint32_t AbsoluteAddress) bool NVMTarget_WaitWhileNVMControllerBusy(void) { TCNT0 = 0; - + TIFR0 = (1 << OCF1A); + + uint8_t TimeoutMS = PDI_NVM_TIMEOUT_MS; + /* Poll the NVM STATUS register while the NVM controller is busy */ - while (TCNT0 < NVM_BUSY_TIMEOUT_MS) + while (TimeoutMS) { /* Send a LDS command to read the NVM STATUS register to check the BUSY flag */ PDITarget_SendByte(PDI_CMD_LDS | (PDI_DATSIZE_4BYTES << 2)); @@ -86,6 +86,12 @@ bool NVMTarget_WaitWhileNVMControllerBusy(void) /* Check to see if the BUSY flag is still set */ if (!(PDITarget_ReceiveByte() & (1 << 7))) return true; + + if (TIFR0 & (1 << OCF1A)) + { + TIFR0 = (1 << OCF1A); + TimeoutMS--; + } } return false; @@ -96,9 +102,9 @@ bool NVMTarget_WaitWhileNVMControllerBusy(void) * \param[in] CRCCommand NVM CRC command to issue to the target * \param[out] CRCDest CRC Destination when read from the target * - * \return Boolean true if the command sequence complete sucessfully + * \return Boolean true if the command sequence complete successfully */ -bool NVMTarget_GetMemoryCRC(uint8_t CRCCommand, uint32_t* CRCDest) +bool NVMTarget_GetMemoryCRC(const uint8_t CRCCommand, uint32_t* const CRCDest) { /* Wait until the NVM controller is no longer busy */ if (!(NVMTarget_WaitWhileNVMControllerBusy())) @@ -148,15 +154,15 @@ bool NVMTarget_GetMemoryCRC(uint8_t CRCCommand, uint32_t* CRCDest) * \param[out] ReadBuffer Buffer to store read data into * \param[in] ReadSize Number of bytes to read * - * \return Boolean true if the command sequence complete sucessfully + * \return Boolean true if the command sequence complete successfully */ -bool NVMTarget_ReadMemory(uint32_t ReadAddress, uint8_t* ReadBuffer, uint16_t ReadSize) +bool NVMTarget_ReadMemory(const uint32_t ReadAddress, uint8_t* ReadBuffer, const uint16_t ReadSize) { /* Wait until the NVM controller is no longer busy */ if (!(NVMTarget_WaitWhileNVMControllerBusy())) return false; - /* Send the READNVM command to the NVM controller for reading of an aribtrary location */ + /* Send the READNVM command to the NVM controller for reading of an arbitrary location */ PDITarget_SendByte(PDI_CMD_STS | (PDI_DATSIZE_4BYTES << 2)); NVMTarget_SendNVMRegAddress(NVM_REG_CMD); PDITarget_SendByte(NVM_CMD_READNVM); @@ -166,9 +172,8 @@ bool NVMTarget_ReadMemory(uint32_t ReadAddress, uint8_t* ReadBuffer, uint16_t Re NVMTarget_SendAddress(ReadAddress); /* Send the REPEAT command with the specified number of bytes to read */ - PDITarget_SendByte(PDI_CMD_REPEAT | PDI_DATSIZE_2BYTES); - PDITarget_SendByte(ReadSize & 0xFF); - PDITarget_SendByte(ReadSize >> 8); + PDITarget_SendByte(PDI_CMD_REPEAT | PDI_DATSIZE_1BYTE); + PDITarget_SendByte(ReadSize - 1); /* Send a LD command with indirect access and postincrement to read out the bytes */ PDITarget_SendByte(PDI_CMD_LD | (PDI_POINTER_INDIRECT_PI << 2) | PDI_DATSIZE_1BYTE); @@ -183,28 +188,24 @@ bool NVMTarget_ReadMemory(uint32_t ReadAddress, uint8_t* ReadBuffer, uint16_t Re * \param[in] WriteCommand Command to send to the device to write each memory byte * \param[in] WriteAddress Start address to write to within the target's address space * \param[in] WriteBuffer Buffer to source data from - * \param[in] WriteSize Number of bytes to write * - * \return Boolean true if the command sequence complete sucessfully + * \return Boolean true if the command sequence complete successfully */ -bool NVMTarget_WriteByteMemory(uint8_t WriteCommand, uint32_t WriteAddress, uint8_t* WriteBuffer, uint16_t WriteSize) +bool NVMTarget_WriteByteMemory(const uint8_t WriteCommand, const uint32_t WriteAddress, const uint8_t* WriteBuffer) { - for (uint16_t i = 0; i < WriteSize; i++) - { - /* Wait until the NVM controller is no longer busy */ - if (!(NVMTarget_WaitWhileNVMControllerBusy())) - return false; + /* Wait until the NVM controller is no longer busy */ + if (!(NVMTarget_WaitWhileNVMControllerBusy())) + return false; - /* Send the memory write command to the target */ - PDITarget_SendByte(PDI_CMD_STS | (PDI_DATSIZE_4BYTES << 2)); - NVMTarget_SendNVMRegAddress(NVM_REG_CMD); - PDITarget_SendByte(WriteCommand); + /* Send the memory write command to the target */ + PDITarget_SendByte(PDI_CMD_STS | (PDI_DATSIZE_4BYTES << 2)); + NVMTarget_SendNVMRegAddress(NVM_REG_CMD); + PDITarget_SendByte(WriteCommand); - /* Send each new memory byte to the memory to the target */ - PDITarget_SendByte(PDI_CMD_STS | (PDI_DATSIZE_4BYTES << 2)); - NVMTarget_SendAddress(WriteAddress++); - PDITarget_SendByte(*(WriteBuffer++)); - } + /* Send new memory byte to the memory to the target */ + PDITarget_SendByte(PDI_CMD_STS | (PDI_DATSIZE_4BYTES << 2)); + NVMTarget_SendAddress(WriteAddress); + PDITarget_SendByte(*(WriteBuffer++)); return true; } @@ -219,10 +220,11 @@ bool NVMTarget_WriteByteMemory(uint8_t WriteCommand, uint32_t WriteAddress, uint * \param[in] WriteBuffer Buffer to source data from * \param[in] WriteSize Number of bytes to write * - * \return Boolean true if the command sequence complete sucessfully + * \return Boolean true if the command sequence complete successfully */ -bool NVMTarget_WritePageMemory(uint8_t WriteBuffCommand, uint8_t EraseBuffCommand, uint8_t WritePageCommand, - uint8_t PageMode, uint32_t WriteAddress, uint8_t* WriteBuffer, uint16_t WriteSize) +bool NVMTarget_WritePageMemory(const uint8_t WriteBuffCommand, const uint8_t EraseBuffCommand, + const uint8_t WritePageCommand, const uint8_t PageMode, const uint32_t WriteAddress, + const uint8_t* WriteBuffer, const uint16_t WriteSize) { if (PageMode & XPRG_PAGEMODE_ERASE) { @@ -257,22 +259,13 @@ bool NVMTarget_WritePageMemory(uint8_t WriteBuffCommand, uint8_t EraseBuffComman NVMTarget_SendAddress(WriteAddress); /* Send the REPEAT command with the specified number of bytes to write */ - PDITarget_SendByte(PDI_CMD_REPEAT | PDI_DATSIZE_2BYTES); - PDITarget_SendByte(WriteSize & 0xFF); - PDITarget_SendByte(WriteSize >> 8); + PDITarget_SendByte(PDI_CMD_REPEAT | PDI_DATSIZE_1BYTE); + PDITarget_SendByte(WriteSize - 1); /* Send a ST command with indirect access and postincrement to write the bytes */ PDITarget_SendByte(PDI_CMD_ST | (PDI_POINTER_INDIRECT_PI << 2) | PDI_DATSIZE_1BYTE); for (uint16_t i = 0; i < WriteSize; i++) PDITarget_SendByte(*(WriteBuffer++)); - - // TEMP - PDITarget_SendByte(PDI_CMD_LDS | (PDI_DATSIZE_4BYTES << 2)); - NVMTarget_SendNVMRegAddress(NVM_REG_STATUS); - GPIOR0 = PDITarget_ReceiveByte(); - if (!(GPIOR0 & (1 << 0))) - JTAG_DEBUG_POINT(); - // END TEMP } if (PageMode & XPRG_PAGEMODE_WRITE) @@ -300,9 +293,9 @@ bool NVMTarget_WritePageMemory(uint8_t WriteBuffCommand, uint8_t EraseBuffComman * \param[in] EraseCommand NVM erase command to send to the device * \param[in] Address Address inside the memory space to erase * - * \return Boolean true if the command sequence complete sucessfully + * \return Boolean true if the command sequence complete successfully */ -bool NVMTarget_EraseMemory(uint8_t EraseCommand, uint32_t Address) +bool NVMTarget_EraseMemory(const uint8_t EraseCommand, const uint32_t Address) { /* Wait until the NVM controller is no longer busy */ if (!(NVMTarget_WaitWhileNVMControllerBusy())) @@ -313,7 +306,7 @@ bool NVMTarget_EraseMemory(uint8_t EraseCommand, uint32_t Address) NVMTarget_SendNVMRegAddress(NVM_REG_CMD); PDITarget_SendByte(EraseCommand); - /* Chip erase is handled seperately, since it's procedure is different to other erase types */ + /* Chip erase is handled separately, since it's procedure is different to other erase types */ if (EraseCommand == NVM_CMD_CHIPERASE) { /* Set CMDEX bit in NVM CTRLA register to start the chip erase */