From e4e50d44c431e243bba5fe776cbfd2dce73c43c1 Mon Sep 17 00:00:00 2001 From: "David A. Velasco" Date: Tue, 3 Feb 2015 09:52:22 +0100 Subject: [PATCH] Corrections from my own comments --- res/drawable-xhdpi/notification_icon.png | Bin 0 -> 1212 bytes res/layout/list_fragment.xml | 4 +- src/com/owncloud/android/ui/ExtendedListView.java | 73 --------------------- src/com/owncloud/android/ui/SquareImageView.java | 17 +++++ .../owncloud/android/ui/SquareLinearLayout.java | 17 +++++ .../android/ui/fragment/LocalFileListFragment.java | 15 ----- 6 files changed, 36 insertions(+), 90 deletions(-) create mode 100644 res/drawable-xhdpi/notification_icon.png delete mode 100644 src/com/owncloud/android/ui/ExtendedListView.java diff --git a/res/drawable-xhdpi/notification_icon.png b/res/drawable-xhdpi/notification_icon.png new file mode 100644 index 0000000000000000000000000000000000000000..b3855d61a6e24641cf81b66c143c1fa46bb6dd55 GIT binary patch literal 1212 zcmV;t1Vj6YP)iA&aOdV$U> z&74bSYfMYBj=2u%)-!biCah{oo0OY2DH(}0i^9o{UDvcwS9en{90bZgbYkOqZ%Dr1 z_xZl}ectCg)X8_fgw1T62fu5Z)c?9I*yP3nU;(fISO6@5|2F{6MlUFnh#;4Wp;9&@ z6pmo_W(3Re#D5&0X^l-Gq12MN&t@AF&X{eNnykkbL z`S9KcpKiGS72SZzsE5gDz;ZkRH|2vtcc7s20ML0@53fG}uYbI@A!M_5!Dh8&wCOtz zlr;CPBd^sSfZ3QC<4en>Cuo~i1AA{zD!~UXe1j;>)Rsm=;YgYJ!b6)@gYGw8MZn{P z&D!~zLBqTE)b&`{7y4jVO5Hq z8@L3yR1EEIRqAkJGy@mq!=Up@DWGx}vh}jy{4kYwh3|Yn1{1;QoP8>#0xrkt^6S87 zA0N+(<@HpVZVe6Gs(5^@0DY*G3YgXv&Vm5ct<5=OS=#hu&Gf#>Xehl7=sVhT4l*9n z!8PiI`4vNo_o*Llpn=Q9{K8^Y4i=lQZf%CisE14rZAZ*6cjEzshP5B_;6Oc>AXy9_w z-VJl;a}49esk4aE493Q%5DL#>uV!azkM#Gm<(-rGDG*YF?%yoHPl7C<$Y)U - . - * - */ - -package com.owncloud.android.ui; - -import android.content.Context; -import android.graphics.Canvas; -import android.util.AttributeSet; -import android.widget.GridView; - -/** - * GridView allowing to specify the position of an item that should be top left in the visible area, if possible. - * - * The cleanest way I found to overcome the problem due to getHeight() returns 0 until the view is really drawn. - * - * @author David A. Velasco - */ -public class ExtendedListView extends GridView { - - private int mPositionToSetTopLeft; - - public ExtendedListView(Context context) { - super(context); - } - - public ExtendedListView(Context context, AttributeSet attrs) { - super(context, attrs); - } - - public ExtendedListView(Context context, AttributeSet attrs, int defStyle) { - super(context, attrs, defStyle); - } - - /** - * {@inheritDoc} - * - * - */ - @Override - protected void onDraw (Canvas canvas) { - super.onDraw(canvas); - if (mPositionToSetTopLeft > 0) { - this.smoothScrollToPosition(mPositionToSetTopLeft); - mPositionToSetTopLeft = 0; - } - } - - /** - * Public method to set the position of the item that should be top left in the visible area of the view. - * - * The position is saved here and checked in onDraw(). - * - * @param position Position (in the list of items) of the item to be top left in the visible area. - */ - public void setSelectionAsTopLeft(int position) { - mPositionToSetTopLeft = position; - } -} diff --git a/src/com/owncloud/android/ui/SquareImageView.java b/src/com/owncloud/android/ui/SquareImageView.java index 3c909999..455bdc9d 100644 --- a/src/com/owncloud/android/ui/SquareImageView.java +++ b/src/com/owncloud/android/ui/SquareImageView.java @@ -1,3 +1,20 @@ +/* ownCloud Android client application + * Copyright (C) 2015 ownCloud Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + */ + package com.owncloud.android.ui; import android.content.Context; diff --git a/src/com/owncloud/android/ui/SquareLinearLayout.java b/src/com/owncloud/android/ui/SquareLinearLayout.java index a7795d2e..4a8148f0 100644 --- a/src/com/owncloud/android/ui/SquareLinearLayout.java +++ b/src/com/owncloud/android/ui/SquareLinearLayout.java @@ -1,3 +1,20 @@ +/* ownCloud Android client application + * Copyright (C) 2015 ownCloud Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + */ + package com.owncloud.android.ui; import android.content.Context; diff --git a/src/com/owncloud/android/ui/fragment/LocalFileListFragment.java b/src/com/owncloud/android/ui/fragment/LocalFileListFragment.java index 4a6ea0bf..a20cc3c0 100644 --- a/src/com/owncloud/android/ui/fragment/LocalFileListFragment.java +++ b/src/com/owncloud/android/ui/fragment/LocalFileListFragment.java @@ -98,21 +98,6 @@ public class LocalFileListFragment extends ExtendedListFragment { Log_OC.i(TAG, "onActivityCreated() stop"); } - public void selectAll(){ - int numberOfFiles = mAdapter.getCount(); - for(int i = 0; i < numberOfFiles; i++){ - File file = (File) mAdapter.getItem(i); - if (file != null) { - if (!file.isDirectory()) { - /// Click on a file - getGridView().setItemChecked(i, true); - // notify the change to the container Activity - mContainerActivity.onFileClick(file); - } - } - } - } - /** * Checks the file clicked over. Browses inside if it is a directory. Notifies the container activity in any case. */ -- 2.11.0