From db4353187498584353b5c4b1a08f8308eda91fc4 Mon Sep 17 00:00:00 2001 From: masensio Date: Mon, 26 May 2014 13:00:22 +0200 Subject: [PATCH] Add specific message(s) for network error(s) in strings.xml --- res/values/strings.xml | 7 +++++ .../android/utils/ErrorMessageAdapter.java | 32 +++++++++++++++++++++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 19d006d0..23a001a3 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -274,4 +274,11 @@ Copied to clipboard Critical error: can not perform operations + + An error occurred while connecting with the server. + An error occurred while waiting for the server, the operation couldn\'t have been done + An error occurred while waiting for the server, the operation couldn\'t have been done + Unexpected exception + + diff --git a/src/com/owncloud/android/utils/ErrorMessageAdapter.java b/src/com/owncloud/android/utils/ErrorMessageAdapter.java index 3baf72b9..411ade56 100644 --- a/src/com/owncloud/android/utils/ErrorMessageAdapter.java +++ b/src/com/owncloud/android/utils/ErrorMessageAdapter.java @@ -19,7 +19,8 @@ package com.owncloud.android.utils; import java.io.File; - +import java.net.SocketTimeoutException; +import org.apache.commons.httpclient.ConnectTimeoutException; import android.content.res.Resources; import com.owncloud.android.R; @@ -75,6 +76,35 @@ public class ErrorMessageAdapter { } } + + return message; + } + + public static String getErrorMessage(RemoteOperationResult result , Resources res) { + + String message = null; + + if (!result.isSuccess()) { + + switch (result.getCode()) { + case WRONG_CONNECTION: + message = res.getString(R.string.network_error_socket_exception); + break; + + case TIMEOUT: + if (result.getException() instanceof SocketTimeoutException) { + message = res.getString(R.string.network_error_socket_timeout_exception); + } else if(result.getException() instanceof ConnectTimeoutException) { + message = res.getString(R.string.network_error_connect_timeout_exception); + } + break; + + default: + message = res.getString(R.string.unexpected_exception); + break; + } + } + return message; } } -- 2.11.0