From: tobiasKaminsky Date: Sat, 21 Nov 2015 08:50:57 +0000 (+0100) Subject: Merge remote-tracking branch 'remotes/upstream/resizedImages' into beta X-Git-Tag: beta-20151122~1 X-Git-Url: http://git.linex4red.de/pub/Android/ownCloud.git/commitdiff_plain/c3217b323a606cd629a5ae4321698e6cc83eb4de?hp=c00d952cdc41342723ba4b124708fe4493baf4b1 Merge remote-tracking branch 'remotes/upstream/resizedImages' into beta --- diff --git a/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java b/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java index 70730fd2..8c36fa2e 100644 --- a/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java +++ b/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java @@ -271,7 +271,7 @@ public class ThumbnailsCacheManager { } } imageView.setImageBitmap(bitmap); - imageView.setVisibility(View.VISIBLE); + // imageView.setVisibility(View.VISIBLE); } } } diff --git a/src/com/owncloud/android/ui/preview/PreviewImageFragment.java b/src/com/owncloud/android/ui/preview/PreviewImageFragment.java index b3aab453..bdbfa1fc 100644 --- a/src/com/owncloud/android/ui/preview/PreviewImageFragment.java +++ b/src/com/owncloud/android/ui/preview/PreviewImageFragment.java @@ -208,17 +208,29 @@ public class PreviewImageFragment extends FileFragment { mImageView.setTag(getFile().getFileId()); if (mShowResizedImage){ - Bitmap thumbnail = ThumbnailsCacheManager.getBitmapFromDiskCache( - String.valueOf("r" + getFile().getRemoteId()) - ); + Bitmap resizedImage = ThumbnailsCacheManager.getBitmapFromDiskCache( + String.valueOf("r" + getFile().getRemoteId())); - if (thumbnail != null && !getFile().needsUpdateThumbnail()){ + if (resizedImage != null && !getFile().needsUpdateThumbnail()){ mProgressWheel.setVisibility(View.GONE); - mImageView.setImageBitmap(thumbnail); + mImageView.setImageBitmap(resizedImage); mImageView.setVisibility(View.VISIBLE); - mBitmap = thumbnail; + mBitmap = resizedImage; } else { - // generate new Thumbnail + // show thumbnail while loading resized image + Bitmap thumbnail = ThumbnailsCacheManager.getBitmapFromDiskCache( + String.valueOf("t" + getFile().getRemoteId())); + + if (thumbnail != null){ + mImageView.setImageBitmap(thumbnail); + mProgressWheel.setVisibility(View.VISIBLE); + mImageView.setVisibility(View.VISIBLE); + mBitmap = thumbnail; + } else { + thumbnail = ThumbnailsCacheManager.mDefaultImg; + } + + // generate new resized image if (ThumbnailsCacheManager.cancelPotentialWork(getFile(), mImageView) && mContainerActivity.getStorageManager() != null) { final ThumbnailsCacheManager.ThumbnailGenerationTask task = @@ -226,13 +238,13 @@ public class PreviewImageFragment extends FileFragment { mImageView, mContainerActivity.getStorageManager(), mContainerActivity.getStorageManager().getAccount(), mProgressWheel); - if (thumbnail == null) { - thumbnail = ThumbnailsCacheManager.mDefaultImg; + if (resizedImage == null) { + resizedImage = thumbnail; } final ThumbnailsCacheManager.AsyncDrawable asyncDrawable = new ThumbnailsCacheManager.AsyncDrawable( MainApp.getAppContext().getResources(), - thumbnail, + resizedImage, task ); mImageView.setImageDrawable(asyncDrawable);