From: purigarcia Date: Fri, 29 May 2015 12:17:52 +0000 (+0200) Subject: Merge branch 'develop' into automationTest X-Git-Tag: oc-android-1.7.2~1^2~32^2~12 X-Git-Url: http://git.linex4red.de/pub/Android/ownCloud.git/commitdiff_plain/916bd5c6ca02dde2916732a826814377e495dcfe?hp=f973a1db0eae8ff2df538caad210ef3f6fa2bae7 Merge branch 'develop' into automationTest --- diff --git a/owncloud-android-library b/owncloud-android-library index e73e4a56..e48aa9c3 160000 --- a/owncloud-android-library +++ b/owncloud-android-library @@ -1 +1 @@ -Subproject commit e73e4a56d3c12d7a2f856ae65b00789b3e0cecb5 +Subproject commit e48aa9c30447d67b0f8ee2054e1fc826108fc5ec diff --git a/res/layout/preview_image_fragment.xml b/res/layout/preview_image_fragment.xml index 611351b8..d584b445 100644 --- a/res/layout/preview_image_fragment.xml +++ b/res/layout/preview_image_fragment.xml @@ -29,8 +29,8 @@ @@ -57,9 +57,10 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_centerHorizontal="true" - android:layout_below="@id/image" + android:layout_alignParentBottom="true" android:layout_margin="40dp" android:text="@string/placeholder_sentence" + android:textColor="@color/owncloud_blue_bright" /> \ No newline at end of file diff --git a/res/values-ca/strings.xml b/res/values-ca/strings.xml index 50a9c3d7..7e92694e 100644 --- a/res/values-ca/strings.xml +++ b/res/values-ca/strings.xml @@ -23,6 +23,7 @@ Més Comptes Gestió de comptes + Contrasenya Pujada instantànies de fotografies Puja instantàniament les fotografies preses amb la càmera Pujades de vídeos instantanies diff --git a/res/values-cs-rCZ/strings.xml b/res/values-cs-rCZ/strings.xml index acc4970d..181a0bab 100644 --- a/res/values-cs-rCZ/strings.xml +++ b/res/values-cs-rCZ/strings.xml @@ -305,4 +305,5 @@ správce systému. %1$s sdílí \"%2$s\" s vámi Obnovit připojení Adresa serveru + Nedostatek paměti diff --git a/res/values-da/strings.xml b/res/values-da/strings.xml index 12262e09..33ac4887 100644 --- a/res/values-da/strings.xml +++ b/res/values-da/strings.xml @@ -23,6 +23,7 @@ Mere Konti Administrér konti + Passcode-lås Upload billeder straks Upload straks billeder taget med kameraet Upload videoer straks @@ -126,6 +127,15 @@ Lokal: %1$s Fjernplacering: %1$s Der er ikke plads nok til at kopiere de valgte filer ind i mappen %1$s. Vil du flytte dem i stedet? + Indsæt venligst din passcode + Angiv din passcode + Denne passcode vil blive forespurgt hver gang app\'en startes + Angiv venligst din passcode påny + Fjern din passcode + Passcode\'erne er ikke ens + Ukorrekt passcode + Passcode blev fjernet + Passcode blev gendannet %1$s musikafspiller %1$s (afspiller) %1$s (indlæser) @@ -295,4 +305,5 @@ %1$s delt \"%2$s\" med dig Genopfrisk forbindelsen Serveradresse + Ikke tilstrækkelig hukommelse diff --git a/res/values-de-rDE/strings.xml b/res/values-de-rDE/strings.xml index 48871b5e..620ba0eb 100644 --- a/res/values-de-rDE/strings.xml +++ b/res/values-de-rDE/strings.xml @@ -306,4 +306,5 @@ %1$s hat „%2$s“ mit Ihnen geteilt Verbindung aktualisieren Serveradresse + Nicht genügend Speicher diff --git a/res/values-de/strings.xml b/res/values-de/strings.xml index 31c9ab5b..3f7f4917 100644 --- a/res/values-de/strings.xml +++ b/res/values-de/strings.xml @@ -306,4 +306,5 @@ %1$s hat „%2$s“ mit Dir geteilt Verbindung aktualisieren Serveradresse + Nicht genügend Speicher diff --git a/res/values-el/strings.xml b/res/values-el/strings.xml index eb00336e..3b810e60 100644 --- a/res/values-el/strings.xml +++ b/res/values-el/strings.xml @@ -306,4 +306,5 @@ %1$s μοιράστηκε \"%2$s\" μαζί σας Ανανέωση σύνδεσης Διεύθυνση διακομιστή + Δεν υπάρχει αρκετή μνήμη diff --git a/res/values-en-rGB/strings.xml b/res/values-en-rGB/strings.xml index d8163f3e..f7f155c6 100644 --- a/res/values-en-rGB/strings.xml +++ b/res/values-en-rGB/strings.xml @@ -23,6 +23,7 @@ More Accounts Manage Accounts + Passcode lock Instant picture uploads Instantly upload pictures taken by camera Instant video uploads @@ -126,6 +127,15 @@ Local: %1$s Remote: %1$s There is not enough space to copy the selected files into the %1$s folder. Would you like to move them instead? + Please, insert your passcode + Enter your passcode + The passcode will be requested every time the app is started + Please, reenter your passcode + Remove your passcode + The passcodes are not the same + Incorrect passcode + Passcode removed + Passcode stored %1$s music player %1$s (playing) %1$s (loading) @@ -201,6 +211,7 @@ Unexpected problem; please select the file from a different app No file was selected Send link to … + Copying file from private storage Log in with oAuth2 Connecting to oAuth2 server… The identity of the site could not be verified diff --git a/res/values-es/strings.xml b/res/values-es/strings.xml index a9d379a8..de0703da 100644 --- a/res/values-es/strings.xml +++ b/res/values-es/strings.xml @@ -306,4 +306,5 @@ %1$s compartió \"%2$s\" contigo Refrescar la conexión Dirección del servidor + No hay suficiente memoria diff --git a/res/values-fi-rFI/strings.xml b/res/values-fi-rFI/strings.xml index c45a019f..0b6a8350 100644 --- a/res/values-fi-rFI/strings.xml +++ b/res/values-fi-rFI/strings.xml @@ -36,6 +36,7 @@ Ohje Suosittele kaverille Palaute + Tiedot Muista jaon sijainti Muista viimeisin jaon lähetyssijainti Kokeile %1$sia älypuhelimellasi! @@ -201,6 +202,7 @@ Odottamaton ongelma; kokeile valita tiedosto toisella sovelluksella Tiedostoa ei valittu Lähetä linkki… + Kopioidaan tiedostoa yksityisestä tallennustilasta Kirjaudu oAuth2:lla Yhdistetään oAuth2-palvelimeen… Sivuston identiteetin vahvistaminen ei onnistunut @@ -229,6 +231,7 @@ - Ei lisätietoja virheestä PNG-kuva 389 kt + 12:23:45 Lähetä kuvat vain WiFi-verkossa Lähetä videot vain wifi-yhteydellä /InstantUpload @@ -242,6 +245,7 @@ Lähetyspolku Jakaminen ei ole käytössä palvelimellasi. Ota yhteys ylläpitäjään. + Jakaminen epäonnistui. Varmista, että tiedosto on olemassa Virhe tiedoston tai kansion jakamista yrittäessä Anna salasana Salasana on pakko antaa @@ -268,6 +272,7 @@ Lokit Lähetä historia Lokien lähettämistä varten ei löytynyt sovellusta. Asenna sähköpostisovellus! + %1$sin Android-sovelluksen lokit Ladataan tietoja… Tunnistautuminen vaaditaan Väärä salasana @@ -282,4 +287,5 @@ %1$s jakoi kohteen \"%2$s\" kanssasi Päivitä yhteys Palvelimen osoite + Muistia ei ole riittävästi diff --git a/res/values-fr/strings.xml b/res/values-fr/strings.xml index 6c8122f6..91c83ea8 100644 --- a/res/values-fr/strings.xml +++ b/res/values-fr/strings.xml @@ -23,7 +23,7 @@ Plus Comptes Gestion des comptes - Code de verrouillage + Code de sécurité Téléversement immédiat des photos Téléverser immédiatement les photos prises par la caméra Téléversement immédiat des vidéos @@ -167,7 +167,7 @@ Ci-dessous la liste des fichiers locaux, et les fichiers distants dans %5$s auxq Connexion établie Test de connexion Configuration du serveur erronée - Un compte pour les même utilisateur et serveur existe déjà sur cet appareil + Un compte pour les mêmes utilisateur et serveur existe déjà sur cet appareil L\'utilisateur entré ne correspond pas à l\'utilisateur de ce compte Une erreur inconnue s\'est produite. Impossible de trouver l\'hôte @@ -310,4 +310,5 @@ Ci-dessous la liste des fichiers locaux, et les fichiers distants dans %5$s auxq %1$s a partagé \"%2$s\" avec vous Actualiser la connexion Adresse du serveur + Mémoire insuffisante diff --git a/res/values-gl/strings.xml b/res/values-gl/strings.xml index a06206f1..2e8f23a0 100644 --- a/res/values-gl/strings.xml +++ b/res/values-gl/strings.xml @@ -307,4 +307,5 @@ Descárgueo de aquí: %2$s %1$s compartiu «%2$s» con vostede Actualizar a conexión Enderezo do servidor + Non hai memoria abondo diff --git a/res/values-id/strings.xml b/res/values-id/strings.xml index 6361e8da..446baa89 100644 --- a/res/values-id/strings.xml +++ b/res/values-id/strings.xml @@ -23,6 +23,7 @@ Lainnya Akun Kelola Akun + Kunci kode sandi Unggah gambar cepat Unggah gambar yang diambil kamera dengan cepat Unggah video cepat @@ -118,7 +119,7 @@ Konten berkas %1$d tidak dapat disinkronasikan (%2$d konflik) Beberapa berkas lokal terlupakan %1$d berkas diluar folder %2$s tidak dapat disalin kedalamnya - Sejak versi 1.3.16, berkas-berkas yang diunggah dari piranti ini akan disalin kedalam folder %1$s lokal untuk mencagah kehilangan data saat berkas tunggal disinkronkan dengan akun lebih dari satu.\n\nAkibat perubahan ini, semua berkas yang diunggah di versi aplikasi sebelumnya disalin kedalam folder %2$s. Namun, sebuah kesalahan mencegah penyelesaian operasi ini saat sinkronisasi akun. Anda boleh meninggalkan berkas seperti ini dan menghapus tautan ke %3$s atau memindahkan berkas kedalam folder %1$s dan membiarkan tautan ke %4$s.\n\nYang tampak dibawah adalah berkas lokal, dan berkas remote didalam %5$s yang dihubungkan dengannya. + Sejak versi 1.3.16, berkas-berkas yang diunggah dari perangkat ini akan disalin kedalam folder %1$s lokal untuk mencagah kehilangan data saat berkas tunggal disinkronkan dengan akun lebih dari satu.\n\nAkibat perubahan ini, semua berkas yang diunggah di versi aplikasi sebelumnya disalin kedalam folder %2$s. Namun, sebuah kesalahan mencegah penyelesaian operasi ini saat sinkronisasi akun. Anda boleh meninggalkan berkas seperti ini dan menghapus tautan ke %3$s atau memindahkan berkas kedalam folder %1$s dan membiarkan tautan ke %4$s.\n\nYang tampak dibawah adalah berkas lokal, dan berkas remote didalam %5$s yang dihubungkan dengannya. Folder %1$s tidak ada lagi Pindahkan semua Semua berkas sudah dipindahkan @@ -126,6 +127,15 @@ Lokal: %1$s Jauh: %1$s Ruang tidak cukup untuk menyalin berkas terpilih kedalam folder %1$s. Apakah Anda ingin memindahkannya saja? + Silakan masukkan kode sandi Anda + Masukkan kode sandi Anda + Kode sandi akan diminta setiap kali apl dijalankan. + Silakan masukkan ulang kode sandi Anda + Hapus kode sandi Anda + Kode sandi tidak sama + Kode sandi salah + Kode sandi dihapus + Kode sandi disimpan Pemutar musik %1$s %1$s (dimainkan) %1$s (sedang dimuat) @@ -150,6 +160,7 @@ Tidak ada koneksi internet Sambungan aman tidak tersedia Sambungan dibuat + Mencoba sambungan Konfigurasi server cacat Akun untuk pengguna dan server yang sama sudah ada dalam perangkat Pengguna yang dimasukkan tidak cocok dengan pengguna akun ini @@ -176,6 +187,7 @@ Server Anda tidak membalas id pengguna dengan banar, Sialakn hubungi Administrator Tidak dapat mengotentikasi pada server ini + Akun tidak ada di perangkat ini Biarkan berkas tetap terbaru Ubah nama Hapus @@ -199,6 +211,7 @@ Masalah tidak terduga, silahkan pilih berkas dari apl yang berbeda Tidak ada berkas yang terpilih Kirim taukan ke + Menyalin berkas dari penyimpanan pribadi Masuk dengan oAuth2 Menyambungkan ke server oAuth2... Identitas situs tidak dapat diverfikasi @@ -273,6 +286,9 @@ Sambungan aman dialihkan ke rute yang tidak aman. Log Kirim Riwayat + Tidak ada apl untuk mengirim log. Instal apl mail! + %1$s Android apl log + Memuat data... Diperlukan otentikasi Sandi salah Pindah @@ -285,5 +301,9 @@ untuk memindahkan berkas ini Unggah Cepat Keamanan + Unggah Lokasi Video + Mengunduh folder %1$s tidak selesai + %1$s berbagi \"%2$s\" dengan Anda + Menyegarkan sambungan Alamat server diff --git a/res/values-it/strings.xml b/res/values-it/strings.xml index d375b12e..51d8ef0f 100644 --- a/res/values-it/strings.xml +++ b/res/values-it/strings.xml @@ -306,4 +306,5 @@ %1$s ha condiviso \"%2$s\" con te Aggiorna la connessione Indirizzo del server + Memoria insufficiente diff --git a/res/values-nb-rNO/strings.xml b/res/values-nb-rNO/strings.xml index 64cf7a19..b8144867 100644 --- a/res/values-nb-rNO/strings.xml +++ b/res/values-nb-rNO/strings.xml @@ -23,6 +23,7 @@ Mer Kontoer Håndter kontoer + Passordlås Umiddelbare bildeopplastninger Last opp bilder tatt av kameraet umiddelbart Umiddelbare video-opplastninger @@ -126,6 +127,15 @@ Lokal: %1$s Ekstern: %1$s Det er ikke nok plass til å kopiere de valgte filene inn i mappen %1$s. Vil du flytte dem i stedet? + Legg inn passordet ditt + Skriv inn passordet ditt + Passordet vil bli krevd hver gang appen startes + Skriv inn passordet på nytt + Fjern passordet ditt + Passordene er ikke like + Feil passord + Passord fjernet + Passord lagret %1$s musikkspiller %1$s (spiller) %1$s (laster) @@ -201,6 +211,7 @@ Uforventet problem; vennligst velg filen fra en annen applikasjon Ingen fil ble valgt Send lenke til ... + Kopierer fil fra privat lager Logg inn med oAuth2 Kobler til oAuth2 server... Identiteten til siden kunne ikke verifiseres @@ -295,4 +306,5 @@ %1$s har delt \"%2$s\" med deg Oppfrisk forbindelse Server-adresse + Ikke nok minne diff --git a/res/values-nl/strings.xml b/res/values-nl/strings.xml index 1174c470..0ab33ba1 100644 --- a/res/values-nl/strings.xml +++ b/res/values-nl/strings.xml @@ -309,4 +309,5 @@ Hieronder staan de lokale bestanden en de externe bestanden in %5$s waar ze naar %1$s deelde \"%2$s\" met u Verversen verbinding Serveradres + Niet voldoende geheugen diff --git a/res/values-pt-rBR/strings.xml b/res/values-pt-rBR/strings.xml index 92dbc894..7d7e96ba 100644 --- a/res/values-pt-rBR/strings.xml +++ b/res/values-pt-rBR/strings.xml @@ -306,4 +306,5 @@ %1$s compartilhou \"%2$s\" com você Reinicializar conexão Endereço do servidor + Não há memoria suficiente diff --git a/res/values-sr/strings.xml b/res/values-sr/strings.xml index d7cd3751..0e10fdeb 100644 --- a/res/values-sr/strings.xml +++ b/res/values-sr/strings.xml @@ -306,4 +306,5 @@ %1$s подели „%2$s“ са вама Освежи везу Адреса сервера + Нема довољно меморије diff --git a/res/values/strings.xml b/res/values/strings.xml index c8c1ad71..5b19c75c 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -335,5 +335,6 @@ Refresh connection Server address + Not enough memory diff --git a/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java b/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java index c375f8d7..7825b959 100644 --- a/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java +++ b/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java @@ -22,6 +22,7 @@ package com.owncloud.android.datamodel; import java.io.File; +import java.io.InputStream; import java.lang.ref.WeakReference; import org.apache.commons.httpclient.HttpStatus; @@ -290,9 +291,11 @@ public class ThumbnailsCacheManager { GetMethod get = new GetMethod(uri); status = mClient.executeMethod(get); if (status == HttpStatus.SC_OK) { - byte[] bytes = get.getResponseBody(); - Bitmap bitmap = BitmapFactory.decodeByteArray(bytes, 0, - bytes.length); +// byte[] bytes = get.getResponseBody(); +// Bitmap bitmap = BitmapFactory.decodeByteArray(bytes, 0, +// bytes.length); + InputStream inputStream = get.getResponseBodyAsStream(); + Bitmap bitmap = BitmapFactory.decodeStream(inputStream); thumbnail = ThumbnailUtils.extractThumbnail(bitmap, px, px); // Add thumbnail to cache diff --git a/src/com/owncloud/android/ui/adapter/FileListListAdapter.java b/src/com/owncloud/android/ui/adapter/FileListListAdapter.java index d4c1c7b2..2c1aa9e9 100644 --- a/src/com/owncloud/android/ui/adapter/FileListListAdapter.java +++ b/src/com/owncloud/android/ui/adapter/FileListListAdapter.java @@ -158,17 +158,22 @@ public class FileListListAdapter extends BaseAdapter implements ListAdapter { viewType = ViewType.GRID_ITEM; } - // Create View - switch (viewType){ - case GRID_IMAGE: - view = inflator.inflate(R.layout.grid_image, null); - break; - case GRID_ITEM: - view = inflator.inflate(R.layout.grid_item, null); - break; - case LIST_ITEM: - view = inflator.inflate(R.layout.list_item, null); - break; + // create view only if differs, otherwise reuse + if (convertView == null || (convertView != null && convertView.getTag() != viewType)) { + switch (viewType) { + case GRID_IMAGE: + view = inflator.inflate(R.layout.grid_image, null); + view.setTag(ViewType.GRID_IMAGE); + break; + case GRID_ITEM: + view = inflator.inflate(R.layout.grid_item, null); + view.setTag(ViewType.GRID_ITEM); + break; + case LIST_ITEM: + view = inflator.inflate(R.layout.list_item, null); + view.setTag(ViewType.LIST_ITEM); + break; + } } view.invalidate(); diff --git a/src/com/owncloud/android/ui/preview/FileDownloadFragment.java b/src/com/owncloud/android/ui/preview/FileDownloadFragment.java index 99a4d444..631a8367 100644 --- a/src/com/owncloud/android/ui/preview/FileDownloadFragment.java +++ b/src/com/owncloud/android/ui/preview/FileDownloadFragment.java @@ -23,18 +23,16 @@ import java.lang.ref.WeakReference; import com.owncloud.android.R; import com.owncloud.android.datamodel.OCFile; -import com.owncloud.android.files.services.FileDownloader.FileDownloaderBinder; import com.owncloud.android.ui.fragment.FileFragment; import android.accounts.Account; import android.os.Bundle; +import android.support.v4.app.Fragment; import android.support.v4.app.FragmentStatePagerAdapter; import android.view.LayoutInflater; import android.view.View; import android.view.View.OnClickListener; import android.view.ViewGroup; -import android.widget.ImageButton; -import android.widget.LinearLayout; import android.widget.ProgressBar; import android.widget.TextView; @@ -50,10 +48,14 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene public static final String EXTRA_FILE = "FILE"; public static final String EXTRA_ACCOUNT = "ACCOUNT"; private static final String EXTRA_ERROR = "ERROR"; + + private static final String ARG_FILE = "FILE"; + private static final String ARG_IGNORE_FIRST = "IGNORE_FIRST"; + private static final String ARG_ACCOUNT = "ACCOUNT" ; private View mView; private Account mAccount; - + public ProgressListener mProgressListener; private boolean mListening; @@ -61,12 +63,39 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene private boolean mIgnoreFirstSavedState; private boolean mError; - + + + /** + * Public factory method to create a new fragment that shows the progress of a file download. + * + * Android strongly recommends keep the empty constructor of fragments as the only public constructor, and + * use {@link #setArguments(Bundle)} to set the needed arguments. + * + * This method hides to client objects the need of doing the construction in two steps. + * + * When 'file' is null creates a dummy layout (useful when a file wasn't tapped before). + * + * @param file An {@link OCFile} to show in the fragment + * @param account An OC account; needed to start downloads + * @param ignoreFirstSavedState Flag to work around an unexpected behaviour of {@link FragmentStatePagerAdapter} + * TODO better solution + */ + public static Fragment newInstance(OCFile file, Account account, boolean ignoreFirstSavedState) { + FileDownloadFragment frag = new FileDownloadFragment(); + Bundle args = new Bundle(); + args.putParcelable(ARG_FILE, file); + args.putParcelable(ARG_ACCOUNT, account); + args.putBoolean(ARG_IGNORE_FIRST, ignoreFirstSavedState); + frag.setArguments(args); + return frag; + } + /** * Creates an empty details fragment. * - * It's necessary to keep a public constructor without parameters; the system uses it when tries to reinstantiate a fragment automatically. + * It's necessary to keep a public constructor without parameters; the system uses it when tries to + * reinstantiate a fragment automatically. */ public FileDownloadFragment() { super(); @@ -76,30 +105,17 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene mIgnoreFirstSavedState = false; mError = false; } - - - /** - * Creates a details fragment. - * - * When 'fileToDetail' or 'ocAccount' are null, creates a dummy layout (to use when a file wasn't tapped before). - * - * @param fileToDetail An {@link OCFile} to show in the fragment - * @param ocAccount An ownCloud account; needed to start downloads - * @param ignoreFirstSavedState Flag to work around an unexpected behaviour of {@link FragmentStatePagerAdapter}; TODO better solution - */ - public FileDownloadFragment(OCFile fileToDetail, Account ocAccount, boolean ignoreFirstSavedState) { - super(fileToDetail); - mAccount = ocAccount; - mProgressListener = null; - mListening = false; - mIgnoreFirstSavedState = ignoreFirstSavedState; - mError = false; - } - - + + @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); + Bundle args = getArguments(); + setFile((OCFile)args.getParcelable(ARG_FILE)); + // TODO better in super, but needs to check ALL the class extending FileFragment; not right now + + mIgnoreFirstSavedState = args.getBoolean(ARG_IGNORE_FIRST); + mAccount = args.getParcelable(ARG_ACCOUNT); } @@ -125,9 +141,9 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene ProgressBar progressBar = (ProgressBar)mView.findViewById(R.id.progressBar); mProgressListener = new ProgressListener(progressBar); - ((ImageButton)mView.findViewById(R.id.cancelBtn)).setOnClickListener(this); + (mView.findViewById(R.id.cancelBtn)).setOnClickListener(this); - ((LinearLayout)mView.findViewById(R.id.fileDownloadLL)).setOnClickListener(new OnClickListener() { + (mView.findViewById(R.id.fileDownloadLL)).setOnClickListener(new OnClickListener() { @Override public void onClick(View v) { ((PreviewImageActivity) getActivity()).toggleFullScreen(); @@ -206,31 +222,6 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene /** - * Updates the view depending upon the state of the downloading file. - * - * @param transferring When true, the view must be updated assuming that the holded file is - * downloading, no matter what the downloaderBinder says. - */ - /* - public void updateView(boolean transferring) { - // configure UI for depending upon local state of the file - // TODO remove - if (transferring || getFile().isDownloading()) { - setButtonsForTransferring(); - - } else if (getFile().isDown()) { - - setButtonsForDown(); - - } else { - setButtonsForRemote(); - } - getView().invalidate(); - - } - */ - - /** * Enables or disables buttons for a file being downloaded */ private void setButtonsForTransferring() { @@ -289,7 +280,9 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene public void listenForTransferProgress() { if (mProgressListener != null && !mListening) { if (mContainerActivity.getFileDownloaderBinder() != null) { - mContainerActivity.getFileDownloaderBinder().addDatatransferProgressListener(mProgressListener, mAccount, getFile()); + mContainerActivity.getFileDownloaderBinder().addDatatransferProgressListener( + mProgressListener, mAccount, getFile() + ); mListening = true; setButtonsForTransferring(); } @@ -300,13 +293,15 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene public void leaveTransferProgress() { if (mProgressListener != null) { if (mContainerActivity.getFileDownloaderBinder() != null) { - mContainerActivity.getFileDownloaderBinder().removeDatatransferProgressListener(mProgressListener, mAccount, getFile()); + mContainerActivity.getFileDownloaderBinder().removeDatatransferProgressListener( + mProgressListener, mAccount, getFile() + ); mListening = false; } } } - + /** * Helper class responsible for updating the progress bar shown for file uploading or downloading */ @@ -319,7 +314,9 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene } @Override - public void onTransferProgress(long progressRate, long totalTransferredSoFar, long totalToTransfer, String filename) { + public void onTransferProgress( + long progressRate, long totalTransferredSoFar, long totalToTransfer, String filename + ) { int percent = (int)(100.0*((double)totalTransferredSoFar)/((double)totalToTransfer)); if (percent != mLastPercent) { ProgressBar pb = mProgressBar.get(); diff --git a/src/com/owncloud/android/ui/preview/ImageViewCustom.java b/src/com/owncloud/android/ui/preview/ImageViewCustom.java index ad851404..69182d6e 100644 --- a/src/com/owncloud/android/ui/preview/ImageViewCustom.java +++ b/src/com/owncloud/android/ui/preview/ImageViewCustom.java @@ -12,10 +12,16 @@ import android.widget.ImageView; import com.owncloud.android.lib.common.utils.Log_OC; public class ImageViewCustom extends ImageView { - + + private static final String TAG = ImageViewCustom.class.getSimpleName(); + private static final boolean IS_ICS_OR_HIGHER = Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH; - - private Bitmap mBitmap; + private static final boolean IS_VERSION_BUGGY_ON_RECYCLES = + Build.VERSION.SDK_INT == Build.VERSION_CODES.JELLY_BEAN_MR1 || + Build.VERSION.SDK_INT == Build.VERSION_CODES.JELLY_BEAN_MR2; + + private int mBitmapHeight; + private int mBitmapWidth; public ImageViewCustom(Context context) { @@ -34,9 +40,13 @@ public class ImageViewCustom extends ImageView { @Override protected void onDraw(Canvas canvas) { - if(IS_ICS_OR_HIGHER && checkIfMaximumBitmapExceed(canvas)) { - // Set layer type to software one for avoiding exceed - // and problems in visualization + if(IS_ICS_OR_HIGHER && checkIfMaximumBitmapExceed(canvas) || IS_VERSION_BUGGY_ON_RECYCLES ) { + // Software type is set with two targets: + // 1. prevent that bitmaps larger than maximum textures allowed are shown as black views in devices + // with LAYER_TYPE_HARDWARE enabled by default; + // 2. grant that bitmaps are correctly dellocated from memory in versions suffering the bug fixed in + // https://android.googlesource.com/platform/frameworks/base/+/034de6b1ec561797a2422314e6ef03e3cd3e08e0; + // setLayerType(View.LAYER_TYPE_SOFTWARE, null); } @@ -45,26 +55,29 @@ public class ImageViewCustom extends ImageView { /** * Checks if current bitmaps exceed the maximum OpenGL texture size limit - * @param bitmap - * @return boolean + * @param canvas Canvas where the view will be drawn into. + * @return boolean True means that the bitmap is too big for the canvas. */ @SuppressLint("NewApi") private boolean checkIfMaximumBitmapExceed(Canvas canvas) { - Log_OC.d("OC", "Canvas maximum: " + canvas.getMaximumBitmapWidth() + " - " + canvas.getMaximumBitmapHeight()); - if (mBitmap!= null && (mBitmap.getWidth() > canvas.getMaximumBitmapWidth() - || mBitmap.getHeight() > canvas.getMaximumBitmapHeight())) { + Log_OC.v(TAG, "Canvas maximum: " + canvas.getMaximumBitmapWidth() + " - " + canvas.getMaximumBitmapHeight()); + if (mBitmapWidth > canvas.getMaximumBitmapWidth() + || mBitmapHeight > canvas.getMaximumBitmapHeight()) { return true; } return false; } + @Override /** - * Set current bitmap - * @param bitmap + * Keeps the size of the bitmap cached in member variables for faster access in {@link #onDraw(Canvas)} , + * but without keeping another reference to the {@link Bitmap} */ - public void setBitmap (Bitmap bitmap) { - mBitmap = bitmap; + public void setImageBitmap (Bitmap bm) { + mBitmapWidth = bm.getWidth(); + mBitmapHeight = bm.getHeight(); + super.setImageBitmap(bm); } } diff --git a/src/com/owncloud/android/ui/preview/PreviewImageFragment.java b/src/com/owncloud/android/ui/preview/PreviewImageFragment.java index 9d1cd60f..af69a1a1 100644 --- a/src/com/owncloud/android/ui/preview/PreviewImageFragment.java +++ b/src/com/owncloud/android/ui/preview/PreviewImageFragment.java @@ -19,25 +19,16 @@ */ package com.owncloud.android.ui.preview; -import java.io.BufferedInputStream; -import java.io.File; -import java.io.FileInputStream; -import java.io.FilterInputStream; -import java.io.IOException; -import java.io.InputStream; import java.lang.ref.WeakReference; import android.accounts.Account; import android.annotation.SuppressLint; import android.app.Activity; import android.graphics.Bitmap; -import android.graphics.BitmapFactory; -import android.graphics.BitmapFactory.Options; import android.graphics.Point; import android.os.AsyncTask; import android.os.Bundle; import android.support.v4.app.FragmentStatePagerAdapter; -import android.view.Display; import android.view.LayoutInflater; import android.view.View; import android.view.View.OnClickListener; @@ -57,6 +48,7 @@ import com.owncloud.android.ui.dialog.ConfirmationDialogFragment; import com.owncloud.android.ui.dialog.RemoveFileDialogFragment; import com.owncloud.android.ui.fragment.FileFragment; import com.owncloud.android.utils.BitmapUtils; +import com.owncloud.android.utils.DisplayUtils; import third_parties.michaelOrtiz.TouchImageViewCustom; @@ -64,17 +56,17 @@ import third_parties.michaelOrtiz.TouchImageViewCustom; /** * This fragment shows a preview of a downloaded image. * - * Trying to get an instance with NULL {@link OCFile} or ownCloud {@link Account} values will produce an {@link IllegalStateException}. + * Trying to get an instance with a NULL {@link OCFile} will produce an {@link IllegalStateException}. * * If the {@link OCFile} passed is not downloaded, an {@link IllegalStateException} is generated on instantiation too. */ public class PreviewImageFragment extends FileFragment { public static final String EXTRA_FILE = "FILE"; - public static final String EXTRA_ACCOUNT = "ACCOUNT"; - private View mView; - private Account mAccount; + private static final String ARG_FILE = "FILE"; + private static final String ARG_IGNORE_FIRST = "IGNORE_FIRST"; + private TouchImageViewCustom mImageView; private TextView mMessageView; private ProgressBar mProgressWheel; @@ -87,33 +79,39 @@ public class PreviewImageFragment extends FileFragment { private LoadBitmapTask mLoadBitmapTask = null; - + /** - * Creates a fragment to preview an image. - * - * When 'imageFile' or 'ocAccount' are null - * + * Public factory method to create a new fragment that previews an image. + * + * Android strongly recommends keep the empty constructor of fragments as the only public constructor, and + * use {@link #setArguments(Bundle)} to set the needed arguments. + * + * This method hides to client objects the need of doing the construction in two steps. + * * @param imageFile An {@link OCFile} to preview as an image in the fragment - * @param ocAccount An ownCloud account; needed to start downloads - * @param ignoreFirstSavedState Flag to work around an unexpected behaviour of {@link FragmentStatePagerAdapter}; TODO better solution + * @param ignoreFirstSavedState Flag to work around an unexpected behaviour of {@link FragmentStatePagerAdapter} + * ; TODO better solution */ - public PreviewImageFragment(OCFile fileToDetail, Account ocAccount, boolean ignoreFirstSavedState) { - super(fileToDetail); - mAccount = ocAccount; - mIgnoreFirstSavedState = ignoreFirstSavedState; + public static PreviewImageFragment newInstance(OCFile imageFile, boolean ignoreFirstSavedState) { + PreviewImageFragment frag = new PreviewImageFragment(); + Bundle args = new Bundle(); + args.putParcelable(ARG_FILE, imageFile); + args.putBoolean(ARG_IGNORE_FIRST, ignoreFirstSavedState); + frag.setArguments(args); + return frag; } + /** * Creates an empty fragment for image previews. * - * MUST BE KEPT: the system uses it when tries to reinstantiate a fragment automatically (for instance, when the device is turned a aside). + * MUST BE KEPT: the system uses it when tries to reinstantiate a fragment automatically + * (for instance, when the device is turned a aside). * * DO NOT CALL IT: an {@link OCFile} and {@link Account} must be provided for a successful construction */ public PreviewImageFragment() { - super(); - mAccount = null; mIgnoreFirstSavedState = false; } @@ -124,6 +122,11 @@ public class PreviewImageFragment extends FileFragment { @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); + Bundle args = getArguments(); + setFile((OCFile)args.getParcelable(ARG_FILE)); + // TODO better in super, but needs to check ALL the class extending FileFragment; not right now + + mIgnoreFirstSavedState = args.getBoolean(ARG_IGNORE_FIRST); setHasOptionsMenu(true); } @@ -135,8 +138,8 @@ public class PreviewImageFragment extends FileFragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { super.onCreateView(inflater, container, savedInstanceState); - mView = inflater.inflate(R.layout.preview_image_fragment, container, false); - mImageView = (TouchImageViewCustom) mView.findViewById(R.id.image); + View view = inflater.inflate(R.layout.preview_image_fragment, container, false); + mImageView = (TouchImageViewCustom) view.findViewById(R.id.image); mImageView.setVisibility(View.GONE); mImageView.setOnClickListener(new OnClickListener() { @Override @@ -145,11 +148,11 @@ public class PreviewImageFragment extends FileFragment { } }); - mMessageView = (TextView)mView.findViewById(R.id.message); + mMessageView = (TextView)view.findViewById(R.id.message); mMessageView.setVisibility(View.GONE); - mProgressWheel = (ProgressBar)mView.findViewById(R.id.progressWheel); + mProgressWheel = (ProgressBar)view.findViewById(R.id.progressWheel); mProgressWheel.setVisibility(View.VISIBLE); - return mView; + return view; } /** @@ -160,9 +163,8 @@ public class PreviewImageFragment extends FileFragment { super.onActivityCreated(savedInstanceState); if (savedInstanceState != null) { if (!mIgnoreFirstSavedState) { - OCFile file = (OCFile)savedInstanceState.getParcelable(PreviewImageFragment.EXTRA_FILE); + OCFile file = savedInstanceState.getParcelable(PreviewImageFragment.EXTRA_FILE); setFile(file); - mAccount = savedInstanceState.getParcelable(PreviewImageFragment.EXTRA_ACCOUNT); } else { mIgnoreFirstSavedState = false; } @@ -170,9 +172,6 @@ public class PreviewImageFragment extends FileFragment { if (getFile() == null) { throw new IllegalStateException("Instanced with a NULL OCFile"); } - if (mAccount == null) { - throw new IllegalStateException("Instanced with a NULL ownCloud Account"); - } if (!getFile().isDown()) { throw new IllegalStateException("There is no local file to preview"); } @@ -186,7 +185,6 @@ public class PreviewImageFragment extends FileFragment { public void onSaveInstanceState(Bundle outState) { super.onSaveInstanceState(outState); outState.putParcelable(PreviewImageFragment.EXTRA_FILE, getFile()); - outState.putParcelable(PreviewImageFragment.EXTRA_ACCOUNT, mAccount); } @@ -194,20 +192,21 @@ public class PreviewImageFragment extends FileFragment { public void onStart() { super.onStart(); if (getFile() != null) { - mLoadBitmapTask = new LoadBitmapTask(mImageView, mMessageView, mProgressWheel); - mLoadBitmapTask.execute(new String[]{getFile().getStoragePath()}); + mLoadBitmapTask = new LoadBitmapTask(mImageView, mMessageView, mProgressWheel); + //mLoadBitmapTask.execute(new String[]{getFile().getStoragePath()}); + mLoadBitmapTask.execute(getFile().getStoragePath()); } } @Override public void onStop() { - super.onStop(); + Log_OC.d(TAG, "onStop starts"); if (mLoadBitmapTask != null) { mLoadBitmapTask.cancel(true); mLoadBitmapTask = null; } - + super.onStop(); } /** @@ -329,6 +328,9 @@ public class PreviewImageFragment extends FileFragment { if (mBitmap != null) { mBitmap.recycle(); System.gc(); + // putting this in onStop() is just the same; the fragment is always destroyed by + // {@link FragmentStatePagerAdapter} when the fragment in swiped further than the valid offscreen + // distance, and onStop() is never called before than that } super.onDestroy(); } @@ -348,20 +350,22 @@ public class PreviewImageFragment extends FileFragment { /** * Weak reference to the target {@link ImageView} where the bitmap will be loaded into. * - * Using a weak reference will avoid memory leaks if the target ImageView is retired from memory before the load finishes. + * Using a weak reference will avoid memory leaks if the target ImageView is retired from memory before + * the load finishes. */ private final WeakReference mImageViewRef; /** * Weak reference to the target {@link TextView} where error messages will be written. * - * Using a weak reference will avoid memory leaks if the target ImageView is retired from memory before the load finishes. + * Using a weak reference will avoid memory leaks if the target ImageView is retired from memory before the + * load finishes. */ private final WeakReference mMessageViewRef; /** - * Weak reference to the target {@link Progressbar} shown while the load is in progress. + * Weak reference to the target {@link ProgressBar} shown while the load is in progress. * * Using a weak reference will avoid memory leaks if the target ImageView is retired from memory before the load finishes. */ @@ -389,47 +393,47 @@ public class PreviewImageFragment extends FileFragment { @Override protected Bitmap doInBackground(String... params) { Bitmap result = null; - if (params.length != 1) return result; + if (params.length != 1) return null; String storagePath = params[0]; try { - if (isCancelled()) return result; - - File picture = new File(storagePath); - - if (picture != null) { - // Decode file into a bitmap in real size for being able to make zoom on - // the image - result = BitmapFactory.decodeStream(new FlushedInputStream - (new BufferedInputStream(new FileInputStream(picture)))); - } - - if (isCancelled()) return result; - - if (result == null) { - mErrorMessageId = R.string.preview_image_error_unknown_format; - Log_OC.e(TAG, "File could not be loaded as a bitmap: " + storagePath); - } else { - // Rotate image, obeying exif tag. - result = BitmapUtils.rotateImage(result, storagePath); + int maxDownScale = 3; // could be a parameter passed to doInBackground(...) + Point screenSize = DisplayUtils.getScreenSize(getActivity()); + int minWidth = screenSize.x; + int minHeight = screenSize.y; + for (int i = 0; i < maxDownScale && result == null; i++) { + if (isCancelled()) return null; + try { + result = BitmapUtils.decodeSampledBitmapFromFile(storagePath, minWidth, minHeight); + + if (isCancelled()) return result; + + if (result == null) { + mErrorMessageId = R.string.preview_image_error_unknown_format; + Log_OC.e(TAG, "File could not be loaded as a bitmap: " + storagePath); + break; + } else { + // Rotate image, obeying exif tag. + result = BitmapUtils.rotateImage(result, storagePath); + } + + } catch (OutOfMemoryError e) { + mErrorMessageId = R.string.common_error_out_memory; + if (i < maxDownScale - 1) { + Log_OC.w(TAG, "Out of memory rendering file " + storagePath + " ; scaling down"); + minWidth = minWidth / 2; + minHeight = minHeight / 2; + + } else { + Log_OC.w(TAG, "Out of memory rendering file " + storagePath + " ; failing"); + } + if (result != null) { + result.recycle(); + } + result = null; + } } - - } catch (OutOfMemoryError e) { - Log_OC.e(TAG, "Out of memory occured for file " + storagePath, e); - if (isCancelled()) return result; - - // If out of memory error when loading or rotating image, try to load it scaled - result = loadScaledImage(storagePath); - - if (result == null) { - mErrorMessageId = R.string.preview_image_error_unknown_format; - Log_OC.e(TAG, "File could not be loaded as a bitmap: " + storagePath); - } else { - // Rotate scaled image, obeying exif tag - result = BitmapUtils.rotateImage(result, storagePath); - } - } catch (NoSuchFieldError e) { mErrorMessageId = R.string.common_error_unknown; Log_OC.e(TAG, "Error from access to unexisting field despite protection; file " @@ -459,50 +463,46 @@ public class PreviewImageFragment extends FileFragment { } else { showErrorMessage(); } + if (result != null && mBitmap != result) { + // unused bitmap, release it! (just in case) + result.recycle(); + } } @SuppressLint("InlinedApi") private void showLoadedImage(Bitmap result) { - if (mImageViewRef != null) { - final ImageViewCustom imageView = mImageViewRef.get(); - if (imageView != null) { - imageView.setBitmap(result); - imageView.setImageBitmap(result); - imageView.setVisibility(View.VISIBLE); - mBitmap = result; - } // else , silently finish, the fragment was destroyed - } - if (mMessageViewRef != null) { - final TextView messageView = mMessageViewRef.get(); - if (messageView != null) { - messageView.setVisibility(View.GONE); - } // else , silently finish, the fragment was destroyed + final ImageViewCustom imageView = mImageViewRef.get(); + if (imageView != null) { + Log_OC.d(TAG, "Showing image with resolution " + result.getWidth() + "x" + result.getHeight()); + imageView.setImageBitmap(result); + imageView.setVisibility(View.VISIBLE); + mBitmap = result; // needs to be kept for recycling when not useful } + + final TextView messageView = mMessageViewRef.get(); + if (messageView != null) { + messageView.setVisibility(View.GONE); + } // else , silently finish, the fragment was destroyed } private void showErrorMessage() { - if (mImageViewRef != null) { - final ImageView imageView = mImageViewRef.get(); - if (imageView != null) { - // shows the default error icon - imageView.setVisibility(View.VISIBLE); - } // else , silently finish, the fragment was destroyed - } - if (mMessageViewRef != null) { - final TextView messageView = mMessageViewRef.get(); - if (messageView != null) { - messageView.setText(mErrorMessageId); - messageView.setVisibility(View.VISIBLE); - } // else , silently finish, the fragment was destroyed - } + final ImageView imageView = mImageViewRef.get(); + if (imageView != null) { + // shows the default error icon + imageView.setVisibility(View.VISIBLE); + } // else , silently finish, the fragment was destroyed + + final TextView messageView = mMessageViewRef.get(); + if (messageView != null) { + messageView.setText(mErrorMessageId); + messageView.setVisibility(View.VISIBLE); + } // else , silently finish, the fragment was destroyed } private void hideProgressWheel() { - if (mProgressWheelRef != null) { - final ProgressBar progressWheel = mProgressWheelRef.get(); - if (progressWheel != null) { - progressWheel.setVisibility(View.GONE); - } + final ProgressBar progressWheel = mProgressWheelRef.get(); + if (progressWheel != null) { + progressWheel.setVisibility(View.GONE); } } @@ -531,83 +531,4 @@ public class PreviewImageFragment extends FileFragment { return mImageView; } - static class FlushedInputStream extends FilterInputStream { - public FlushedInputStream(InputStream inputStream) { - super(inputStream); - } - - @Override - public long skip(long n) throws IOException { - long totalBytesSkipped = 0L; - while (totalBytesSkipped < n) { - long bytesSkipped = in.skip(n - totalBytesSkipped); - if (bytesSkipped == 0L) { - int byteValue = read(); - if (byteValue < 0) { - break; // we reached EOF - } else { - bytesSkipped = 1; // we read one byte - } - } - totalBytesSkipped += bytesSkipped; - } - return totalBytesSkipped; - } - } - - /** - * Load image scaled - * @param storagePath: path of the image - * @return Bitmap - */ - @SuppressWarnings("deprecation") - private Bitmap loadScaledImage(String storagePath) { - - Log_OC.d(TAG, "Loading image scaled"); - - // set desired options that will affect the size of the bitmap - BitmapFactory.Options options = new Options(); - options.inScaled = true; - options.inPurgeable = true; - if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.GINGERBREAD_MR1) { - options.inPreferQualityOverSpeed = false; - } - if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.HONEYCOMB) { - options.inMutable = false; - } - // make a false load of the bitmap - just to be able to read outWidth, outHeight and outMimeType - options.inJustDecodeBounds = true; - BitmapFactory.decodeFile(storagePath, options); - - int width = options.outWidth; - int height = options.outHeight; - int scale = 1; - - Display display = getActivity().getWindowManager().getDefaultDisplay(); - Point size = new Point(); - int screenWidth; - int screenHeight; - if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.HONEYCOMB_MR2) { - display.getSize(size); - screenWidth = size.x; - screenHeight = size.y; - } else { - screenWidth = display.getWidth(); - screenHeight = display.getHeight(); - } - - if (width > screenWidth) { - // second try to scale down the image , this time depending upon the screen size - scale = (int) Math.floor((float)width / screenWidth); - } - if (height > screenHeight) { - scale = Math.max(scale, (int) Math.floor((float)height / screenHeight)); - } - options.inSampleSize = scale; - - // really load the bitmap - options.inJustDecodeBounds = false; // the next decodeFile call will be real - return BitmapFactory.decodeFile(storagePath, options); - - } } diff --git a/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java b/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java index 14ae34fa..6e7f19d4 100644 --- a/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java +++ b/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java @@ -102,15 +102,17 @@ public class PreviewImagePagerAdapter extends FragmentStatePagerAdapter { OCFile file = mImageFiles.get(i); Fragment fragment = null; if (file.isDown()) { - fragment = new PreviewImageFragment(file, mAccount, mObsoletePositions.contains(Integer.valueOf(i))); + fragment = PreviewImageFragment.newInstance(file, mObsoletePositions.contains(Integer.valueOf(i))); } else if (mDownloadErrors.contains(Integer.valueOf(i))) { - fragment = new FileDownloadFragment(file, mAccount, true); + fragment = FileDownloadFragment.newInstance(file, mAccount, true); ((FileDownloadFragment)fragment).setError(true); mDownloadErrors.remove(Integer.valueOf(i)); } else { - fragment = new FileDownloadFragment(file, mAccount, mObsoletePositions.contains(Integer.valueOf(i))); + fragment = FileDownloadFragment.newInstance( + file, mAccount, mObsoletePositions.contains(Integer.valueOf(i)) + ); } mObsoletePositions.remove(Integer.valueOf(i)); return fragment; diff --git a/src/com/owncloud/android/utils/BitmapUtils.java b/src/com/owncloud/android/utils/BitmapUtils.java index ce7590d5..7b9382e6 100644 --- a/src/com/owncloud/android/utils/BitmapUtils.java +++ b/src/com/owncloud/android/utils/BitmapUtils.java @@ -95,7 +95,9 @@ public class BitmapUtils { if (height > reqHeight || width > reqWidth) { final int halfHeight = height / 2; final int halfWidth = width / 2; - + + // calculates the largest inSampleSize value (for smallest sample) that is a power of 2 and keeps both + // height and width **larger** than the requested height and width. while ((halfHeight / inSampleSize) > reqHeight && (halfWidth / inSampleSize) > reqWidth) { inSampleSize *= 2; diff --git a/src/com/owncloud/android/utils/DisplayUtils.java b/src/com/owncloud/android/utils/DisplayUtils.java index 91dfc47c..7030c87f 100644 --- a/src/com/owncloud/android/utils/DisplayUtils.java +++ b/src/com/owncloud/android/utils/DisplayUtils.java @@ -33,9 +33,12 @@ import java.util.Set; import java.util.Vector; import android.annotation.TargetApi; +import android.app.Activity; import android.content.Context; +import android.graphics.Point; import android.os.Build; import android.text.format.DateUtils; +import android.view.Display; import android.webkit.MimeTypeMap; import com.owncloud.android.MainApp; @@ -350,4 +353,24 @@ public class DisplayUtils { return path; } + + /** + * Gets the screen size in pixels in a backwards compatible way + * + * @param caller Activity calling; needed to get access to the {@link android.view.WindowManager} + * @return Size in pixels of the screen, or default {@link Point} if caller is null + */ + public static Point getScreenSize(Activity caller) { + Point size = new Point(); + if (caller != null) { + Display display = caller.getWindowManager().getDefaultDisplay(); + if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.HONEYCOMB_MR2) { + display.getSize(size); + } else { + size.set(display.getWidth(), display.getHeight()); + } + } + return size; + } + }