From: David A. Velasco Date: Thu, 11 Oct 2012 09:33:13 +0000 (+0200) Subject: Fixing NULL pointer in execution without accounts created X-Git-Tag: oc-android-1.4.3~155^2 X-Git-Url: http://git.linex4red.de/pub/Android/ownCloud.git/commitdiff_plain/7fead3cb22a70f8b2bb23a7e981c5ee3708dd523?hp=-c Fixing NULL pointer in execution without accounts created --- 7fead3cb22a70f8b2bb23a7e981c5ee3708dd523 diff --git a/src/com/owncloud/android/ui/activity/FileDisplayActivity.java b/src/com/owncloud/android/ui/activity/FileDisplayActivity.java index 0072b813..3d8f22cf 100644 --- a/src/com/owncloud/android/ui/activity/FileDisplayActivity.java +++ b/src/com/owncloud/android/ui/activity/FileDisplayActivity.java @@ -941,13 +941,13 @@ public class FileDisplayActivity extends SherlockFragmentActivity implements public void onServiceConnected(ComponentName className, IBinder service) { mDownloaderBinder = (FileDownloaderBinder) service; // a new chance to get the mDownloadBinder through getDownloadBinder() - THIS IS A MESS - mFileList.listDirectory(); + if (mFileList != null) + mFileList.listDirectory(); if (mDualPane) { FileDetailFragment fragment = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG); if (fragment != null) fragment.updateFileDetails(); } - } @Override diff --git a/src/com/owncloud/android/ui/fragment/OCFileListFragment.java b/src/com/owncloud/android/ui/fragment/OCFileListFragment.java index a65e2d7c..4f6e66bd 100644 --- a/src/com/owncloud/android/ui/fragment/OCFileListFragment.java +++ b/src/com/owncloud/android/ui/fragment/OCFileListFragment.java @@ -172,28 +172,30 @@ public class OCFileListFragment extends FragmentListView { */ public void listDirectory(OCFile directory) { DataStorageManager storageManager = mContainerActivity.getStorageManager(); + if (storageManager != null) { - // Check input parameters for null - if(directory == null){ - if(mFile != null){ - directory = mFile; - } else { - directory = storageManager.getFileByPath("/"); - if (directory == null) return; // no files, wait for sync + // Check input parameters for null + if(directory == null){ + if(mFile != null){ + directory = mFile; + } else { + directory = storageManager.getFileByPath("/"); + if (directory == null) return; // no files, wait for sync + } } - } - // If that's not a directory -> List its parent - if(!directory.isDirectory()){ - Log.w(TAG, "You see, that is not a directory -> " + directory.toString()); - directory = storageManager.getFileById(directory.getParentId()); - } + // If that's not a directory -> List its parent + if(!directory.isDirectory()){ + Log.w(TAG, "You see, that is not a directory -> " + directory.toString()); + directory = storageManager.getFileById(directory.getParentId()); + } - mFile = directory; - mAdapter.swapDirectory(mFile); - mList.setSelectionFromTop(0, 0); - mList.invalidate(); + mFile = directory; + mAdapter.swapDirectory(mFile); + mList.setSelectionFromTop(0, 0); + mList.invalidate(); + } }