making callback to context not view
authorBartek Przybylski <bart.p.pl@gmail.com>
Tue, 1 May 2012 22:04:17 +0000 (00:04 +0200)
committerBartek Przybylski <bart.p.pl@gmail.com>
Tue, 1 May 2012 22:04:17 +0000 (00:04 +0200)
res/layout/account_setup.xml
src/eu/alefzero/owncloud/ui/activity/AuthenticatorActivity.java
src/eu/alefzero/owncloud/widgets/ActionEditText.java

index 3a9cb4e..6b1bd1c 100644 (file)
 \r
                 </eu.alefzero.owncloud.widgets.ActionEditText>\r
             </TableRow>\r
-            <TableRow android:id="@+id/tableRow5"\r
-                android:layout_width="fill_parent"\r
-                android:layout_height="wrap_content"\r
-                android:gravity="center_horizontal"\r
-                android:weightSum="1.0">\r
-                \r
-                <CheckBox\r
-                                       android:id="@+id/show_password"\r
-                                       android:layout_width="fill_parent"\r
-                                       android:layout_height="wrap_content"\r
-                                       android:layout_weight=".75"\r
-                                       android:hint="@string/setup_hint_show_password"\r
-                                       android:textColor="@android:color/black"\r
-                                       android:onClick="onCheckboxClick"/>\r
-            </TableRow>\r
-            <TableRow android:id="@+id/tableRow6"\r
-                android:layout_width="fill_parent"\r
-                android:layout_height="wrap_content"\r
-                android:gravity="center_horizontal"\r
-                android:weightSum="1.0">\r
-                \r
-                <CheckBox\r
-          android:id="@+id/use_ssl"\r
-          android:layout_width="fill_parent"\r
-          android:layout_height="wrap_content"\r
-          android:layout_weight=".75"\r
-          android:hint="@string/use_ssl"\r
-          android:textColor="@android:color/black"\r
-          android:onClick="onCheckboxClick"/>\r
-            </TableRow>\r
         </TableLayout>\r
 \r
         <LinearLayout\r
index b6c9dda..f1d45b4 100644 (file)
@@ -225,29 +225,15 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity {
                 AuthenticatorActivity.this);\r
     }\r
     \r
-    /**\r
-     * Handles the show password checkbox\r
-     * @author robstar\r
-     * @author aqu\r
-     * @param view\r
-     */\r
-    public void onCheckboxClick(View view) {\r
-      switch (view.getId()) {\r
-        case R.id.show_password:\r
-          TextView password_text = (TextView) findViewById(R.id.account_password);\r
-          \r
-          if(((CheckBox)view).isChecked()) {\r
-            password_text.setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD);\r
-          } else {\r
-            password_text.setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_PASSWORD);\r
-          }\r
-        break;\r
-        case R.id.use_ssl:\r
-          mUseSSLConnection = ((CheckBox)view).isChecked();\r
-        break;\r
-        default:\r
-          Log.d("AuthActivity", "Clicked invalid view with id: " + view.getId());\r
+    public void sslBadgeClick(View view, String val) {\r
+      mUseSSLConnection = ((TextView)view).getText().equals("SSL");\r
+    }\r
+    \r
+    public void passwordBadgeClick(View view, String val) {\r
+      if(val.equals("Hide")) {\r
+        ((TextView)view).setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD);\r
+      } else {\r
+        ((TextView)view).setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_PASSWORD);\r
       }\r
-       \r
     }\r
 }\r
index adc1845..b0d550d 100644 (file)
@@ -86,23 +86,22 @@ public class ActionEditText extends EditText {
           paramtypes[1] = String.class;
           Method method;
           try {
-            method = this.getClass().getMethod(badgeClickCallback, paramtypes);
-            method.invoke(this, this, s);
+
+            method = getContext().getClass().getMethod(badgeClickCallback, paramtypes);
+            method.invoke(getContext(), this, s);
+
           } catch (NoSuchMethodException e) {
             e.printStackTrace();
           } catch (IllegalArgumentException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
           } catch (IllegalAccessException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
           } catch (InvocationTargetException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
           }
           
+          invalidate();
         }
-        invalidate();
       }
     }
     return r;
@@ -117,17 +116,4 @@ public class ActionEditText extends EditText {
     badgeClickCallback = a.getString(R.styleable.ActionEditText_onBadgeClick);
   }
   
-  public void sslBadgeClick(View view, String val) {
-    Log.d("ASD", val);
-  }
-  
-  public void passwordBadgeClick(View view, String val) {
-    
-    if(val.equals("Hide")) {
-      ((TextView)view).setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD);
-    } else {
-      ((TextView)view).setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_PASSWORD);
-    }
-  }
-  
 }