Merge branch 'bug_hunting' into feature_previews
authorDavid A. Velasco <dvelasco@solidgear.es>
Tue, 9 Apr 2013 10:54:24 +0000 (12:54 +0200)
committerDavid A. Velasco <dvelasco@solidgear.es>
Tue, 9 Apr 2013 10:54:24 +0000 (12:54 +0200)
1  2 
src/com/owncloud/android/ui/activity/FileDisplayActivity.java

@@@ -4,7 -4,7 +4,7 @@@
   *\r
   *   This program is free software: you can redistribute it and/or modify\r
   *   it under the terms of the GNU General Public License as published by\r
 - *   the Free Software Foundation, either version 2 of the License, or\r
 + *   the Free Software Foundation, either version 3 of the License, or\r
   *   (at your option) any later version.\r
   *\r
   *   This program is distributed in the hope that it will be useful,\r
@@@ -49,7 -49,6 +49,7 @@@ import android.os.Handler
  import android.os.IBinder;\r
  import android.preference.PreferenceManager;\r
  import android.provider.MediaStore;\r
 +import android.support.v4.app.Fragment;\r
  import android.support.v4.app.FragmentTransaction;\r
  import android.util.Log;\r
  import android.view.View;\r
@@@ -91,11 -90,7 +91,11 @@@ import com.owncloud.android.ui.dialog.S
  import com.owncloud.android.ui.dialog.EditNameDialog.EditNameDialogListener;\r
  import com.owncloud.android.ui.dialog.SslValidatorDialog.OnSslValidatorListener;\r
  import com.owncloud.android.ui.fragment.FileDetailFragment;\r
 +import com.owncloud.android.ui.fragment.FileFragment;\r
  import com.owncloud.android.ui.fragment.OCFileListFragment;\r
 +import com.owncloud.android.ui.preview.PreviewImageActivity;\r
 +import com.owncloud.android.ui.preview.PreviewImageFragment;\r
 +import com.owncloud.android.ui.preview.PreviewMediaFragment;\r
  \r
  import com.owncloud.android.R;\r
  import eu.alefzero.webdav.WebdavClient;\r
   * Displays, what files the user has available in his ownCloud.\r
   * \r
   * @author Bartek Przybylski\r
 - * \r
 + * @author David A. Velasco\r
   */\r
  \r
  public class FileDisplayActivity extends SherlockFragmentActivity implements\r
      private OCFileListFragment mFileList;\r
      \r
      private boolean mDualPane;\r
+     private boolean mBackFromCreatingFirstAccount;\r
      \r
      private static final int DIALOG_SETUP_ACCOUNT = 0;\r
      private static final int DIALOG_CREATE_DIR = 1;\r
      \r
      private static final String TAG = "FileDisplayActivity";\r
  \r
 -    private static int[] mMenuIdentifiersToPatch = {R.id.about_app};\r
 +    private static int[] mMenuIdentifiersToPatch = {R.id.action_about_app};\r
 +    \r
 +    private OCFile mWaitingToPreview;\r
 +    private Handler mHandler;\r
 +\r
      \r
      @Override\r
      public void onCreate(Bundle savedInstanceState) {\r
          if(savedInstanceState != null) {\r
              // TODO - test if savedInstanceState should take precedence over file in the intent ALWAYS (now), NEVER, or SOME TIMES\r
              mCurrentDir = savedInstanceState.getParcelable(FileDetailFragment.EXTRA_FILE);\r
 +            mWaitingToPreview = (OCFile) savedInstanceState.getParcelable(FileDetailActivity.KEY_WAITING_TO_PREVIEW);\r
 +\r
 +        } else {\r
 +            mWaitingToPreview = null;\r
          }\r
          \r
          if (!AccountUtils.accountsAreSetup(this)) {\r
          mDualPane = (findViewById(R.id.file_details_container) != null);\r
          if (mDualPane) {\r
              initFileDetailsInDualPane();\r
 +        } else {\r
 +            // quick patchES to fix problem in turn from landscape to portrait, when a file is selected in the right pane\r
 +            // TODO serious refactorization in activities and fragments providing file browsing and handling \r
 +            if (mCurrentFile != null) {\r
 +                onFileClick(mCurrentFile);\r
 +                mCurrentFile = null;\r
 +            }\r
 +            Fragment rightPanel = getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +            if (rightPanel != null) {\r
 +                FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 +                transaction.remove(rightPanel);\r
 +                transaction.commit();\r
 +            }\r
          }\r
              \r
          // Action bar setup\r
          \r
          // show changelog, if needed\r
          //showChangeLog();\r
+         mBackFromCreatingFirstAccount = false;\r
          \r
          Log.d(getClass().toString(), "onCreate() end");\r
      }\r
          startActivity(intent);  // the new activity won't be created until this.onStart() and this.onResume() are finished;\r
      }\r
  \r
 -\r
 +    \r
      /**\r
       *  Load of state dependent of the existence of an ownCloud account\r
       */\r
          if (mDualPane && getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG) == null) {\r
              FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
              if (mCurrentFile != null) {\r
 -                transaction.replace(R.id.file_details_container, new FileDetailFragment(mCurrentFile, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG); // empty FileDetailFragment\r
 +                if (PreviewMediaFragment.canBePreviewed(mCurrentFile)) {\r
 +                    if (mCurrentFile.isDown()) {\r
 +                        transaction.replace(R.id.file_details_container, new PreviewMediaFragment(mCurrentFile, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +                    } else {\r
 +                        transaction.replace(R.id.file_details_container, new FileDetailFragment(mCurrentFile, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +                        mWaitingToPreview = mCurrentFile;\r
 +                    }\r
 +                } else {\r
 +                    transaction.replace(R.id.file_details_container, new FileDetailFragment(mCurrentFile, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +                }\r
                  mCurrentFile = null;\r
 +                \r
              } else {\r
                  transaction.replace(R.id.file_details_container, new FileDetailFragment(null, null), FileDetailFragment.FTAG); // empty FileDetailFragment\r
              }\r
      @Override\r
      public boolean onCreateOptionsMenu(Menu menu) {\r
          MenuInflater inflater = getSherlock().getMenuInflater();\r
 -            inflater.inflate(R.menu.menu, menu);\r
 +            inflater.inflate(R.menu.main_menu, menu);\r
              \r
              patchHiddenAccents(menu);\r
              \r
      public boolean onOptionsItemSelected(MenuItem item) {\r
          boolean retval = true;\r
          switch (item.getItemId()) {\r
 -            case R.id.createDirectoryItem: {\r
 -                //showDialog(DIALOG_CREATE_DIR);\r
 +            case R.id.action_create_dir: {\r
                  EditNameDialog dialog = EditNameDialog.newInstance(getString(R.string.uploader_info_dirname), "", this);\r
                  dialog.show(getSupportFragmentManager(), "createdirdialog");\r
 +                break;\r
              }\r
 -            case R.id.startSync: {\r
 +            case R.id.action_sync_account: {\r
                  startSynchronization();\r
                  break;\r
              }\r
                  startActivity(settingsIntent);\r
                  break;\r
              }\r
 -            case R.id.about_app : {\r
 +            case R.id.action_about_app: {\r
                  showDialog(DIALOG_ABOUT_APP);\r
                  break;\r
              }\r
          \r
          if (mDualPane) {\r
              // Resets the FileDetailsFragment on Tablets so that it always displays\r
 -            FileDetailFragment fileDetails = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -            if (fileDetails != null && !fileDetails.isEmpty()) {\r
 +            Fragment fileFragment = getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +            if (fileFragment != null && (fileFragment instanceof PreviewMediaFragment || !((FileDetailFragment) fileFragment).isEmpty())) {\r
                  FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 -                transaction.remove(fileDetails);\r
 -                transaction.add(R.id.file_details_container, new FileDetailFragment(null, null), FileDetailFragment.FTAG);\r
 +                transaction.replace(R.id.file_details_container, new FileDetailFragment(null, null), FileDetailFragment.FTAG); // empty FileDetailFragment                \r
                  transaction.commit();\r
              }\r
          }\r
          super.onSaveInstanceState(outState);\r
          outState.putParcelable(FileDetailFragment.EXTRA_FILE, mCurrentDir);\r
          if (mDualPane) {\r
 -            FileDetailFragment fragment = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +            FileFragment fragment = (FileFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
              if (fragment != null) {\r
 -                OCFile file = fragment.getDisplayedFile();\r
 +                OCFile file = fragment.getFile();\r
                  if (file != null) {\r
                      outState.putParcelable(FileDetailFragment.EXTRA_FILE, file);\r
                  }\r
              }\r
          }\r
 +        outState.putParcelable(FileDetailActivity.KEY_WAITING_TO_PREVIEW, mWaitingToPreview);\r
          Log.d(getClass().toString(), "onSaveInstanceState() end");\r
      }\r
  \r
      @Override\r
 -    protected void onResume() {\r
 +    public void onResume() {\r
          Log.d(getClass().toString(), "onResume() start");\r
          super.onResume();\r
  \r
                  if (mDualPane) {\r
                      initFileDetailsInDualPane();\r
                  }\r
+                 mBackFromCreatingFirstAccount = true;\r
              }\r
              \r
              // Listen for sync messages\r
              registerReceiver(mUploadFinishReceiver, uploadIntentFilter);\r
              \r
              // Listen for download messages\r
 -            IntentFilter downloadIntentFilter = new IntentFilter(FileDownloader.DOWNLOAD_FINISH_MESSAGE);\r
 +            IntentFilter downloadIntentFilter = new IntentFilter(FileDownloader.DOWNLOAD_ADDED_MESSAGE);\r
 +            downloadIntentFilter.addAction(FileDownloader.DOWNLOAD_FINISH_MESSAGE);\r
              mDownloadFinishReceiver = new DownloadFinishReceiver();\r
              registerReceiver(mDownloadFinishReceiver, downloadIntentFilter);\r
          \r
  \r
      \r
      @Override\r
 -    protected void onPause() {\r
 +    public void onPause() {\r
          Log.d(getClass().toString(), "onPause() start");\r
          super.onPause();\r
          if (mSyncBroadcastReceiver != null) {\r
              break;\r
          }\r
          case DIALOG_CHOOSE_UPLOAD_SOURCE: {\r
 -            final String [] items = {   getString(R.string.actionbar_upload_files), \r
 -                                        getString(R.string.actionbar_upload_from_apps) }; \r
 +            \r
 +            String[] items = null;\r
 +            \r
 +            String[] allTheItems = { getString(R.string.actionbar_upload_files),\r
 +                                     getString(R.string.actionbar_upload_from_apps),\r
 +                                     getString(R.string.actionbar_failed_instant_upload) };\r
 +            \r
 +            String[] commonItems = { getString(R.string.actionbar_upload_files),\r
 +                                     getString(R.string.actionbar_upload_from_apps) };\r
 +            \r
 +            if (InstantUploadActivity.IS_ENABLED)\r
 +                items = allTheItems;\r
 +            else \r
 +                items = commonItems;\r
 +            \r
              builder = new AlertDialog.Builder(this);\r
              builder.setTitle(R.string.actionbar_upload);\r
              builder.setItems(items, new DialogInterface.OnClickListener() {\r
                  public void onClick(DialogInterface dialog, int item) {\r
                      if (item == 0) {\r
 -                        //if (!mDualPane) { \r
 -                            Intent action = new Intent(FileDisplayActivity.this, UploadFilesActivity.class);\r
 -                            action.putExtra(UploadFilesActivity.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(FileDisplayActivity.this));\r
 -                            startActivityForResult(action, ACTION_SELECT_MULTIPLE_FILES);\r
 -                        //} else {\r
 -                            // TODO create and handle new fragment LocalFileListFragment\r
 -                        //}\r
 +                        // if (!mDualPane) {\r
 +                        Intent action = new Intent(FileDisplayActivity.this, UploadFilesActivity.class);\r
 +                        action.putExtra(UploadFilesActivity.EXTRA_ACCOUNT,\r
 +                                AccountUtils.getCurrentOwnCloudAccount(FileDisplayActivity.this));\r
 +                        startActivityForResult(action, ACTION_SELECT_MULTIPLE_FILES);\r
 +                        // } else {\r
 +                        // TODO create and handle new fragment\r
 +                        // LocalFileListFragment\r
 +                        // }\r
                      } else if (item == 1) {\r
                          Intent action = new Intent(Intent.ACTION_GET_CONTENT);\r
 -                        action = action.setType("*/*")\r
 -                                .addCategory(Intent.CATEGORY_OPENABLE);\r
 -                        startActivityForResult(\r
 -                                Intent.createChooser(action, getString(R.string.upload_chooser_title)),\r
 +                        action = action.setType("*/*").addCategory(Intent.CATEGORY_OPENABLE);\r
 +                        startActivityForResult(Intent.createChooser(action, getString(R.string.upload_chooser_title)),\r
                                  ACTION_SELECT_CONTENT_FROM_APPS);\r
 +                    } else if (item == 2 && InstantUploadActivity.IS_ENABLED) {\r
 +                        Account account = AccountUtils.getCurrentOwnCloudAccount(FileDisplayActivity.this);\r
 +                        Intent action = new Intent(FileDisplayActivity.this, InstantUploadActivity.class);\r
 +                        action.putExtra(FileUploader.KEY_ACCOUNT, account);\r
 +                        startActivity(action);\r
                      }\r
                  }\r
              });\r
                  }\r
                  \r
                  setSupportProgressBarIndeterminateVisibility(inProgress);\r
+                 if (mBackFromCreatingFirstAccount) {\r
+                     // awful patch to fix problem with visibility of progress circle with the first refresh of the first account\r
+                     // TODO - kill this Activity when the first account has to be created instead of stack the account creation on it\r
+                     getSupportActionBar().hide();\r
+                     getSupportActionBar().show();\r
+                     mBackFromCreatingFirstAccount = false;\r
+                 }\r
                  removeStickyBroadcast(intent);\r
                  \r
              }\r
      \r
      \r
      /**\r
 -     * Once the file download has finished -> update view\r
 +     * Class waiting for broadcast events from the {@link FielDownloader} service.\r
 +     * \r
 +     * Updates the UI when a download is started or finished, provided that it is relevant for the\r
 +     * current folder.\r
       */\r
      private class DownloadFinishReceiver extends BroadcastReceiver {\r
          @Override\r
          public void onReceive(Context context, Intent intent) {\r
 +            boolean sameAccount = isSameAccount(context, intent);\r
              String downloadedRemotePath = intent.getStringExtra(FileDownloader.EXTRA_REMOTE_PATH);\r
 -            String accountName = intent.getStringExtra(FileDownloader.ACCOUNT_NAME);\r
 -            boolean sameAccount = accountName.equals(AccountUtils.getCurrentOwnCloudAccount(context).name);\r
 -            boolean isDescendant = (mCurrentDir != null) && (downloadedRemotePath != null) && (downloadedRemotePath.startsWith(mCurrentDir.getRemotePath()));\r
 +            boolean isDescendant = isDescendant(downloadedRemotePath);\r
 +            \r
              if (sameAccount && isDescendant) {\r
 -                OCFileListFragment fileListFragment = (OCFileListFragment) getSupportFragmentManager().findFragmentById(R.id.fileList);\r
 -                if (fileListFragment != null) { \r
 -                    fileListFragment.listDirectory();\r
 +                updateLeftPanel();\r
 +                if (mDualPane) {\r
 +                    updateRightPanel(intent.getAction(), downloadedRemotePath, intent.getBooleanExtra(FileDownloader.EXTRA_DOWNLOAD_RESULT, false));\r
                  }\r
              }\r
 +            \r
 +            removeStickyBroadcast(intent);\r
 +        }\r
 +\r
 +        private boolean isDescendant(String downloadedRemotePath) {\r
 +            return (mCurrentDir != null && downloadedRemotePath != null && downloadedRemotePath.startsWith(mCurrentDir.getRemotePath()));\r
 +        }\r
 +\r
 +        private boolean isSameAccount(Context context, Intent intent) {\r
 +            String accountName = intent.getStringExtra(FileDownloader.ACCOUNT_NAME);\r
 +            return (accountName != null && accountName.equals(AccountUtils.getCurrentOwnCloudAccount(context).name));\r
          }\r
      }\r
      \r
      \r
 -    \r
 -    \r
 +    protected void updateLeftPanel() {\r
 +        OCFileListFragment fileListFragment = (OCFileListFragment) getSupportFragmentManager().findFragmentById(R.id.fileList);\r
 +        if (fileListFragment != null) { \r
 +            fileListFragment.listDirectory();\r
 +        }\r
 +    }\r
 +\r
 +    protected void updateRightPanel(String downloadEvent, String downloadedRemotePath, boolean success) {\r
 +        Fragment fragment = getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +        boolean waitedPreview = (mWaitingToPreview != null && mWaitingToPreview.getRemotePath().equals(downloadedRemotePath));\r
 +        if (fragment != null && fragment instanceof FileDetailFragment) {\r
 +            FileDetailFragment detailsFragment = (FileDetailFragment) fragment;\r
 +            OCFile fileInFragment = detailsFragment.getFile();\r
 +            if (fileInFragment != null && !downloadedRemotePath.equals(fileInFragment.getRemotePath())) {\r
 +                // the user browsed to other file ; forget the automatic preview \r
 +                mWaitingToPreview = null;\r
 +                \r
 +            } else if (downloadEvent.equals(FileDownloader.DOWNLOAD_ADDED_MESSAGE)) {\r
 +                // grant that the right panel updates the progress bar\r
 +                detailsFragment.listenForTransferProgress();\r
 +                detailsFragment.updateFileDetails(true, false);\r
 +                \r
 +            } else if (downloadEvent.equals(FileDownloader.DOWNLOAD_FINISH_MESSAGE)) {\r
 +                //  update the right panel \r
 +                if (success && waitedPreview) {\r
 +                    mWaitingToPreview = mStorageManager.getFileById(mWaitingToPreview.getFileId());   // update the file from database, for the local storage path\r
 +                    FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 +                    transaction.replace(R.id.file_details_container, new PreviewMediaFragment(mWaitingToPreview, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +                    transaction.commit();\r
 +                    mWaitingToPreview = null;\r
 +                    \r
 +                } else {\r
 +                    detailsFragment.updateFileDetails(false, (success));\r
 +                }\r
 +            }\r
 +        }\r
 +    }\r
 +\r
 +\r
      /**\r
       * {@inheritDoc}\r
       */\r
          return mStorageManager;\r
      }\r
      \r
 -    \r
 +\r
      /**\r
       * {@inheritDoc}\r
       */\r
          \r
          if (mDualPane) {\r
              // Resets the FileDetailsFragment on Tablets so that it always displays\r
 -            FileDetailFragment fileDetails = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -            if (fileDetails != null && !fileDetails.isEmpty()) {\r
 +            Fragment fileFragment = getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +            if (fileFragment != null && (fileFragment instanceof PreviewMediaFragment || !((FileDetailFragment) fileFragment).isEmpty())) {\r
                  FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 -                transaction.remove(fileDetails);\r
 -                transaction.add(R.id.file_details_container, new FileDetailFragment(null, null), FileDetailFragment.FTAG);\r
 +                transaction.replace(R.id.file_details_container, new FileDetailFragment(null, null), FileDetailFragment.FTAG); // empty FileDetailFragment                \r
                  transaction.commit();\r
              }\r
          }\r
       */\r
      @Override\r
      public void onFileClick(OCFile file) {\r
 -        \r
 -        // If we are on a large device -> update fragment\r
 +        if (file != null && PreviewImageFragment.canBePreviewed(file)) {\r
 +            // preview image - it handles the download, if needed\r
 +            startPreviewImage(file);\r
 +            \r
 +        } else if (file != null && PreviewMediaFragment.canBePreviewed(file)) {\r
 +            if (file.isDown()) {\r
 +                // general preview\r
 +                startMediaPreview(file);\r
 +                \r
 +            } else {\r
 +                // automatic download, preview on finish\r
 +                startDownloadForPreview(file);\r
 +                \r
 +            }\r
 +        } else {\r
 +            // details view\r
 +            startDetails(file);\r
 +        }\r
 +    }\r
 +\r
 +    private void startPreviewImage(OCFile file) {\r
 +        Intent showDetailsIntent = new Intent(this, PreviewImageActivity.class);\r
 +        showDetailsIntent.putExtra(FileDetailFragment.EXTRA_FILE, file);\r
 +        showDetailsIntent.putExtra(FileDetailFragment.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +        startActivity(showDetailsIntent);\r
 +    }\r
 +    \r
 +    private void startMediaPreview(OCFile file) {\r
          if (mDualPane) {\r
 -            // buttons in the details view are problematic when trying to reuse an existing fragment; create always a new one solves some of them, BUT no all; downloads are 'dangerous'\r
              FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 -            transaction.replace(R.id.file_details_container, new FileDetailFragment(file, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 -            transaction.setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE);\r
 +            transaction.replace(R.id.file_details_container, new PreviewMediaFragment(file, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
              transaction.commit();\r
              \r
 -        } else {    // small or medium screen device -> new Activity\r
 +        } else {\r
              Intent showDetailsIntent = new Intent(this, FileDetailActivity.class);\r
              showDetailsIntent.putExtra(FileDetailFragment.EXTRA_FILE, file);\r
              showDetailsIntent.putExtra(FileDetailFragment.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(this));\r
          }\r
      }\r
      \r
 +    private void startDownloadForPreview(OCFile file) {\r
 +        if (mDualPane) {\r
 +            FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 +            transaction.replace(R.id.file_details_container, new FileDetailFragment(file, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +            transaction.commit();\r
 +            mWaitingToPreview = file;\r
 +            requestForDownload();\r
 +            \r
 +        } else {\r
 +            Intent showDetailsIntent = new Intent(this, FileDetailActivity.class);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_FILE, file);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +            startActivity(showDetailsIntent);\r
 +        }\r
 +    }\r
 +\r
      \r
 +    private void startDetails(OCFile file) {\r
 +        if (mDualPane && !file.isImage()) {\r
 +            FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 +            transaction.replace(R.id.file_details_container, new FileDetailFragment(file, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG);\r
 +            transaction.commit();\r
 +        } else {\r
 +            Intent showDetailsIntent = new Intent(this, FileDetailActivity.class);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_FILE, file);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +            startActivity(showDetailsIntent);\r
 +        }\r
 +    }\r
 +\r
 +\r
      /**\r
       * {@inheritDoc}\r
       */\r
              if (component.equals(new ComponentName(FileDisplayActivity.this, FileDownloader.class))) {\r
                  Log.d(TAG, "Download service connected");\r
                  mDownloaderBinder = (FileDownloaderBinder) service;\r
 +                if (mWaitingToPreview != null) {\r
 +                    requestForDownload();\r
 +                }\r
 +                \r
              } else if (component.equals(new ComponentName(FileDisplayActivity.this, FileUploader.class))) {\r
                  Log.d(TAG, "Upload service connected");\r
                  mUploaderBinder = (FileUploaderBinder) service;\r
              if (mFileList != null)\r
                  mFileList.listDirectory();\r
              if (mDualPane) {\r
 -                FileDetailFragment fragment = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -                if (fragment != null)\r
 -                    fragment.updateFileDetails(false);\r
 +                Fragment fragment = getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +                if (fragment != null && fragment instanceof FileDetailFragment) {\r
 +                    FileDetailFragment detailFragment = (FileDetailFragment)fragment;\r
 +                    detailFragment.listenForTransferProgress();\r
 +                    detailFragment.updateFileDetails(false, false);\r
 +                }\r
              }\r
          }\r
  \r
              msg.show();\r
              OCFile removedFile = operation.getFile();\r
              if (mDualPane) {\r
 -                FileDetailFragment details = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -                if (details != null && removedFile.equals(details.getDisplayedFile()) ) {\r
 +                FileFragment details = (FileFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +                if (details != null && removedFile.equals(details.getFile())) {\r
                      FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
                      transaction.replace(R.id.file_details_container, new FileDetailFragment(null, null)); // empty FileDetailFragment\r
                      transaction.commit();\r
          OCFile renamedFile = operation.getFile();\r
          if (result.isSuccess()) {\r
              if (mDualPane) {\r
 -                FileDetailFragment details = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -                if (details != null && renamedFile.equals(details.getDisplayedFile()) ) {\r
 -                    details.updateFileDetails(renamedFile, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +                FileFragment details = (FileFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +                if (details != null && details instanceof FileDetailFragment && renamedFile.equals(details.getFile()) ) {\r
 +                    ((FileDetailFragment) details).updateFileDetails(renamedFile, AccountUtils.getCurrentOwnCloudAccount(this));\r
                  }\r
              }\r
              if (mStorageManager.getFileById(renamedFile.getParentId()).equals(mCurrentDir)) {\r
              fileListFragment.listDirectory();\r
          }*/\r
          if (mDualPane) {\r
 -            FileDetailFragment details = (FileDetailFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 -            if (details != null && file.equals(details.getDisplayedFile()) ) {\r
 +            FileFragment details = (FileFragment) getSupportFragmentManager().findFragmentByTag(FileDetailFragment.FTAG);\r
 +            if (details != null && details instanceof FileDetailFragment && file.equals(details.getFile()) ) {\r
                  if (downloading || uploading) {\r
 -                    details.updateFileDetails(file, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +                    ((FileDetailFragment)details).updateFileDetails(file, AccountUtils.getCurrentOwnCloudAccount(this));\r
                  } else {\r
 -                    details.updateFileDetails(downloading || uploading);\r
 +                    ((FileDetailFragment)details).updateFileDetails(false, true);\r
                  }\r
              }\r
          }\r
  \r
  \r
      @Override\r
 +    public void showFragmentWithDetails(OCFile file) {\r
 +        if (mDualPane) {\r
 +            FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();\r
 +            transaction.replace(R.id.file_details_container, new FileDetailFragment(file, AccountUtils.getCurrentOwnCloudAccount(this)), FileDetailFragment.FTAG); \r
 +            transaction.commit();\r
 +            \r
 +        } else {\r
 +            Intent showDetailsIntent = new Intent(this, FileDetailActivity.class);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_FILE, file);\r
 +            showDetailsIntent.putExtra(FileDetailFragment.EXTRA_ACCOUNT, AccountUtils.getCurrentOwnCloudAccount(this));\r
 +            showDetailsIntent.putExtra(FileDetailActivity.EXTRA_MODE, FileDetailActivity.MODE_DETAILS);\r
 +            startActivity(showDetailsIntent);\r
 +        }\r
 +    }\r
 +\r
      public void onDismiss(EditNameDialog dialog) {\r
          //dialog.dismiss();\r
          if (dialog.getResult()) {\r
          }\r
      }\r
  \r
 +    private void requestForDownload() {\r
 +        Account account = AccountUtils.getCurrentOwnCloudAccount(this);\r
 +        if (!mDownloaderBinder.isDownloading(account, mWaitingToPreview)) {\r
 +            Intent i = new Intent(this, FileDownloader.class);\r
 +            i.putExtra(FileDownloader.EXTRA_ACCOUNT, account);\r
 +            i.putExtra(FileDownloader.EXTRA_FILE, mWaitingToPreview);\r
 +            startService(i);\r
 +        }\r
 +    }\r
 +\r
 +    \r
  }\r
 +