AuthenticatorActivity clean up: removed commented code and warnings
authorDavid A. Velasco <dvelasco@solidgear.es>
Wed, 2 Apr 2014 10:46:54 +0000 (12:46 +0200)
committerDavid A. Velasco <dvelasco@solidgear.es>
Wed, 2 Apr 2014 10:46:54 +0000 (12:46 +0200)
res/values/strings.xml
src/com/owncloud/android/authentication/AuthenticatorActivity.java

index 65c0dbc..b171c0b 100644 (file)
        <string name="media_play_pause_description">Play or pause button</string>
        <string name="media_forward_description">Fast forward button</string>
 
+       <string name="auth_getting_authorization">Getting authorization&#8230;</string>
        <string name="auth_trying_to_login">Trying to login&#8230;</string>
        <string name="auth_no_net_conn_title">No network connection</string>
        <string name="auth_nossl_plain_ok_title">Secure connection unavailable.</string>
index fb55c14..ac71a59 100644 (file)
@@ -23,12 +23,9 @@ import java.util.Map;
 \r
 import android.accounts.Account;\r
 import android.accounts.AccountManager;\r
-import android.app.AlertDialog;\r
 import android.app.Dialog;\r
-import android.app.ProgressDialog;\r
 import android.content.ComponentName;\r
 import android.content.Context;\r
-import android.content.DialogInterface;\r
 import android.content.Intent;\r
 import android.content.ServiceConnection;\r
 import android.content.SharedPreferences;\r
@@ -81,6 +78,7 @@ import com.owncloud.android.lib.resources.users.GetRemoteUserNameOperation;
 \r
 import com.owncloud.android.services.OperationsService;\r
 import com.owncloud.android.services.OperationsService.OperationsServiceBinder;\r
+import com.owncloud.android.ui.dialog.IndeterminateProgressDialog;\r
 import com.owncloud.android.ui.dialog.SamlWebViewDialog;\r
 import com.owncloud.android.ui.dialog.SslUntrustedCertDialog;\r
 import com.owncloud.android.ui.dialog.SslUntrustedCertDialog.OnSslUntrustedCertListener;\r
@@ -92,6 +90,7 @@ import com.owncloud.android.lib.resources.status.OwnCloudVersion;
  * \r
  * @author Bartek Przybylski\r
  * @author David A. Velasco\r
+ * @author masensio\r
  */\r
 public class AuthenticatorActivity extends AccountAuthenticatorActivity\r
 implements  OnRemoteOperationListener, OnFocusChangeListener, OnEditorActionListener, \r
@@ -120,23 +119,18 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
     private static final String KEY_AUTH_STATUS_TEXT = "AUTH_STATUS_TEXT";\r
     private static final String KEY_AUTH_STATUS_ICON = "AUTH_STATUS_ICON";\r
     private static final String KEY_REFRESH_BUTTON_ENABLED = "KEY_REFRESH_BUTTON_ENABLED";\r
-    //private static final String KEY_IS_SHARED_SUPPORTED = "KEY_IS_SHARE_SUPPORTED";\r
     private static final String KEY_SERVER_AUTH_METHOD = "KEY_SERVER_AUTH_METHOD";\r
     private static final String KEY_DETECT_AUTH_OP_ID = "KEY_DETECT_AUTH_OP_ID";\r
 \r
-\r
     private static final String AUTH_ON = "on";\r
-    private static final String AUTH_OFF = "off";\r
+    //private static final String AUTH_OFF = "off";\r
     private static final String AUTH_OPTIONAL = "optional";\r
 \r
-    private static final int DIALOG_LOGIN_PROGRESS = 0;\r
-    private static final int DIALOG_CERT_NOT_SAVED = 1;\r
-    private static final int DIALOG_OAUTH2_LOGIN_PROGRESS = 2;\r
-\r
     public static final byte ACTION_CREATE = 0;\r
     public static final byte ACTION_UPDATE_TOKEN = 1;\r
 \r
-    private static final String TAG_SAML_DIALOG = "samlWebViewDialog";\r
+    private static final String SAML_DIALOG_TAG = "SAML_DIALOG";\r
+    private static final String WAIT_DIALOG_TAG = "WAIT_DIALOG";\r
 \r
     private String mHostBaseUrl;                // TODO remove\r
     private OwnCloudVersion mDiscoveredVersion; // TODO remove\r
@@ -153,7 +147,6 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
     private TextView mAuthStatusLayout;\r
 \r
     private final Handler mHandler = new Handler();\r
-    private Thread mOperationThread;\r
     private GetServerInfoOperation mServerInfoOperation;\r
 \r
     private int mExistenceCheckOpId = -1;\r
@@ -598,7 +591,9 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         mNewCapturedUriFromOAuth2Redirection = null;\r
 \r
         /// Showing the dialog with instructions for the user.\r
-        showDialog(DIALOG_OAUTH2_LOGIN_PROGRESS);\r
+        IndeterminateProgressDialog dialog = \r
+                IndeterminateProgressDialog.newInstance(R.string.auth_getting_authorization, true);\r
+        dialog.show(getSupportFragmentManager(), WAIT_DIALOG_TAG);\r
 \r
         /// GET ACCESS TOKEN to the oAuth server\r
         Intent getServerInfoIntent = new Intent();\r
@@ -616,17 +611,6 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
             //Log.wtf(TAG, "getting access token..." );\r
             mOauth2GetAccessTokenOpId = mOperationsServiceBinder.newOperation(getServerInfoIntent);\r
         }\r
-        \r
-        /*\r
-        RemoteOperation operation = new OAuth2GetAccessToken(   getString(R.string.oauth2_client_id), \r
-                getString(R.string.oauth2_redirect_uri),       \r
-                getString(R.string.oauth2_grant_type),\r
-                queryParameters);\r
-        //OwnCloudClient client = OwnCloudClientUtils.createOwnCloudClient(Uri.parse(getString(R.string.oauth2_url_endpoint_access)), getApplicationContext());\r
-        OwnCloudClient client = OwnCloudClientFactory.createOwnCloudClient(Uri.parse(mOAuthTokenEndpointText.getText().toString().trim()), getApplicationContext(), true);\r
-        operation.execute(client, this, mHandler);\r
-        */\r
-        \r
     }\r
 \r
 \r
@@ -754,23 +738,6 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         showViewPasswordButton();\r
     }\r
 \r
-\r
-    /**\r
-     * Cancels the authenticator activity\r
-     * \r
-     * IMPORTANT ENTRY POINT 3: Never underestimate the importance of cancellation\r
-     * \r
-     * This method is bound in the layout/acceoun_setup.xml resource file.\r
-     * \r
-     * @param view      Cancel button\r
-     */\r
-    public void onCancelClick(View view) {\r
-        setResult(RESULT_CANCELED);     // TODO review how is this related to AccountAuthenticator (debugging)\r
-        finish();\r
-    }\r
-\r
-\r
-\r
     /**\r
      * Checks the credentials of the user in the root of the ownCloud server\r
      * before creating a new local account.\r
@@ -819,7 +786,9 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         String password = mPasswordInput.getText().toString();\r
 \r
         /// be gentle with the user\r
-        showDialog(DIALOG_LOGIN_PROGRESS);\r
+        IndeterminateProgressDialog dialog = \r
+                IndeterminateProgressDialog.newInstance(R.string.auth_trying_to_login, true);\r
+        dialog.show(getSupportFragmentManager(), WAIT_DIALOG_TAG);\r
 \r
         /// test credentials accessing the root folder\r
         String remotePath ="";\r
@@ -884,7 +853,9 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         mAuthStatusIcon = R.drawable.progress_small;\r
         mAuthStatusText = R.string.auth_connecting_auth_server;\r
         showAuthStatus();\r
-        showDialog(DIALOG_LOGIN_PROGRESS);\r
+        IndeterminateProgressDialog dialog = \r
+                IndeterminateProgressDialog.newInstance(R.string.auth_trying_to_login, true);\r
+        dialog.show(getSupportFragmentManager(), WAIT_DIALOG_TAG);\r
 \r
         /// get the path to the root folder through WebDAV from the version server\r
         String webdav_path = AccountUtils.getWebdavPath(mDiscoveredVersion, mAuthTokenType);\r
@@ -963,11 +934,7 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
 \r
     private void onSamlBasedFederatedSingleSignOnAuthorizationStart(RemoteOperationResult result) {\r
         mExistenceCheckOpId = -1;\r
-        try {\r
-            dismissDialog(DIALOG_LOGIN_PROGRESS);\r
-        } catch (IllegalArgumentException e) {\r
-            // NOTHING TO DO ; can't find out what situation that leads to the exception in this code, but user logs signal that it happens\r
-        }\r
+        dismissDialog(WAIT_DIALOG_TAG);\r
 
         //if (result.isTemporalRedirection() && result.isIdPRedirection()) {\r
         if (result.isIdPRedirection()) {
@@ -976,7 +943,7 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
 \r
             // Show dialog\r
             mSamlDialog = SamlWebViewDialog.newInstance(url, targetUrl);            \r
-            mSamlDialog.show(getSupportFragmentManager(), TAG_SAML_DIALOG);\r
+            mSamlDialog.show(getSupportFragmentManager(), SAML_DIALOG_TAG);\r
 \r
             mAuthStatusIcon = 0;\r
             mAuthStatusText = 0;\r
@@ -1273,16 +1240,14 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
      */\r
     private void onGetOAuthAccessTokenFinish(RemoteOperationResult result) {\r
         mOauth2GetAccessTokenOpId = -1;\r
-        try {\r
-            dismissDialog(DIALOG_OAUTH2_LOGIN_PROGRESS);\r
-        } catch (IllegalArgumentException e) {\r
-            // NOTHING TO DO ; can't find out what situation that leads to the exception in this code, but user logs signal that it happens\r
-        }\r
+        dismissDialog(WAIT_DIALOG_TAG);\r
 \r
         String webdav_path = AccountUtils.getWebdavPath(mDiscoveredVersion, mAuthTokenType);\r
         if (result.isSuccess() && webdav_path != null) {\r
             /// be gentle with the user\r
-            showDialog(DIALOG_LOGIN_PROGRESS);\r
+            IndeterminateProgressDialog dialog = \r
+                    IndeterminateProgressDialog.newInstance(R.string.auth_trying_to_login, true);\r
+            dialog.show(getSupportFragmentManager(), WAIT_DIALOG_TAG);\r
 \r
             /// time to test the retrieved access token on the ownCloud server\r
             @SuppressWarnings("unchecked")\r
@@ -1314,11 +1279,7 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
      */\r
     private void onAuthorizationCheckFinish(RemoteOperationResult result) {\r
         mExistenceCheckOpId = -1;\r
-        try {\r
-            dismissDialog(DIALOG_LOGIN_PROGRESS);\r
-        } catch (IllegalArgumentException e) {\r
-            // NOTHING TO DO ; can't find out what situation that leads to the exception in this code, but user logs signal that it happens\r
-        }\r
+        dismissDialog(WAIT_DIALOG_TAG);\r
 \r
         if (result.isSuccess()) {\r
             Log_OC.d(TAG, "Successful access - time to save the account");\r
@@ -1477,90 +1438,6 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
 \r
 \r
     /**\r
-     * {@inheritDoc}\r
-     * \r
-     * Necessary to update the contents of the SSL Dialog\r
-     * \r
-     * TODO move to some common place for all possible untrusted SSL failures\r
-     */\r
-    @Override\r
-    protected void onPrepareDialog(int id, Dialog dialog, Bundle args) {\r
-        switch (id) {\r
-        case DIALOG_LOGIN_PROGRESS:\r
-        case DIALOG_CERT_NOT_SAVED:\r
-        case DIALOG_OAUTH2_LOGIN_PROGRESS:\r
-            break;\r
-        default:\r
-            Log_OC.e(TAG, "Incorrect dialog called with id = " + id);\r
-        }\r
-    }\r
-\r
-\r
-    /**\r
-     * {@inheritDoc}\r
-     */\r
-    @Override\r
-    protected Dialog onCreateDialog(int id) {\r
-        Dialog dialog = null;\r
-        switch (id) {\r
-        case DIALOG_LOGIN_PROGRESS: {\r
-            /// simple progress dialog\r
-            ProgressDialog working_dialog = new ProgressDialog(this);\r
-            working_dialog.setMessage(getResources().getString(R.string.auth_trying_to_login));\r
-            working_dialog.setIndeterminate(true);\r
-            working_dialog.setCancelable(true);\r
-            working_dialog\r
-            .setOnCancelListener(new DialogInterface.OnCancelListener() {\r
-                @Override\r
-                public void onCancel(DialogInterface dialog) {\r
-                    /// TODO study if this is enough\r
-                    Log_OC.i(TAG, "Login canceled");\r
-                    if (mOperationThread != null) {\r
-                        mOperationThread.interrupt();\r
-                        finish();\r
-                    }\r
-                }\r
-            });\r
-            dialog = working_dialog;\r
-            break;\r
-        }\r
-        case DIALOG_OAUTH2_LOGIN_PROGRESS: {\r
-            ProgressDialog working_dialog = new ProgressDialog(this);\r
-            working_dialog.setMessage(String.format("Getting authorization")); \r
-            working_dialog.setIndeterminate(true);\r
-            working_dialog.setCancelable(true);\r
-            working_dialog\r
-            .setOnCancelListener(new DialogInterface.OnCancelListener() {\r
-                @Override\r
-                public void onCancel(DialogInterface dialog) {\r
-                    Log_OC.i(TAG, "Login canceled");\r
-                    finish();\r
-                }\r
-            });\r
-            dialog = working_dialog;\r
-            break;\r
-        }\r
-        case DIALOG_CERT_NOT_SAVED: {\r
-            AlertDialog.Builder builder = new AlertDialog.Builder(this);\r
-            builder.setMessage(getResources().getString(R.string.ssl_validator_not_saved));\r
-            builder.setCancelable(false);\r
-            builder.setPositiveButton(R.string.common_ok, new DialogInterface.OnClickListener() {\r
-                @Override\r
-                public void onClick(DialogInterface dialog, int which) {\r
-                    dialog.dismiss();\r
-                };\r
-            });\r
-            dialog = builder.create();\r
-            break;\r
-        }\r
-        default:\r
-            Log_OC.e(TAG, "Incorrect dialog called with id = " + id);\r
-        }\r
-        return dialog;\r
-    }\r
-\r
-\r
-    /**\r
      * Starts and activity to open the 'new account' page in the ownCloud web site\r
      * \r
      * @param view      'Account register' button\r
@@ -1749,11 +1626,6 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
 \r
         if (sessionCookie != null && sessionCookie.length() > 0) {\r
             mAuthToken = sessionCookie;\r
-\r
-//            GetRemoteUserNameOperation getUserOperation = new GetRemoteUserNameOperation();\r
-//            OwnCloudClient client = OwnCloudClientFactory.createOwnCloudClient(Uri.parse(mHostBaseUrl), getApplicationContext(), true);\r
-//            client.setSsoSessionCookie(mAuthToken);\r
-//            getUserOperation.execute(client, this, mHandler);\r
             boolean followRedirects = true;\r
             getRemoteUserNameOperation(sessionCookie, followRedirects);\r
         }\r
@@ -1768,7 +1640,7 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         getUserNameIntent.putExtra(OperationsService.EXTRA_FOLLOW_REDIRECTS, followRedirects);\r
         \r
         if (mOperationsServiceBinder != null) {\r
-            Log_OC.wtf(TAG, "starting getRemoteUserNameOperation..." );\r
+            //Log_OC.wtf(TAG, "starting getRemoteUserNameOperation..." );\r
             mGetUserNameOpId = mOperationsServiceBinder.newOperation(getUserNameIntent);\r
         }\r
     }\r
@@ -1776,12 +1648,10 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
 \r
     @Override\r
     public void onSsoFinished(String sessionCookies) {\r
-        //Toast.makeText(this, "got cookies: " + sessionCookie, Toast.LENGTH_LONG).show();\r
-\r
         if (sessionCookies != null && sessionCookies.length() > 0) {\r
             Log_OC.d(TAG, "Successful SSO - time to save the account");\r
             onSamlDialogSuccess(sessionCookies);\r
-            Fragment fd = getSupportFragmentManager().findFragmentByTag(TAG_SAML_DIALOG);\r
+            Fragment fd = getSupportFragmentManager().findFragmentByTag(SAML_DIALOG_TAG);\r
             if (fd != null && fd instanceof SherlockDialogFragment) {\r
                 Dialog d = ((SherlockDialogFragment)fd).getDialog();\r
                 if (d != null && d.isShowing()) {\r
@@ -1850,22 +1720,10 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
     }\r
 \r
     /**\r
-     * Dismiss untrusted cert dialog\r
-     */\r
-    public void dismissUntrustedCertDialog(){\r
-        /*Fragment frag = getSupportFragmentManager().findFragmentByTag(DIALOG_UNTRUSTED_CERT);\r
-        if (frag != null) {\r
-            SslErrorViewAdapter dialog = (SslErrorViewAdapter) frag;\r
-            dialog.dismiss();\r
-        }\r
-         */\r
-    }\r
-\r
-    /**\r
      * Called from SslValidatorDialog when a new server certificate was correctly saved.\r
      */\r
     public void onSavedCertificate() {\r
-        Fragment fd = getSupportFragmentManager().findFragmentByTag(TAG_SAML_DIALOG);\r
+        Fragment fd = getSupportFragmentManager().findFragmentByTag(SAML_DIALOG_TAG);\r
         if (fd == null) {\r
             // if SAML dialog is not shown, the SslDialog was shown due to an SSL error in the server check\r
             checkOcServer();\r
@@ -1878,28 +1736,16 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
      */\r
     @Override\r
     public void onFailedSavingCertificate() {\r
-        showDialog(DIALOG_CERT_NOT_SAVED);\r
-        cancelWebView();\r
+        dismissDialog(SAML_DIALOG_TAG);\r
+        Toast.makeText(this, R.string.ssl_validator_not_saved, Toast.LENGTH_LONG).show();\r
     }\r
 \r
     @Override\r
     public void onCancelCertificate() {\r
-        cancelWebView();\r
+        dismissDialog(SAML_DIALOG_TAG);\r
     }\r
 \r
 \r
-    public void cancelWebView() {\r
-        Fragment fd = getSupportFragmentManager().findFragmentByTag(TAG_SAML_DIALOG);\r
-        if (fd != null && fd instanceof SherlockDialogFragment) {\r
-            Dialog d = ((SherlockDialogFragment)fd).getDialog();\r
-            if (d != null && d.isShowing()) {\r
-                d.dismiss();\r
-            }\r
-        }\r
-\r
-    }\r
-    \r
-    \r
     private void doOnResumeAndBound() {\r
         //Log.wtf(TAG, "registering to listen for operation callbacks" );\r
         mOperationsServiceBinder.addOperationListener(AuthenticatorActivity.this, mHandler);\r
@@ -1945,6 +1791,16 @@ SsoWebViewClientListener, OnSslUntrustedCertListener {
         } \r
         \r
     }\r
+\r
+    \r
+    private void dismissDialog(String dialogTag){\r
+        Fragment frag = getSupportFragmentManager().findFragmentByTag(dialogTag);\r
+        if (frag != null && frag instanceof SherlockDialogFragment) {\r
+            SherlockDialogFragment dialog = (SherlockDialogFragment) frag;\r
+            dialog.dismiss();\r
+        }\r
+    }\r
+    \r
     \r
     /** \r
      * Implements callback methods for service binding. \r