X-Git-Url: http://git.linex4red.de/pub/Android/ownCloud.git/blobdiff_plain/e6fc5d13ad8aff2f70a84d9cf96b253a108b836d..01fc29c892bf5d1cb7dc1f8094d91a1a6a96a6bf:/src/com/owncloud/android/operations/SynchronizeFolderOperation.java?ds=inline diff --git a/src/com/owncloud/android/operations/SynchronizeFolderOperation.java b/src/com/owncloud/android/operations/SynchronizeFolderOperation.java index f12d5dd7..06760e85 100644 --- a/src/com/owncloud/android/operations/SynchronizeFolderOperation.java +++ b/src/com/owncloud/android/operations/SynchronizeFolderOperation.java @@ -34,6 +34,7 @@ import com.owncloud.android.lib.resources.files.ReadRemoteFileOperation; import com.owncloud.android.lib.resources.files.ReadRemoteFolderOperation; import com.owncloud.android.lib.resources.files.RemoteFile; import com.owncloud.android.operations.common.SyncOperation; +import com.owncloud.android.services.OperationsService; import com.owncloud.android.utils.FileStorageUtils; import java.io.File; @@ -98,8 +99,6 @@ public class SynchronizeFolderOperation extends SyncOperation { private List mFavouriteFilesToSyncContents; // this will be used for every file when 'folder synchronization' replaces 'folder download' - private List mFoldersToWalkDown; - private final AtomicBoolean mCancellationRequested; /** @@ -119,7 +118,6 @@ public class SynchronizeFolderOperation extends SyncOperation { mFilesForDirectDownload = new Vector(); mFilesToSyncContentsWithoutUpload = new Vector(); mFavouriteFilesToSyncContents = new Vector(); - mFoldersToWalkDown = new Vector(); mCancellationRequested = new AtomicBoolean(false); } @@ -161,9 +159,6 @@ public class SynchronizeFolderOperation extends SyncOperation { syncContents(client); } - if (mFilesForDirectDownload.isEmpty()) { - sendBroadcastForNotifyingUIUpdate(result.isSuccess()); - } } if (mCancellationRequested.get()) { @@ -172,18 +167,6 @@ public class SynchronizeFolderOperation extends SyncOperation { } catch (OperationCancelledException e) { result = new RemoteOperationResult(e); - - // Needed in case that cancellation occurs before starting any download. - // If not, yellow arrow continues being shown. - sendBroadcastForNotifyingUIUpdate(result.isSuccess()); - - /// cancellation of download needs to be done separately in any case; a SynchronizeFolderOperation - // may finish much sooner than the real download of the files in the folder - Intent intent = new Intent(mContext, FileDownloader.class); - intent.setAction(FileDownloader.ACTION_CANCEL_FILE_DOWNLOAD); - intent.putExtra(FileDownloader.EXTRA_ACCOUNT, mAccount); - intent.putExtra(FileDownloader.EXTRA_FILE, mLocalFolder); - mContext.startService(intent); } return result; @@ -228,7 +211,6 @@ public class SynchronizeFolderOperation extends SyncOperation { result.getLogMessage()); } - sendBroadcastForNotifyingUIUpdate(result.isSuccess()); } return result; @@ -304,11 +286,8 @@ public class SynchronizeFolderOperation extends SyncOperation { mFilesToSyncContentsWithoutUpload.clear(); mFavouriteFilesToSyncContents.clear(); - synchronized(mFoldersToWalkDown) { - if (mCancellationRequested.get()) { - throw new OperationCancelledException(); - } - mFoldersToWalkDown.clear(); + if (mCancellationRequested.get()) { + throw new OperationCancelledException(); } // get current data about local contents of the folder to synchronize @@ -365,18 +344,11 @@ public class SynchronizeFolderOperation extends SyncOperation { /// classify file to sync/download contents later if (remoteFile.isFolder()) { /// to download children files recursively - SynchronizeFolderOperation synchFolderOp = new SynchronizeFolderOperation( - mContext, - remoteFile.getRemotePath(), - mAccount, - mCurrentSyncTime - ); - - synchronized(mFoldersToWalkDown) { + synchronized(mCancellationRequested) { if (mCancellationRequested.get()) { throw new OperationCancelledException(); } - mFoldersToWalkDown.add(synchFolderOp); + startSyncFolderOperation(remoteFile.getRemotePath()); } } else if (remoteFile.keepInSync()) { @@ -418,18 +390,11 @@ public class SynchronizeFolderOperation extends SyncOperation { /// classify file to sync/download contents later if (child.isFolder()) { /// to download children files recursively - SynchronizeFolderOperation synchFolderOp = new SynchronizeFolderOperation( - mContext, - child.getRemotePath(), - mAccount, - mCurrentSyncTime - ); - - synchronized(mFoldersToWalkDown) { + synchronized(mCancellationRequested) { if (mCancellationRequested.get()) { throw new OperationCancelledException(); } - mFoldersToWalkDown.add(synchFolderOp); + startSyncFolderOperation(child.getRemotePath()); } } else { @@ -446,19 +411,20 @@ public class SynchronizeFolderOperation extends SyncOperation { startDirectDownloads(); startContentSynchronizations(mFilesToSyncContentsWithoutUpload, client); startContentSynchronizations(mFavouriteFilesToSyncContents, client); - walkSubfolders(client); // this must be the last! } private void startDirectDownloads() throws OperationCancelledException { for (OCFile file : mFilesForDirectDownload) { - if (mCancellationRequested.get()) { - throw new OperationCancelledException(); + synchronized(mCancellationRequested) { + if (mCancellationRequested.get()) { + throw new OperationCancelledException(); + } + Intent i = new Intent(mContext, FileDownloader.class); + i.putExtra(FileDownloader.EXTRA_ACCOUNT, mAccount); + i.putExtra(FileDownloader.EXTRA_FILE, file); + mContext.startService(i); } - Intent i = new Intent(mContext, FileDownloader.class); - i.putExtra(FileDownloader.EXTRA_ACCOUNT, mAccount); - i.putExtra(FileDownloader.EXTRA_FILE, file); - mContext.startService(i); } } @@ -474,7 +440,8 @@ public class SynchronizeFolderOperation extends SyncOperation { */ private void startContentSynchronizations(List filesToSyncContents, OwnCloudClient client) throws OperationCancelledException { - + + Log_OC.v(TAG, "Starting content synchronization... "); RemoteOperationResult contentsResult = null; for (SyncOperation op: filesToSyncContents) { if (mCancellationRequested.get()) { @@ -499,26 +466,6 @@ public class SynchronizeFolderOperation extends SyncOperation { } } - - private void walkSubfolders(OwnCloudClient client) throws OperationCancelledException { - RemoteOperationResult contentsResult = null; - for (SyncOperation op: mFoldersToWalkDown) { - if (mCancellationRequested.get()) { - throw new OperationCancelledException(); - } - contentsResult = op.execute(client, getStorageManager()); // to watch out: possibly deep recursion - if (!contentsResult.isSuccess()) { - // TODO - some kind of error count, and use it with notifications - if (contentsResult.getException() != null) { - Log_OC.e(TAG, "Non blocking exception : " - + contentsResult.getLogMessage(), contentsResult.getException()); - } else { - Log_OC.e(TAG, "Non blocking error : " + contentsResult.getLogMessage()); - } - } // won't let these fails break the synchronization process - } - } - /** * Creates and populates a new {@link com.owncloud.android.datamodel.OCFile} object with the data read from the server. @@ -556,29 +503,12 @@ public class SynchronizeFolderOperation extends SyncOperation { } } - private void sendBroadcastForNotifyingUIUpdate(boolean result) { - // Send a broadcast message for notifying UI update - Intent uiUpdate = new Intent(FileDownloader.getDownloadFinishMessage()); - uiUpdate.putExtra(FileDownloader.EXTRA_DOWNLOAD_RESULT, result); - uiUpdate.putExtra(FileDownloader.ACCOUNT_NAME, mAccount.name); - uiUpdate.putExtra(FileDownloader.EXTRA_REMOTE_PATH, mRemotePath); - uiUpdate.putExtra(FileDownloader.EXTRA_FILE_PATH, mLocalFolder.getRemotePath()); - mContext.sendStickyBroadcast(uiUpdate); - } - /** * Cancel operation */ public void cancel() { mCancellationRequested.set(true); - - synchronized(mFoldersToWalkDown) { - // cancel 'child' synchronizations - for (SyncOperation synchOp : mFoldersToWalkDown) { - ((SynchronizeFolderOperation) synchOp).cancel(); - } - } } public String getFolderPath() { @@ -588,4 +518,16 @@ public class SynchronizeFolderOperation extends SyncOperation { } return FileStorageUtils.getDefaultSavePathFor(mAccount.name, mLocalFolder); } + + private void startSyncFolderOperation(String path){ + Intent intent = new Intent(mContext, OperationsService.class); + intent.setAction(OperationsService.ACTION_SYNC_FOLDER); + intent.putExtra(OperationsService.EXTRA_ACCOUNT, mAccount); + intent.putExtra(OperationsService.EXTRA_REMOTE_PATH, path); + mContext.startService(intent); + } + + public String getRemotePath() { + return mRemotePath; + } }