X-Git-Url: http://git.linex4red.de/pub/Android/ownCloud.git/blobdiff_plain/5282400a10af6db98708ded2cad9d1c2046fee6e..f40fe2c98595fac0c417fdc3638e36b416470984:/src/eu/alefzero/webdav/WebdavClient.java diff --git a/src/eu/alefzero/webdav/WebdavClient.java b/src/eu/alefzero/webdav/WebdavClient.java index 797bad4d..dd3b4eae 100644 --- a/src/eu/alefzero/webdav/WebdavClient.java +++ b/src/eu/alefzero/webdav/WebdavClient.java @@ -21,11 +21,12 @@ import java.io.BufferedInputStream; import java.io.File; import java.io.FileOutputStream; import java.io.IOException; -import java.util.HashMap; import org.apache.commons.httpclient.Credentials; import org.apache.commons.httpclient.HttpClient; -import org.apache.commons.httpclient.HttpException; +import org.apache.commons.httpclient.HttpConnectionManager; +import org.apache.commons.httpclient.HttpVersion; +import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager; import org.apache.commons.httpclient.UsernamePasswordCredentials; import org.apache.commons.httpclient.auth.AuthScope; import org.apache.commons.httpclient.methods.GetMethod; @@ -34,21 +35,21 @@ import org.apache.commons.httpclient.methods.PutMethod; import org.apache.commons.httpclient.params.HttpMethodParams; import org.apache.commons.httpclient.protocol.Protocol; import org.apache.http.HttpStatus; +import org.apache.http.params.CoreProtocolPNames; import org.apache.jackrabbit.webdav.client.methods.DavMethod; import org.apache.jackrabbit.webdav.client.methods.DeleteMethod; import org.apache.jackrabbit.webdav.client.methods.MkColMethod; -import eu.alefzero.owncloud.AccountUtils; -import eu.alefzero.owncloud.authenticator.AccountAuthenticator; -import eu.alefzero.owncloud.authenticator.EasySSLSocketFactory; -import eu.alefzero.owncloud.files.interfaces.OnDatatransferProgressListener; -import eu.alefzero.owncloud.utils.OwnCloudVersion; - import android.accounts.Account; import android.accounts.AccountManager; import android.content.Context; import android.net.Uri; import android.util.Log; +import eu.alefzero.owncloud.AccountUtils; +import eu.alefzero.owncloud.authenticator.AccountAuthenticator; +import eu.alefzero.owncloud.authenticator.EasySSLSocketFactory; +import eu.alefzero.owncloud.files.interfaces.OnDatatransferProgressListener; +import eu.alefzero.owncloud.utils.OwnCloudVersion; public class WebdavClient extends HttpClient { private Uri mUri; @@ -56,37 +57,46 @@ public class WebdavClient extends HttpClient { final private static String TAG = "WebdavClient"; private static final String USER_AGENT = "Android-ownCloud"; private OnDatatransferProgressListener mDataTransferListener; - private static HashMap clients = new HashMap(); + static private MultiThreadedHttpConnectionManager mConnManager = null; + + static public MultiThreadedHttpConnectionManager getMultiThreadedConnManager() { + if (mConnManager == null) { + mConnManager = new MultiThreadedHttpConnectionManager(); + mConnManager.setMaxConnectionsPerHost(5); + mConnManager.setMaxTotalConnections(5); + } + return mConnManager; + } /** - * Gets a WebdavClient setup for the current account + * Creates a WebdavClient setup for the current account * @param account The client accout * @param context The application context * @return */ - public static synchronized WebdavClient getInstance(Account account, Context context){ - WebdavClient instance = clients.get(account.name); - if(instance == null ){ - OwnCloudVersion ownCloudVersion = new OwnCloudVersion(AccountManager.get(context).getUserData(account, - AccountAuthenticator.KEY_OC_VERSION)); - String baseUrl = AccountManager.get(context).getUserData(account, AccountAuthenticator.KEY_OC_BASE_URL); - String webDavPath = AccountUtils.getWebdavPath(ownCloudVersion); - WebdavClient client = new WebdavClient(); - - String username = account.name.substring(0, account.name.indexOf('@')); - String password = AccountManager.get(context).getPassword(account); - - client.mUri = Uri.parse(baseUrl + webDavPath); - client.getParams().setParameter(HttpMethodParams.USER_AGENT, USER_AGENT); - client.setCredentials(username, password); - client.allowSelfsignedCertificates(); - clients.put(account.name, client); - } - return instance; + public WebdavClient (Account account, Context context) { + OwnCloudVersion ownCloudVersion = new OwnCloudVersion(AccountManager.get(context).getUserData(account, + AccountAuthenticator.KEY_OC_VERSION)); + String baseUrl = AccountManager.get(context).getUserData(account, AccountAuthenticator.KEY_OC_BASE_URL); + String webDavPath = AccountUtils.getWebdavPath(ownCloudVersion); + String username = account.name.substring(0, account.name.indexOf('@')); + String password = AccountManager.get(context).getPassword(account); + + mUri = Uri.parse(baseUrl + webDavPath); + + setCredentials(username, password); + } + + public WebdavClient() { + super(getMultiThreadedConnManager()); + + getParams().setParameter(HttpMethodParams.USER_AGENT, USER_AGENT); + getParams().setParameter(CoreProtocolPNames.PROTOCOL_VERSION, HttpVersion.HTTP_1_1); + allowSelfsignedCertificates(); } public void setCredentials(String username, String password) { - getParams().setAuthenticationPreemptive(true); + //getParams().setAuthenticationPreemptive(true); getState().setCredentials(AuthScope.ANY, getCredentials(username, password)); } @@ -104,21 +114,11 @@ public class WebdavClient extends HttpClient { } public boolean downloadFile(String remoteFilepath, File targetPath) { - // HttpGet get = new HttpGet(mUri.toString() + filepath.replace(" ", - // "%20")); - /* dvelasco - this is not necessary anymore; OCFile.mRemotePath (the origin of remoteFielPath) keeps valid URL strings - String[] splitted_filepath = remoteFilepath.split("/"); - remoteFilepath = ""; - for (String s : splitted_filepath) { - if (s.equals("")) continue; - remoteFilepath += "/" + URLEncoder.encode(s); - } - - Log.e("ASD", mUri.toString() + remoteFilepath.replace(" ", "%20") + ""); - GetMethod get = new GetMethod(mUri.toString() - + remoteFilepath.replace(" ", "%20")); - */ + boolean ret = false; GetMethod get = new GetMethod(mUri.toString() + remoteFilepath); + HttpMethodParams params = get.getParams(); + params.setSoTimeout(0); // that means "infinite timeout"; it's the default value, but let's make it explicit + get.setParams(params); // get.setHeader("Host", mUri.getHost()); // get.setHeader("User-Agent", "Android-ownCloud"); @@ -126,26 +126,28 @@ public class WebdavClient extends HttpClient { try { int status = executeMethod(get); Log.e(TAG, "status return: " + status); - if (status != HttpStatus.SC_OK) { - return false; - } - BufferedInputStream bis = new BufferedInputStream( - get.getResponseBodyAsStream()); - FileOutputStream fos = new FileOutputStream(targetPath); - - byte[] bytes = new byte[4096]; - int readResult; - while ((readResult = bis.read(bytes)) != -1) { - if (mDataTransferListener != null) - mDataTransferListener.transferProgress(readResult); - fos.write(bytes, 0, readResult); + if (status == HttpStatus.SC_OK) { + targetPath.createNewFile(); + BufferedInputStream bis = new BufferedInputStream( + get.getResponseBodyAsStream()); + FileOutputStream fos = new FileOutputStream(targetPath); + + byte[] bytes = new byte[4096]; + int readResult; + while ((readResult = bis.read(bytes)) != -1) { + if (mDataTransferListener != null) + mDataTransferListener.transferProgress(readResult); + fos.write(bytes, 0, readResult); + } + } - - } catch (IOException e) { + ret = true; + } catch (Throwable e) { e.printStackTrace(); - return false; + targetPath.delete(); } - return true; + + return ret; } /** @@ -157,8 +159,8 @@ public class WebdavClient extends HttpClient { DavMethod delete = new DeleteMethod(mUri.toString() + remoteFilePath); try { executeMethod(delete); - } catch (IOException e) { - Log.e(TAG, "Logging failed with error: " + e.getMessage(), e); + } catch (Throwable e) { + Log.e(TAG, "Deleting failed with error: " + e.getMessage(), e); return false; } return true; @@ -179,6 +181,9 @@ public class WebdavClient extends HttpClient { entity.setOnDatatransferProgressListener(mDataTransferListener); Log.e("ASD", f.exists() + " " + entity.getContentLength()); PutMethod put = new PutMethod(mUri.toString() + remoteTarget); + HttpMethodParams params = put.getParams(); + params.setSoTimeout(0); // that means "infinite timeout"; it's the default value, but let's make it explicit + put.setParams(params); put.setRequestEntity(entity); Log.d(TAG, "" + put.getURI().toString()); int status = executeMethod(put); @@ -200,12 +205,13 @@ public class WebdavClient extends HttpClient { * @param password Password to verify * @return A {@link HttpStatus}-Code of the result. SC_OK is good. */ - public int tryToLogin(Uri uri, String username, String password) { + public static int tryToLogin(Uri uri, String username, String password) { int returnCode = 0; - setCredentials(username, password); + WebdavClient client = new WebdavClient(); + client.setCredentials(username, password); HeadMethod head = new HeadMethod(uri.toString()); try { - returnCode = executeMethod(head); + returnCode = client.executeMethod(head); } catch (Exception e) { Log.e(TAG, "Error: " + e.getMessage()); }